| Summary: | Review Request: fpc-srpm-macros - RPM macros needed by packages built with Free Pascal Compiler | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mattia Verga <mattia.verga> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, praiskup, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-04-09 15:26:07 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Mattia Verga
2016-03-14 17:17:16 UTC
URL is bogus — it's the project page, not the Fedora package page... Or is the project not supposed to exists outside of dist-git at all? That'd be fine, but please add a comment in the spec file to not confuse people. Both the macros file and the srpm follow convention. You should add a %license file. Or, maybe the license should be changed to Public Domain? I think that's more reasonable for a package this small, and no license file would be needed. Anyway, package is APPROVED. Thanks. I made this package similar to gnat-srpm-macros.git. Yes, there's no URL outside dist-git, so I used the same approach of gnat-srpm-macros. I will add a comment to clarify that. About the license: I used MIT because the Fedora Project Contributor Agreement states that the default license for contributions in Fedora is MIT. However I have no problem to change it to Public Domain. I will do that while importing. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/fpc-srpm-macros fpc-srpm-macros-1.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d94fe63c90 fpc-srpm-macros-1.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d94fe63c90 fpc-srpm-macros-1.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. I can't resist :) because that's funny enough, ignore me: This looked like 'Fedora Packaging Committee' macros to me, I was really wondering whether this is yet another alternative to `fedora-rpm-macros`. |