Bug 1317682

Summary: hammer activation-key still mentions 'content-host'
Product: Red Hat Satellite Reporter: Og Maciel <omaciel>
Component: HammerAssignee: Zach Huntington-Meath <zhunting>
Status: CLOSED ERRATA QA Contact: Kedar Bidarkar <kbidarka>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.2.0CC: bbuckingham, kbidarka, mmccune
Target Milestone: UnspecifiedKeywords: PrioBumpQA, Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
URL: http://projects.theforeman.org/issues/14272
Whiteboard:
Fixed In Version: rubygem-katello-3.0.0.26-1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-07-27 11:43:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Og Maciel 2016-03-14 20:48:11 UTC
Description of problem:

Current version of hammer shows that the subcommand 'activation-key' still shows the term 'content-host'. We should not be using 'content-host' anymore, and instead use 'host'.

hammer> activation-key create -h
Usage:
     activation-key create [OPTIONS]

Options:
 --content-view CONTENT_VIEW_NAME                    Content view name to search by
 --content-view-id CONTENT_VIEW_ID                   content view numeric identifier
 --description DESCRIPTION                           description
 --lifecycle-environment LIFECYCLE_ENVIRONMENT_NAME  Name to search by
 --lifecycle-environment-id LIFECYCLE_ENVIRONMENT_ID
 --max-content-hosts MAX_CONTENT_HOSTS               maximum number of registered content hosts
 --name NAME                                         name
 --organization ORGANIZATION_NAME                    Organization name to search by
 --organization-id ORGANIZATION_ID                   organization ID
 --organization-label ORGANIZATION_LABEL             Organization label to search by
 --unlimited-content-hosts                           Set content hosts max to unlimited
 -h, --help                                          print help


So the following changes will be required:

* max-content-hosts > max-hosts
* unlimited-content-hosts > unlimited-hosts

It is possible that other subcommands are still referring to 'content-host', so a thorough investigation and fix will be required.


Version-Release number of selected component (if applicable):

* Satellite 6.2.0 SNAP 3.1

How reproducible:


Steps to Reproduce:
1. Check the output of running the activation-key hammer command and check for 'content-host' in its output
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Brad Buckingham 2016-03-16 15:31:16 UTC
Zach, assigning this one to you.  It should be a matter of updating terminology from 'content-host' to 'host'.

The bug raised the issue in the context of activation-key; however, we should also scrub host-collection, which provides a similar behavior.

In addition, it raises the issue on the CLI; however, we should also address it for the UI for consistency.

Comment 3 Zach Huntington-Meath 2016-03-18 15:29:22 UTC
Created redmine issue http://projects.theforeman.org/issues/14272 from this bug

Comment 4 Bryan Kearney 2016-03-21 18:05:25 UTC
Moving to POST since upstream bug http://projects.theforeman.org/issues/14272 has been closed
-------------
Zach Huntington-Meath
Applied in changeset commit:katello|cc989ff0e45d4fdc8f519b8a0bdf3c3511606564.

Comment 5 Kedar Bidarkar 2016-05-24 09:57:30 UTC
 ~]# hammer host-collection create -h
Usage:
    hammer host-collection create [OPTIONS]

Options:
 --description DESCRIPTION                
 --host-ids HOST_IDS                     List of host ids to replace the hosts in host collection
                                         Comma separated list of values.
 --hosts HOST_NAMES                      Comma separated list of values.
 --max-hosts MAX_HOSTS                   Maximum number of hosts in the host collection
 --name NAME                             Host Collection name
 --organization ORGANIZATION_NAME        Organization name to search by
 --organization-id ORGANIZATION_ID       organization ID
 --organization-label ORGANIZATION_LABEL Organization label to search by
 --unlimited-hosts UNLIMITED_HOSTS       Whether or not the host collection may have unlimited hosts
                                         One of true/false, yes/no, 1/0.
 -h, --help                              print help
[root@xyz ~]# hammer activation-key create -h 
Usage:
    hammer activation-key create [OPTIONS]

Options:
 --content-view CONTENT_VIEW_NAME                    Content view name to search by
 --content-view-id CONTENT_VIEW_ID                   content view numeric identifier
 --description DESCRIPTION                           description
 --lifecycle-environment LIFECYCLE_ENVIRONMENT_NAME  Name to search by
 --lifecycle-environment-id LIFECYCLE_ENVIRONMENT_ID  
 --max-hosts MAX_HOSTS                               maximum number of registered content hosts
 --name NAME                                         name
 --organization ORGANIZATION_NAME                    Organization name to search by
 --organization-id ORGANIZATION_ID                   organization ID
 --organization-label ORGANIZATION_LABEL             Organization label to search by
 --unlimited-hosts                                   Set hosts max to unlimited
 -h, --help                                          print help



hammer help commands now show "hosts" instead of "content-hosts".

VERIFIED with sat62-snap12.1

Comment 6 Bryan Kearney 2016-07-27 11:43:03 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1501