Bug 1318203

Summary:	Tiering should break out of iterating query file once cycle time completes.
Product:	[Community] GlusterFS	Reporter:	Dan Lambright <dlambrig>
Component:	tiering	Assignee:	Dan Lambright <dlambrig>
Status:	CLOSED CURRENTRELEASE	QA Contact:	bugs <bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.9	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.9	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1301227	Environment:
Last Closed:	2016-04-19 07:20:19 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1301227
Bug Blocks:

Description Dan Lambright 2016-03-16 09:27:22 UTC

+++ This bug was initially created as a clone of Bug #1301227 +++

Description of problem:

When iterating the query file during migration, should break out of loop once cycle time completes.

Version-Release number of selected component (if applicable):

N/A

How reproducible:

always

Steps to Reproduce:
1. Set demotion cycle time to 120 seconds.
2. Create many large files.
2. Wait for them to be demoted.

Actual results:

All the files will be demoted, this may take longer than 120 seconds. 

Expected results:

As many files as can be moved in 120 seconds shall be migrated.

Additional info:

--- Additional comment from Vijay Bellur on 2016-02-02 17:07:06 EST ---

REVIEW: http://review.gluster.org/13284 (cluster/tier: break out of iterating query file once cycle time ends) posted (#2) for review on master by Dan Lambright (dlambrig)

--- Additional comment from Vijay Bellur on 2016-02-03 11:15:26 EST ---

COMMIT: http://review.gluster.org/13284 committed in master by Dan Lambright (dlambrig) 
------
commit 58a91f36f639de21f6e77d1f43f5eb091ae96fb0
Author: Dan Lambright <dlambrig>
Date:   Fri Jan 22 17:31:48 2016 -0500

    cluster/tier: break out of iterating query file once cycle time ends
    
    When iterating the query file during migration, tiering should
    break out of the loop once cycle time completes. Otherwise it
    may be possible to stay in the loop for a long time. If that
    happens updates to files will become stale and have not impact
    migration.
    
    Change-Id: Ib60cf74bc84e8646e6a0da21ff04954b1b83c414
    BUG: 1301227
    Signed-off-by: Dan Lambright <dlambrig>
    Reviewed-on: http://review.gluster.org/13284
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>

Comment 1 Vijay Bellur 2016-03-16 09:28:15 UTC

REVIEW: http://review.gluster.org/13750 (cluster/tier: break out of iterating query file once cycle time ends) posted (#1) for review on release-3.7 by Dan Lambright (dlambrig)

Comment 2 Vijay Bellur 2016-03-17 04:37:54 UTC

COMMIT: http://review.gluster.org/13750 committed in release-3.7 by Dan Lambright (dlambrig) 
------
commit 9fbcf7f862df50925c3e2b83740c30ccd55e80dd
Author: Dan Lambright <dlambrig>
Date:   Fri Jan 22 17:31:48 2016 -0500

    cluster/tier: break out of iterating query file once cycle time ends
    
    When iterating the query file during migration, tiering should
    break out of the loop once cycle time completes. Otherwise it
    may be possible to stay in the loop for a long time. If that
    happens updates to files will become stale and have not impact
    migration.
    
    This is a backport of 13284
    
    > Change-Id: Ib60cf74bc84e8646e6a0da21ff04954b1b83c414
    > BUG: 1301227
    > Signed-off-by: Dan Lambright <dlambrig>
    > Reviewed-on: http://review.gluster.org/13284
    > Smoke: Gluster Build System <jenkins.com>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.com>
    Signed-off-by: Dan Lambright <dlambrig>
    
    Change-Id: Ia305784b0aa570b70e54f532bf5d68a91b0cf305
    BUG: 1318203
    Reviewed-on: http://review.gluster.org/13750
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: hari gowtham <hari.gowtham005>
    Tested-by: Dan Lambright <dlambrig>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Dan Lambright <dlambrig>

Comment 3 Kaushal 2016-04-19 07:20:19 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.9, please open a new bug report.

glusterfs-3.7.9 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-users/2016-March/025922.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user