Bug 1318251

Summary:	Review Request: perl-Test-Time - Overrides the time() and sleep() core functions for testing
Product:	[Fedora] Fedora	Reporter:	Emmanuel Seyman <emmanuel>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-03-19 15:46:26 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:
Bug Blocks:	1230213

Description Emmanuel Seyman 2016-03-16 11:13:06 UTC

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Test-Time/perl-Test-Time.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Test-Time/perl-Test-Time-0.04-1.fc23.src.rpm
Description:
Test::Time can be used to test modules that deal with time. Once you use
this module, all references to time and sleep will be internalized. You can
set custom time by passing time => number after the use statement.

Fedora Account System Username: eseyman
Rpmlint Output: 2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Third time's the charm, right?

Comment 1 Jitka Plesnikova 2016-03-16 14:53:31 UTC

Source file is ok
Summary is ok
License is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Test-Time-0.04-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.22.1)
      1 perl(Test::More)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Test-Time-0.04-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(Test::Time) = 0.04
      1 perl-Test-Time = 0.04-1.fc25
Binary provides are Ok.

$ rpmlint ./perl-Test-Time*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

BuildRequires 
FIX:
* Please add missing BRs
- perl(Module::Install::Include) - provides auto_include - Makefile.PL:43
- perl(Module::Install::Metadata) - provides all_from - Makefile.PL:24
- perl(Module::Install::WriteAll) - provides WriteAll - Makefile.PL:44 
* Removed BRs
- perl(Filter::Util::Call) - it is not used


TODO: Because you remove all files from repository inc, it could be done
  easily, e.g.
rm -r inc
sed -i -e '/^inc\// d' MANIFEST

In that case, the 'findutils' could be removed from BRs

TODO: You can replace %__perl macros with plain perl command.

Description is ok
TODO: Please replace ':' at the end of description with '.'

Please correct 'FIX' issue and consider fixing 'TODO' items and
provide new spec file.

The package is not approved

Comment 2 Emmanuel Seyman 2016-03-16 18:02:53 UTC

(In reply to Jitka Plesnikova from comment #1)
> Source file is ok
> Summary is ok
> License is ok
> URL and Source0 are ok
> All tests passed
> 
> $ rpm -qp --requires perl-Test-Time-0.04-1.fc25.noarch.rpm | sort | uniq -c
>       1 perl(:MODULE_COMPAT_5.22.1)
>       1 perl(Test::More)
>       1 perl(strict)
>       1 perl(warnings)
>       1 rpmlib(CompressedFileNames) <= 3.0.4-1
>       1 rpmlib(FileDigests) <= 4.6.0-1
>       1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
>       1 rpmlib(PayloadIsXz) <= 5.2-1
> Binary requires are Ok.
> 
> $ rpm -qp --provides perl-Test-Time-0.04-1.fc25.noarch.rpm | sort | uniq -c
>       1 perl(Test::Time) = 0.04
>       1 perl-Test-Time = 0.04-1.fc25
> Binary provides are Ok.
> 
> $ rpmlint ./perl-Test-Time*
> 2 packages and 1 specfiles checked; 0 errors, 0 warnings.
> Rpmlint is ok
> 
> BuildRequires 
> FIX:
> * Please add missing BRs
> - perl(Module::Install::Include) - provides auto_include - Makefile.PL:43
> - perl(Module::Install::Metadata) - provides all_from - Makefile.PL:24
> - perl(Module::Install::WriteAll) - provides WriteAll - Makefile.PL:44 
> * Removed BRs
> - perl(Filter::Util::Call) - it is not used

Done.

> TODO: Because you remove all files from repository inc, it could be done
>   easily, e.g.
> rm -r inc
> sed -i -e '/^inc\// d' MANIFEST
> 
> In that case, the 'findutils' could be removed from BRs

Indeed. Done.

> Description is ok
> TODO: Please replace ':' at the end of description with '.'

Done.


Spec URL: http://people.parinux.org/~seyman/fedora/perl-Test-Time/perl-Test-Time.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Test-Time/perl-Test-Time-0.04-2.fc23.src.rpm

Comment 3 Jitka Plesnikova 2016-03-17 07:37:04 UTC

It looks good now. 

Approved

Comment 4 Emmanuel Seyman 2016-03-19 15:46:26 UTC

Built for rawhide, updates have been issued for f23 and f24.
Jikta, thank you for the review.