Bug 1318471

Summary:	Option to disable flag inclusion
Product:	[Community] Bugzilla	Reporter:	Matt Tyson 🤬 <mtyson>
Component:	Administration	Assignee:	PnT DevOps Devs <hss-ied-bugs>
Status:	CLOSED NOTABUG	QA Contact:	tools-bugs <tools-bugs>
Severity:	high	Docs Contact:
Priority:	low
Version:	4.4	CC:	huiwang, qgong
Target Milestone:	5.0-RH8
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-10-17 05:08:15 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Matt Tyson 🤬 2016-03-17 00:56:15 UTC

Flags can be used across many products.  There will be times when a product no longer wishes to use a particular flag.

Disabling this flag isn't an option, as the other products will wish to use it.

This means the only option is to remove the flag inclusion for that product.
The problem with this is that when the flag inclusion is removed, the existing flag state is destroyed.

What would be better in this case is to disable the inclusion so that the existing flag data is preserved.


Also, the usage of this state should be logged, see bug 1315542

Comment 1 Jeff Fearn 🐞 2016-10-11 11:36:12 UTC

Why do we want to retain state that is no longer being used?

Comment 2 Matt Tyson 🤬 2016-10-11 22:59:04 UTC

(In reply to Jeff Fearn from comment #1)
> Why do we want to retain state that is no longer being used?

To preserve bug history.

If the flag inclusion is removed then the flag is removed from all bugs and bug history, as if it never existed.

Comment 3 Jeff Fearn 🐞 2019-10-17 05:08:15 UTC

(In reply to Matt Tyson 🤬 from comment #2)
> (In reply to Jeff Fearn from comment #1)
> > Why do we want to retain state that is no longer being used?
> 
> To preserve bug history.
> 
> If the flag inclusion is removed then the flag is removed from all bugs and
> bug history, as if it never existed.

This is incorrect, if you remove an inclusion for a flag the history is left alone and is visible to users who can see the flag.

Note if a flag is deleted the history is also left in place, but the flag's history on bugs becomes open.