Bug 1318657

Summary:	VDSM keeps sending api-version messages to the guest agent when the guest agent is supporting a higher API Version than VDSM
Product:	[oVirt] vdsm	Reporter:	Vinzenz Feenstra [evilissimo] <vfeenstr>
Component:	Core	Assignee:	Vinzenz Feenstra [evilissimo] <vfeenstr>
Status:	CLOSED CURRENTRELEASE	QA Contact:	sefi litmanovich <slitmano>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.15.0	CC:	bugs, michal.skrivanek
Target Milestone:	ovirt-3.6.5	Flags:	vfeenstr: ovirt-3.6.z? vfeenstr: ovirt-4.0.0? vfeenstr: planning_ack? rule-engine: devel_ack+ rule-engine: testing_ack+
Target Release:	4.17.25
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	3.6.5-1	Doc Type:	Bug Fix
Doc Text:	Previously when having a virtual machine with a version of the guest agent on the guest OS for a higher cluster version than the cluster version it was running on, it was possible that vdsm kept sending a reply to the heart beat of the guest agent with the attempt renegotiate the version. This might have been caused logs filling up slowly on the guest. This issue has now been resolved.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-04-21 14:38:17 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Virt	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Vinzenz Feenstra [evilissimo] 2016-03-17 13:09:07 UTC

Description of problem:

The VDSM API Version negotiation has a problem where it keeps sending the 'api-version' message to the guest agent, even though the negotiation has already taken place.

This happens in cases where the VDSM version is supporting a lower API Version then the guest agent. As this is the case between 3.5 and 3.6

VDSM (4.16.20) @ 3.5 supports API Version 1
ovirt-guest-agent (1.0.11) @ 3.6 supports API Version 2 

Version-Release number of selected component (if applicable):
vdsm-4.16.20

How reproducible:
100%

Steps to Reproduce:
1. setup a 3.5 cluster with 3.5 vdsm installed (4.16.20)
2. create a CentOS 7 VM with the latest guest agent from 3.6 (1.0.11) through epel  

Actual results:
Every two seconds (with every heart beat) an api-version message is sent to the guest agent (seen in the logs on INFO level)

Expected results:
Negotiation only once per migration/vm start/ovirt-guest-agent start or VDSM restart

Comment 1 Eyal Edri 2016-03-31 08:35:52 UTC

Bugs moved pre-mature to ON_QA since they didn't have target release.
Notice that only bugs with a set target release will move to ON_QA.

Comment 2 sefi litmanovich 2016-04-12 14:47:46 UTC

Reproduced as per description.
Verified behaviour with vdsm-4.17.26-0.el7ev on host and ovirt-guest-agent-common-1.0.11-3.el7.noarch on guest.
Message appear only on first communication.