Bug 1318756

Summary: hex-a-hop's NVR doesn't comply to FPG
Product: [Fedora] Fedora Reporter: Ralf Corsepius <rc040203>
Component: hex-a-hopAssignee: Mario Blättermann <mario.blaettermann>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: 22CC: mario.blaettermann
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: hex-a-hop-1.2.0-0.4.20140926git3bad56e.fc24 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-03-29 19:34:43 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ralf Corsepius 2016-03-17 17:24:58 UTC
Description of problem:

hex-a-hop's NVR-scheme doesn't comply to the Fedora Packaging Guideline

It currently uses: hex-a-hop-1.2.0-git20140926.1.fc25.3

From what I see on 
https://sourceforge.net/p/hexahop/code/ci/master/tree/

this version actually is a
- 1.2.0 prerelease git snapshot
- git commit 3bad56e54709c7f1843048ec1d62cc7204e07bfd
- taken at 20140926


So, according to https://fedoraproject.org/wiki/Packaging:NamingGuidelines
this would correspond to:

hex-a-hop-1.2.0-0.3.20140926git3bad56e.fc25

To cut a long story short, I am proposing this patch:

diff --git a/hex-a-hop.spec b/hex-a-hop.spec
index fe2d02f..976385b 100644
--- a/hex-a-hop.spec
+++ b/hex-a-hop.spec
@@ -1,8 +1,10 @@
 %global  snapshot 20140926
+%global  commit 3bad56e54709c7f1843048ec1d62cc7204e07bfd
+%global  shortcommit %(c=%{commit}; echo ${c:0:7})

 Name:           hex-a-hop
 Version:        1.2.0
-Release:        git%{snapshot}.1%{?dist}.3
+Release:        0.3.%{snapshot}git%{shortcommit}%{?dist}
 Summary:        Puzzle game based on hexagonal tiles

 License:        GPLv2+

Comment 1 Fedora Update System 2016-03-23 03:33:22 UTC
hex-a-hop-1.2.0-0.4.20140926git3bad56e.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-4b318299c0

Comment 2 Fedora Update System 2016-03-23 19:56:16 UTC
hex-a-hop-1.2.0-0.4.20140926git3bad56e.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-4b318299c0

Comment 3 Fedora Update System 2016-03-29 19:34:38 UTC
hex-a-hop-1.2.0-0.4.20140926git3bad56e.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.