| Summary: | Please update f2fs-tools to version 1.6.0 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Gene Snider <genes1122> |
| Component: | f2fs-tools | Assignee: | Eduardo Echeverria <echevemaster> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 24 | CC: | echevemaster, genes1122 |
| Target Milestone: | --- | Keywords: | FutureFeature, Reopened |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | f2fs-tools-1.7.0-1.fc24 f2fs-tools-1.7.0-1.fc25 | Doc Type: | Enhancement |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-11-10 03:22:23 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Gene Snider
2016-03-17 21:36:50 UTC
*** Bug 1318808 has been marked as a duplicate of this bug. *** Thanks I will update the package the next week, thanks Thanks! The current release is 1.7 now. :) Gene Built in rawhide, F25 and F24, closing this thread. f2fs-tools-1.7.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-15d3c2305e f2fs-tools-1.7.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-8d878e3848 Thanks! However, %patch0 -p1 -b .bigendian is no longer needed in the spec file. The contents of f2fs-tools-1.4.0-bigendian.patch added a line as follows to f2fs-tools*//include/f2fs_fs.h: +#include <byteswap.h> f2fs_fs.h already had a confitional include for the file, but the flag was never set by configure. However, upstream noticed and corrected that quite some time ago. Here's the commit that fixed it: author Yann E. MORIN <yann.morin.1998> 2014-12-25 17:39:19 (GMT) committer Jaegeuk Kim <jaegeuk> 2014-12-29 18:09:46 (GMT) commit 936945a25d1b96535f1c3fbb81176f2ce3f848e1 (patch) tree 0965715d882743644aca92abaac87e80b82a2e7a parent 4757ef07d9d114f1abf8d900e94d00c8cc6bd05c (diff) configure: also check for byteswap.h include/f2fs_fs.h checks the HAVE_BYTESWAP_H conditional, but it is never checked for in configure. Add that header to the list of headers checked for. Signed-off-by: "Yann E. MORIN" <yann.morin.1998> Cc: Gustavo Zacarias <gustavo.ar> Signed-off-by: Jaegeuk Kim <jaegeuk> Diffstat -rw-r--r-- configure.ac 2 1 files changed, 1 insertions, 1 deletions diff --git a/configure.ac b/configure.ac index d66cb73..7cfd9b4 100644 --- a/configure.ac +++ b/configure.ac @@ -57,7 +57,7 @@ PKG_CHECK_MODULES([libuuid], [uuid]) # Checks for header files. AC_CHECK_HEADERS([linux/fs.h fcntl.h mntent.h stdlib.h string.h \ - sys/ioctl.h sys/mount.h unistd.h linux/falloc.h]) + sys/ioctl.h sys/mount.h unistd.h linux/falloc.h byteswap.h]) # Checks for typedefs, structures, and compiler characteristics. AC_C_INLINE So now the patch just adds a redundant include to f2fs-tools*//include/f2fs_fs.h. I've been building it without that patch since 1.6 with no problems. Also, the opensuse spec file f2fs-tools-1.6.0-30.3.src.rpm does NOT have any patches to upstream. There are some useful comments in their spec file, you might check it out. Thanks, Gene f2fs-tools-1.7.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. f2fs-tools-1.7.0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. |