Bug 1318843

Summary:	virDomainDefineXML removes "mode" attribute from a vhostuser interface
Product:	[Community] Virtualization Tools	Reporter:	Yi Ba <yby.developer>
Component:	libvirt	Assignee:	Libvirt Maintainers <libvirt-maint>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	laine, rbalakri, shyu, ztehypervisor
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-03-28 05:02:36 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Yi Ba 2016-03-18 00:36:58 UTC

Description of problem:
When trying to launch a VM, virDomainDefineXML removes "mode" attribute from a vhostuser interface, causing domain.createWithFlags to fail in nova/virt/libvirt/driver.py .
According to libvirt website, vhost-user should have been supported since 1.2.7 (https://libvirt.org/formatdomain.html#elementVhostuser).

Version-Release number of selected component (if applicable):
libvirt is 1.2.9-9

How reproducible:
I am working with openstack kilo, where libvirt is set to 1.2.9-9, with opendaylight as the controller, but I believe this can be reproduced using devstack kilo with networking-ovs-dpdk plugin.

Steps to Reproduce:
1. load devstack as allinone node, with networking-ovs-dpdk enabled
2. launch a VM
3. make sure libvirt is set to 1.2.9

Actual results:
libvirtError: internal error: No <source> 'mode' attribute specified with <interface type='vhostuser'/>

Expected results:
VM instantiation succeeds

Additional info:

Comment 1 Yi Ba 2016-03-28 05:02:36 UTC

This looks like it was resolved anywhere between 1.2.9 and 1.2.16

Comment 2 Michael Liu 2016-06-30 06:41:18 UTC

It seems can't reproduce the problem  with the version 1.2.15.