Bug 1318887

Summary: "Starting virt-who" status is wrong when password can't be decrypted
Product: Red Hat Enterprise Linux 6 Reporter: Liushihui <shihliu>
Component: virt-whoAssignee: Chris Snyder <csnyder>
Status: CLOSED ERRATA QA Contact: Eko <hsun>
Severity: medium Docs Contact:
Priority: high    
Version: 6.8CC: ldai, rbalakri, sgao, thozza, xdmoon
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: virt-who-0.18-1.el6 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-03-21 10:29:12 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1269194, 1355878, 1385841    

Description Liushihui 2016-03-18 03:41:00 UTC
Description of problem:
When password can't be decrypted, start virt-who service, although virt-who isn't started,it still show virt-who start [OK] in terminal side.

Version-Release number of selected component (if applicable):
virt-who-0.16-7.el6.noarch
subscription-manager-1.16.8-5.el6.x86_64
python-rhsm-1.16.6-1.el6.x86_64

How reproducible:
Always

Steps to Reproduce:
1. Register system to stage candlepin.
2. Configure virt-who with a wrong encrypted_password
[root@ibm-x3250m4-16 virt-who.d]# cat /etc/virt-who.d/esx 
[test-esx1]
type=esx
server=10.73.2.95
username=Administrator
encrypted_password=xxxxx
owner=7715246
env=7715246
3. Start virt-who service and check virt-who's thread and log.
[root@ibm-x3250m4-16 virt-who.d]# service virt-who start && tail -f /var/log/rhsm/rhsm.log
Starting virt-who:                                         [  OK  ]

2016-03-17 23:17:49,403 [virtwho.init INFO] MainProcess(26590):MainThread @virtwho.py:parseOptions:637 - Using reporter_id='ibm-x3250m4-16.rhts.eng.bos.redhat.com'
2016-03-17 23:17:49,405 [virtwho.init DEBUG] MainProcess(26590):MainThread @virtwho.py:__init__:125 - Using config named 'test-esx1'
2016-03-17 23:17:49,406 [virtwho.init INFO] MainProcess(26590):MainThread @virtwho.py:main:729 - Using configuration "test-esx1" ("esx" mode)
2016-03-17 23:17:49,419 [virtwho.main DEBUG] MainProcess(26592):MainThread @virtwho.py:run:231 - Starting infinite loop with 60 seconds interval
2016-03-17 23:17:49,523 [virtwho.main ERROR] MainProcess(26592):MainThread @virtwho.py:run:244 - Unable to use configuration "test-esx1": Password can't be decrypted, possibly corrupted
2016-03-17 23:17:49,523 [virtwho.main ERROR] MainProcess(26592):MainThread @virtwho.py:run:255 - No suitable virt backend found
2016-03-17 23:17:49,524 [virtwho.main DEBUG] MainProcess(26592):MainThread @virtwho.py:<module>:824 - virt-who terminated
2016-03-17 23:17:49,524 [virtwho.main DEBUG] MainProcess(26592):MainThread @virtwho.py:terminate:359 - virt-who is shutting down
[root@ibm-x3250m4-16 virt-who.d]# ps -ef|grep virt-who
root     26517 22302  0 23:16 pts/2    00:00:00 grep virt-who

Actual results:
Although virt-who is not start, it still show "Starting virt-who [OK]" in terminal side.

Expected results:
As virt-who is not start, it should show "Starting virt-who [FAILED]" in terminal side.it also better to show the error reason "Password can't be decrypted, possibly corrupted" in the terminal side.

Additional info:

Comment 1 Liushihui 2016-04-06 06:21:31 UTC
It has the same problem when the encrypted_password is null,restart virt-who service, it also can't display correct status in terminal side.

[root@hp-z220-10 virt-who.d]# service virt-who restart
Stopping virt-who:                                         [FAILED]
Starting virt-who:                                         [  OK  ]

[root@hp-z220-10 virt-who.d]# tail -f /var/log/rhsm/rhsm.log

2016-04-06 14:17:59,442 [virtwho.init INFO] MainProcess(9784):MainThread @virtwho.py:parseOptions:637 - Using reporter_id='hp-z220-10.qe.lab.eng.nay.redhat.com'
2016-04-06 14:17:59,445 [virtwho.init DEBUG] MainProcess(9784):MainThread @virtwho.py:__init__:125 - Using config named 'test-hyperv1'
2016-04-06 14:17:59,445 [virtwho.init INFO] MainProcess(9784):MainThread @virtwho.py:main:729 - Using configuration "test-hyperv1" ("hyperv" mode)
2016-04-06 14:17:59,458 [virtwho.main DEBUG] MainProcess(9786):MainThread @virtwho.py:run:231 - Starting infinite loop with 60 seconds interval
2016-04-06 14:17:59,571 [virtwho.main ERROR] MainProcess(9786):MainThread @virtwho.py:run:244 - Unable to use configuration "test-hyperv1": string index out of range
2016-04-06 14:17:59,571 [virtwho.main ERROR] MainProcess(9786):MainThread @virtwho.py:run:255 - No suitable virt backend found
2016-04-06 14:17:59,571 [virtwho.main DEBUG] MainProcess(9786):MainThread @virtwho.py:<module>:824 - virt-who terminated
2016-04-06 14:17:59,572 [virtwho.main DEBUG] MainProcess(9786):MainThread @virtwho.py:terminate:359 - virt-who is shutting down

Comment 5 Radek Novacek 2016-10-11 14:02:43 UTC
Fixed in virt-who-0.18-1.el6.

Comment 8 Eko 2016-12-06 06:09:13 UTC
verified in virt-who-0.18-1.el6

with error encrypted_password, it will show: 
2016-12-06 00:48:21,298 [virtwho.init ERROR] MainProcess(3618):MainThread @main.py:main:145 - virt-who can't be started: Option "encrypted_password" in config named "test-esx" can't be decrypted, possibly corrupted
2016-12-06 00:48:21,298 [virtwho.init DEBUG] MainProcess(3618):MainThread @executor.py:terminate:308 - virt-who is shutting down

Comment 10 errata-xmlrpc 2017-03-21 10:29:12 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2017-0675.html