| Summary: | Review Request: perl-B-Hooks-OP-Check-EntersubForCV - Invoke callbacks on construction of entersub OPs for certain CVs | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Petr Pisar <ppisar> |
| Component: | Package Review | Assignee: | Jitka Plesnikova <jplesnik> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jplesnik, package-review |
| Target Milestone: | --- | Flags: | jplesnik:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-B-Hooks-OP-Check-EntersubForCV-0.09-13.fc25 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-10-19 11:01:30 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 1231104 | ||
|
Description
Petr Pisar
2016-03-18 09:41:11 UTC
This unretires a package removed from Fedora because of incompatibility with Perl 5.22. Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
$ rpm -qp --requires perl-B-Hooks-OP-Check-EntersubForCV-0.09-13.fc25.x86_64.rpm | sort | uniq -c
1 libc.so.6()(64bit)
1 libc.so.6(GLIBC_2.2.5)(64bit)
1 libc.so.6(GLIBC_2.4)(64bit)
1 libperl.so.5.22()(64bit)
1 perl(:MODULE_COMPAT_5.22.1)
1 perl(B::Hooks::OP::Check) >= 0.19
1 perl(B::Utils) >= 0.19
1 perl(DynaLoader)
1 perl(Scalar::Util)
1 perl(parent)
1 perl(strict)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
1 rtld(GNU_HASH)
$ rpm -qp --requires perl-B-Hooks-OP-Check-EntersubForCV-devel-0.09-13.fc25.x86_64.rpm | sort | uniq -c
1 perl(:MODULE_COMPAT_5.22.1)
1 perl-B-Hooks-OP-Check-EntersubForCV = 0.09-13.fc25
1 perl-devel(x86-64)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.
$ rpm -qp --provides perl-B-Hooks-OP-Check-EntersubForCV-0.09-13.fc25.x86_64.rpm | sort | uniq -c
1 perl(B::Hooks::OP::Check::EntersubForCV) = 0.09
1 perl-B-Hooks-OP-Check-EntersubForCV = 0.09-13.fc25
1 perl-B-Hooks-OP-Check-EntersubForCV(x86-64) = 0.09-13.fc25
$ rpm -qp --provides perl-B-Hooks-OP-Check-EntersubForCV-devel-0.09-13.fc25.x86_64.rpm | sort | uniq -c
1 perl(B::Hooks::OP::Check::EntersubForCV::Install::Files)
1 perl-B-Hooks-OP-Check-EntersubForCV-devel = 0.09-13.fc25
1 perl-B-Hooks-OP-Check-EntersubForCV-devel(x86-64) = 0.09-13.fc25
Binary provides are Ok.
$ rpmlint ./perl-B-Hooks-OP-Check-EntersubForCV*
perl-B-Hooks-OP-Check-EntersubForCV.src: W: spelling-error Summary(en_US) entersub -> enter sub, enter-sub, subtenant
perl-B-Hooks-OP-Check-EntersubForCV.src: W: spelling-error %description -l en_US entersub -> enter sub, enter-sub, subtenant
perl-B-Hooks-OP-Check-EntersubForCV.x86_64: W: spelling-error Summary(en_US) entersub -> enter sub, enter-sub, subtenant
perl-B-Hooks-OP-Check-EntersubForCV.x86_64: W: spelling-error %description -l en_US entersub -> enter sub, enter-sub, subtenant
perl-B-Hooks-OP-Check-EntersubForCV-devel.x86_64: W: only-non-binary-in-usr-lib
perl-B-Hooks-OP-Check-EntersubForCV-devel.x86_64: W: no-documentation
3 packages and 1 specfiles checked; 0 errors, 6 warnings.
Rpmlint is ok
BuildRequires
FIX: Please add BRs
* coreutils - spec file line 54
* perl(Module::Install::Makefile) - define makemaker_args used in Makefile.PL (line 27)
Please correct all 'FIX' issues
Otherwise the package looks good.
Approved.
Waiting for unretiring the package <https://fedorahosted.org/rel-eng/ticket/6381>. Thank you for the review and the repository. I fixed the two issues. perl-B-Hooks-OP-Check-EntersubForCV-0.09-13.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-82654c073a perl-B-Hooks-OP-Check-EntersubForCV-0.09-13.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-6983367fe8 perl-B-Hooks-OP-Check-EntersubForCV-0.09-13.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-82654c073a perl-B-Hooks-OP-Check-EntersubForCV-0.09-13.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6983367fe8 perl-B-Hooks-OP-Check-EntersubForCV-0.09-13.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. perl-B-Hooks-OP-Check-EntersubForCV-0.09-13.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. |