Bug 1318999

Created attachment 1137745 [details]
screenshot

We agreed on IRC to keep this open as a tracking bug for the
feature, but not to implement it unless customers ask for it.

*** This bug has been marked as a duplicate of bug 1309706 ***

I can reproduce this issue with build:
libguestfs-1.32.5-5.el7.x86_64
virt-v2v-1.32.5-5.el7.x86_64

Steps:
1. Prepare a guest which has added floppy device  
# virsh dumpxml 6test1
...
    <disk type='file' device='disk'>
      <driver name='qemu' type='raw' cache='writeback' io='threads'/>
      <source file='/var/lib/libvirt/images/6test1.img'/>
      <target dev='vda' bus='virtio'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x07' function='0x0'/>
    </disk>
    <disk type='file' device='floppy'>
      <driver name='qemu' type='qcow2'/>
      <source file='/tmp/floopy.img'/>
      <target dev='fda' bus='fdc'/>
      <address type='drive' controller='0' bus='0' target='0' unit='0'/>
    </disk>
...

2. Convert it to rhev
# virt-v2v -o rhev -os 10.73.72.63:/home/nfs_export 6test1 --print-source
[   0.0] Opening the source -i libvirt 6test1
virt-v2v: warning: <target dev='fda'> was ignored because the device name 
could not be recognized
Source guest information (--print-source option):

    source name: 6test1
hypervisor type: kvm
         memory: 1073741824 (bytes)
       nr vCPUs: 8
   CPU features: apic,acpi
       firmware: unknown
        display: spice
          sound: ich6
disks:
	/var/lib/libvirt/images/6test1.img (raw) [virtio]
removable media:
	Floppy
NICs:
	Network "dfadf" mac: 52:54:00:30:dd:e3


Then try to verify this bug with new build:
libguestfs-1.32.5-10.el7.x86_64
virt-v2v-1.32.5-10.el7.x86_64
libvirt-2.0.0-1.el7.x86_64
qemu-kvm-1.5.3-116.el7.x86_64

Steps:
1. Test conversion with option '--print-source'
# virt-v2v -o rhev -os 10.73.72.63:/home/nfs_export 6test1  -n ovirtmgmt -b ovirtmgmt -on jt2 -of qcow2 --print-source
[   0.0] Opening the source -i libvirt 6test1
Source guest information (--print-source option):

    source name: 6test1
hypervisor type: kvm
         memory: 1073741824 (bytes)
       nr vCPUs: 8
   CPU features: apic,acpi
       firmware: unknown
        display: spice
          sound: ich6
disks:
	/var/lib/libvirt/images/6test1.img (raw) [virtio]
removable media:
	Floppy in slot 0
NICs:
	Network "dfadf" mac: 52:54:00:30:dd:e3


Result:
1.1 No warning: '<target dev='fda'> was ignored because the device name could not be recognized' shows.
1.2 It seems Floppy also be removed.

2. Convert to rhevm.
# virt-v2v -o rhev -os 10.73.72.63:/home/nfs_export 6test1  -n ovirtmgmt -b ovirtmgmt -on jt2 -of qcow2 
[   0.0] Opening the source -i libvirt 6test1
[   0.0] Creating an overlay to protect the source from being modified
[   0.2] Initializing the target -o rhev -os 10.73.72.63:/home/nfs_export
[   0.4] Opening the overlay
[  47.4] Inspecting the overlay
[  58.9] Checking for sufficient free disk space in the guest
[  58.9] Estimating space required on target for each disk
[  58.9] Converting Red Hat Enterprise Linux Server release 6.8 (Santiago) to run on KVM
virt-v2v: This guest has virtio drivers installed.
[  90.8] Mapping filesystem data to avoid copying unused and blank areas
[  90.9] Closing the overlay
[  91.0] Checking if the guest needs BIOS or UEFI to boot
[  91.0] Assigning disks to buses
[  91.0] Copying disk 1/1 to /tmp/v2v.t56A1H/d67d5cf2-4931-4e57-99a1-b50207f10f30/images/40aa1db2-9b78-4b08-8455-4ec4d04383e5/8c92dda8-1ca3-4cc5-bedb-8b054800fb61 (qcow2)
    (100.00/100%)
[ 440.8] Creating output metadata
[ 440.9] Finishing off

Result:
After conversion finished, then import image and check after guest boot up, not find floppy device.

So rjones, is this result i get as expected? from bug summary, it shows floppy is supported, thanks.

The good thing is:

(1) The warning has gone.

(2) "Floppy in slot 0" is shown, which means the floppy was assigned
to a slot in the output.

Now what is missing is that when outputting to RHEV we ignore
all removable devices (CDs, floppies).  This is the same as what
old virt-v2v did so it's not a regression:

https://github.com/libguestfs/libguestfs/blob/master/v2v/OVF.ml#L354

I don't intend to fix that unless a customer finds the bug and
complains about it.

Output to libvirt should now add a floppy device, looking like this:

    <disk device='floppy' type='file'>
      <driver name='qemu' type='raw'/>
      <target dev='fda'/>       <--- note should be fdX, NOT hdX
    </disk>

(In reply to Richard W.M. Jones from comment #6)
> The good thing is:
> 
> (1) The warning has gone.
> 
> (2) "Floppy in slot 0" is shown, which means the floppy was assigned
> to a slot in the output.
> 
> Now what is missing is that when outputting to RHEV we ignore
> all removable devices (CDs, floppies).  This is the same as what
> old virt-v2v did so it's not a regression:
> 
> https://github.com/libguestfs/libguestfs/blob/master/v2v/OVF.ml#L354
> 
> I don't intend to fix that unless a customer finds the bug and
> complains about it.
> 
> Output to libvirt should now add a floppy device, looking like this:
> 
>     <disk device='floppy' type='file'>
>       <driver name='qemu' type='raw'/>
>       <target dev='fda'/>       <--- note should be fdX, NOT hdX
>     </disk>

ok, got it, thanks.

Created attachment 1202130 [details]
libvirt-floppy.log