| Summary: | incorrect use of Requires(pre)? | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Honza Silhan <jsilhan> |
| Component: | kexec-tools | Assignee: | Zhengyu Zhang <zhezhang> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | bhe, ruyang, wcwxyz |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-04-06 01:58:32 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Honza Silhan
2016-03-18 15:51:09 UTC
(In reply to Jan Silhan from comment #0) > We've identified your package for having `Requires(pre)` RPM flag without > `Requires` [1]. `Requires(pre)` rpm tag could be interpreted wrongly, so to > prevent any harm to Fedora users I am notifying you about this fact. > > Any package that is specified in `Requires(pre)` could be freely removed. > Citing from RPM pages: > ``` > If there are no other dependencies on the package providing > /usr/sbin/useradd, that package is permitted to be removed from the system > after installation(!) > ``` [2] > > If you really rely on dependency just during the installation process and > your package don't necessary require the dependency for the proper run of > your application then ignore this bug report and close it as NOTABUG. > Otherwise add to your spec file additional `Requires` for the dependency, > please. > > > [1] paste.fedoraproject.org/341611/82208431 > [2] http://www.rpm.org/wiki/PackagerDocs/MoreOnDependencies Thanks for reporting. I find out that kexec-tools does not require the dependency for the proper run, as well as installation. This 'Requires(pre)' stuff was first introduced in commit 0f48330a85523a2de07d4f0634ac1c764f5d82b8 (In reply to Zhengyu Zhang from comment #1) > (In reply to Jan Silhan from comment #0) > > We've identified your package for having `Requires(pre)` RPM flag without > > `Requires` [1]. `Requires(pre)` rpm tag could be interpreted wrongly, so to > > prevent any harm to Fedora users I am notifying you about this fact. > > > > Any package that is specified in `Requires(pre)` could be freely removed. > > Citing from RPM pages: > > ``` > > If there are no other dependencies on the package providing > > /usr/sbin/useradd, that package is permitted to be removed from the system > > after installation(!) > > ``` [2] > > > > If you really rely on dependency just during the installation process and > > your package don't necessary require the dependency for the proper run of > > your application then ignore this bug report and close it as NOTABUG. > > Otherwise add to your spec file additional `Requires` for the dependency, > > please. > > > > > > [1] paste.fedoraproject.org/341611/82208431 > > [2] http://www.rpm.org/wiki/PackagerDocs/MoreOnDependencies > > Thanks for reporting. I find out that kexec-tools does not require the > dependency for the proper run, as well as installation. > > This 'Requires(pre)' stuff was first introduced in commit > 0f48330a85523a2de07d4f0634ac1c764f5d82b8 No, I made mistakes. The dependency is necessary for running kexec-tools. We should not leave the dependency in Requires(pre). |