Bug 1319520 (grub2-breeze-theme)
| Summary: | Review Request: grub2-breeze-theme - Breeze theme for GRUB2 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Daniel Vrátil <me> |
| Component: | Package Review | Assignee: | Marc Deop <marc> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | marc, package-review, rdieter |
| Target Milestone: | --- | Flags: | marc:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-04-21 13:43:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 656997, 1135103 | ||
|
Description
Daniel Vrátil
2016-03-20 21:18:56 UTC
- License file (COPYING) in sources says that license should be GPLv3 - Is there any special reason why "%global _grubthemedir" is declared in the %build section? Thanks for review! Spec URL: https://dvratil.fedorapeople.org/plasma5/review/grub2-breeze-theme.spec SRPM URL: https://dvratil.fedorapeople.org/plasma5/review/grub2-breeze-theme-5.6.2-1.fc23.src.rpm - updated to 5.6.2 - fixed license - moved the macro definition to %install section The spec file is still the 5.6.0 one, the src.rpm is updated though. Reviewing the spec file from https://dvratil.fedorapeople.org/plasma5/review/grub2-breeze-theme-5.6.2-1.fc23.src.rpm ... everything good for me :-) pkgdb request submitted imported |