Bug 1319820

Summary: Tar does not honor --directory option for --remove-files
Product: Red Hat Enterprise Linux 7 Reporter: Zdenek Pytela <zpytela>
Component: tarAssignee: Tomas Repik <trepik>
Status: CLOSED ERRATA QA Contact: Robin Hack <rhack>
Severity: high Docs Contact: Lenka Kimlickova <lkimlick>
Priority: medium    
Version: 7.2CC: fkrska, kvolny, praiskup, rhack, trepik
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Release Note
Doc Text:
"tar" option "--directory" no longer ignored Previously, the "--directory" option of the "tar" command was ignored when used in combination with the "--remove-files" option. As a consequence, files in the current working directory were removed instead of the files in the directory specified by the "--directory" option. To fix this bug, new functions and an attribute that retrieve, store, and act upon the "--directory" option have been added. As a result, files are now correctly removed from the directory specified by the "--directory" option.
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-01 17:01:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1298243, 1393868, 1400961    

Description Zdenek Pytela 2016-03-21 15:26:11 UTC
Description of problem:
Tar does not honor --directory option for --remove-files, it tries to remove files in the current working directory instead.


Version-Release number of selected component (if applicable):
tar-1.26-29.el7.x86_64


How reproducible:
always


Steps to Reproduce:
1. cd $HOME
2. rm -f tartest.tar
3. mkdir -p indirectdir/test
4. touch indirectdir/test/afile
5. tar --remove-files --append --atime-preserve --directory $HOME/indirectdir --mode 444 --file $HOME/tartest.tar test/afile
6. ls indirectdir/test/afile


Actual results:
ls indirectdir/test/afile
shows the file still exists


Expected results:
ls: indirectdir/test/afile: No such file or directory


Additional info:
tar-1.15.1-32.el5_8 in RHEL 5 and tar-1.23-14.el6.x86_64 in RHEL 6 work as expected

strace in RHEL 6 (similar in RHEL 5) shows:
getcwd("/home/user/indirectdir", 4096) = 26
write(3, "test/afile\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"..., 10240) = 10240
clock_gettime(CLOCK_REALTIME, {1458573540, 334576437}) = 0
clock_gettime(CLOCK_REALTIME, {1458573540, 334595612}) = 0
close(3)                                = 0
unlink("/home/user/indirectdir/test/afile") = 0
close(1)                                = 0
close(2)                                = 0
exit_group(0)                           = ?
+++ exited with 0 +++

strace in RHEL 7:
getcwd("/home/user", 4096)           = 14
write(3, "test/afile\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"..., 10240) = 10240
close(3)                                = 0
unlinkat(4, "/home/user/test/afile", 0) = -1 ENOENT (No such file or directory)
close(1)                                = 0
close(2)                                = 0
exit_group(0)                           = ?
+++ exited with 0 +++

Comment 3 Pavel Raiskup 2016-03-22 15:46:00 UTC
The major fix for this is:
http://git.savannah.gnu.org/cgit/tar.git/commit/?id=e3d28d84

But there needs to be done better inspection as this feature (-C together
with --remove-files was fixed many times in post v1.26 time).

Comment 23 errata-xmlrpc 2017-08-01 17:01:03 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2012