Bug 1320165

Summary: New perFSGroup quota not checking mount options on node startup.
Product: OKD Reporter: Devan Goodwin <dgoodwin>
Component: StorageAssignee: Devan Goodwin <dgoodwin>
Status: CLOSED CURRENTRELEASE QA Contact: Chao Yang <chaoyang>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.xCC: aos-bugs, xtian
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-05-12 17:15:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Devan Goodwin 2016-03-22 13:16:24 UTC
Description of problem:

The new perFSGroup local storage quota (XFS only) is not checking filesystem mount options on node startup.

Version-Release number of selected component (if applicable):


origin master as of 2ddfc71bf4f24d35afbf4085b1e26ae64bffa107

How reproducible:

100%


Steps to Reproduce:

1. Ensure the volumeDirectory in node-config.yaml is on an XFS filesystem, but NOT mounted with grpquota option.

2. Enable the new perFSGroup quota in node-config.yaml:

volumeConfig:
  localQuota:
    perFSGroup: "512Mi"


3. Restart the node service.

4. Create a pod with an emptyDir volume: oc new-app openshift/jenkins-1-centos7

Actual results:

Node will start fine, but the jenkins pod will never create. Node service logs will show a cryptic error about being unable to mount the volume and "system exit: 1".


Expected results:

This is a misconfiguration and as such the node should refuse to start, similar to what happens if you enable this quota but your volumeDirectory is not on XFS at all.

Comment 1 Devan Goodwin 2016-03-22 13:18:48 UTC
Fix pending in: https://github.com/openshift/origin/pull/8178

Comment 2 Devan Goodwin 2016-04-07 13:37:50 UTC
Fix merged yesterday, should be present in next rebuild.

Comment 3 Chao Yang 2016-04-08 06:48:12 UTC
Verification is passed

[root@ip-172-18-0-198 ~]# oc version
oc v1.1.6-38-g6ecbaaf
kubernetes v1.2.0-36-g4a3f9c5

node wont start , and will see below log
Could not set up local quota, /root/openshift.local.volumes is not on a filesystem mounted with the grpquota option