Bug 1320231

Summary:	Set kubernetesMasterConfig.admissionConfig in the installer
Product:	OpenShift Container Platform	Reporter:	Stefanie Forrester <dakini>
Component:	Installer	Assignee:	Devan Goodwin <dgoodwin>
Status:	CLOSED ERRATA	QA Contact:	Ma xiaoqiang <xiama>
Severity:	high	Docs Contact:
Priority:	high
Version:	3.2.0	CC:	agrimm, akokshar, aos-bugs, bleanhar, dgoodwin, gpei, jokerman, mmccomas, tdawson, xtian
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	openshift-ansible-3.0.74-1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-05-12 16:39:11 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:
Bug Blocks:	1303130

Description Stefanie Forrester 2016-03-22 15:29:57 UTC

Description of problem:
For OpenShift Online, we're going to need to set kubernetesMasterConfig.admissionConfig at install time.

Version-Release number of selected component (if applicable):
3.2

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:

There is no way to set kubernetesMasterConfig.admissionConfig in the installer.

Expected results:

Ability to define kubernetesMasterConfig.admissionConfig in the BYO inventory at install time.

Additional info:

The exact settings we'll be using for INT are listed here, for reference.

https://github.com/openshift/online/issues/62#issuecomment-199369802

Comment 1 Devan Goodwin 2016-03-24 13:11:10 UTC

https://github.com/openshift/openshift-ansible/pull/1660

Comment 2 Troy Dawson 2016-03-28 21:03:23 UTC

This pull request has passed both tests, but has not been merged.

Comment 3 Troy Dawson 2016-03-30 18:53:09 UTC

The pull request still hasn't merged, and appears to still be worked on.  I'm putting this back in assigned.

Comment 5 Ma xiaoqiang 2016-04-07 01:32:13 UTC

Check on openshift-ansible -b master

Scenarios 1:
Install env without admissionConfig
Check the master config
admissionConfig:
apiLevels:
<--snip-->
kubernetesMasterConfig:
  admissionConfig:
  apiServerArguments:
<--snip-->
Get the expected result

Install env with master admissionConfig
openshift_master_admission_plugin_order=["RunOnceDuration", "NamespaceLifecycle", "OriginPodNodeEnvironment", "ClusterResourceOverride", "LimitRanger", "ServiceAccount", "SecurityContextConstraint", "ResourceQuota"]
openshift_master_admission_plugin_config={"RunOnceDuration":{"configuration":{"apiVersion":"v1","kind":"RunOnceDurationConfig","activeDeadlineSecondsOverride":3600}},"ClusterResourceOverride":{"configuration":{"apiVersion":"v1","kind":"ClusterResourceOverrideConfig","limitCPUToMemoryPercent":200,"cpuRequestToLimitPercent":6,"memoryRequestToLimitPercent":60}}}
{openshift_master_kube_admission_plugin_order=["providerSelection","RunOnceDuration"]
openshift_master_kube_admission_plugin_config={"RunOnceDuration":{"configuration": "Just a testing"}}

Check the result
<--snip-->
admissionConfig:
  pluginOrderOverride:
    - RunOnceDuration
    - NamespaceLifecycle
    - OriginPodNodeEnvironment
    - ClusterResourceOverride
    - LimitRanger
    - ServiceAccount
    - SecurityContextConstraint
    - ResourceQuota
  pluginConfig:
    ClusterResourceOverride:
      configuration:
        apiVersion: v1
        cpuRequestToLimitPercent: 6
        kind: ClusterResourceOverrideConfig
        limitCPUToMemoryPercent: 200
        memoryRequestToLimitPercent: 60
    RunOnceDuration:
      configuration:
        activeDeadlineSecondsOverride: 3600
        apiVersion: v1
        kind: RunOnceDurationConfig
apiLevels:
<--snip-->
kubernetesMasterConfig:
  admissionConfig:
    pluginOrderOverride:
      - providerSelection
      - RunOnceDuration
    pluginConfig:
      RunOnceDuration:
        configuration: Just a testing
  apiServerArguments:

get the expected results.

Move this issue to VERIFIED.

Comment 7 errata-xmlrpc 2016-05-12 16:39:11 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1065

Comment 8 Devan Goodwin 2016-09-21 18:54:48 UTC

*** Bug 1354321 has been marked as a duplicate of this bug. ***