Bug 1320248

Summary: Rails error "undefined method `validate_unsupported'" on running SSA for templates
Product: Red Hat CloudForms Management Engine Reporter: Vadim Rutkovsky <vrutkovs>
Component: UI - OPSAssignee: lgalis
Status: CLOSED EOL QA Contact: Dave Johnson <dajohnso>
Severity: high Docs Contact:
Priority: high    
Version: 5.4.0CC: cpelland, hkataria, jhardy, mpovolny, obarenbo
Target Milestone: GAFlags: vrutkovs: automate_bug+
Target Release: 5.4.6   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: ui:smartstate
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
production.log none

Description Vadim Rutkovsky 2016-03-22 16:31:58 UTC
Created attachment 1139122 [details]
production.log

Description of problem:
Rails error occurs on running SSA for templates from hosts view

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. Add vsphere6-nested provider
2. Open Infrastructure - Hosts - any host with templates
3. Click 'Relationships - VM templates'
4. Check any template in the list and click Configuration - Perform SmartState Analysis

Actual results:
Rails error, see production log attached

undefined method `validate_unsupported' for #<TemplateVmware:0x0000000d474c00> [host/button] 

Expected results:

Template scan task starts

Additional info:
This doesn't seem to happen on 5.5 or 5.6. Doesn't affect 'Instances' view

Comment 1 Dave Johnson 2016-03-24 03:31:23 UTC
Reproduced on RHEVM as well and is NOT in 5.4.4

Comment 2 Dave Johnson 2016-03-24 03:35:41 UTC
Also, this is only when selecting multiple quadicons to scan and one of them is a template.  Selecting only VM quadicons or from VM/template details, work correctly.h

Comment 5 CFME Bot 2016-04-14 21:25:30 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=7851d6b2b937bd1aca1102a9f0daca396c3b527a

commit 7851d6b2b937bd1aca1102a9f0daca396c3b527a
Author:     Laura Galis <lgalis>
AuthorDate: Thu Mar 24 01:02:18 2016 -0400
Commit:     Laura Galis <lgalis>
CommitDate: Thu Mar 24 01:02:18 2016 -0400

     https://bugzilla.redhat.com/show_bug.cgi?id=1320248
    
    Added smartstate supported overrides for openstack, redhat and vmware templates. Moved validate_unsupported to vm_or_template operations.

 vmdb/app/models/template_openstack.rb        | 4 ++++
 vmdb/app/models/template_redhat.rb           | 4 ++++
 vmdb/app/models/template_vmware.rb           | 4 ++++
 vmdb/app/models/vm/operations.rb             | 8 --------
 vmdb/app/models/vm_or_template/operations.rb | 4 ++++
 5 files changed, 16 insertions(+), 8 deletions(-)

Comment 6 CFME Bot 2016-04-14 21:25:34 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=63ebe69a77cf6c4b7a123b88cc97e2a0f9272f6e

commit 63ebe69a77cf6c4b7a123b88cc97e2a0f9272f6e
Merge: 800759c 7851d6b
Author:     Dan Clarizio <dclarizi>
AuthorDate: Thu Apr 14 16:51:10 2016 -0400
Commit:     Dan Clarizio <dclarizi>
CommitDate: Thu Apr 14 16:51:10 2016 -0400

    Merge branch '5.4.z_smartstate_button_for_templates' into '5.4.z'
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1320248
    
    Added smartstate supported overrides for openstack, redhat and vmware templates. Moved validate_unsupported to vm_or_template operations.
    
    See merge request !871

 vmdb/app/models/template_openstack.rb        | 4 ++++
 vmdb/app/models/template_redhat.rb           | 4 ++++
 vmdb/app/models/template_vmware.rb           | 4 ++++
 vmdb/app/models/vm/operations.rb             | 8 --------
 vmdb/app/models/vm_or_template/operations.rb | 4 ++++
 5 files changed, 16 insertions(+), 8 deletions(-)