Bug 1320274

Summary:	Use Restart=on-abnormal instead of Restart=on-failure
Product:	[Fedora] Fedora	Reporter:	Vivek Goyal <vgoyal>
Component:	docker	Assignee:	Lokesh Mandvekar <lsm5>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	adimania, admiller, amurdaca, dwalsh, ichavero, jcajka, jchaloup, lsm5, marianne, miminar, vbatts
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-06-03 19:43:50 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Vivek Goyal 2016-03-22 17:29:53 UTC

Description of problem:

Right now we are using Restart=on-failure in docker.service file and that leads to multiple restarts of docker if docker fails to start due to say some configuration error. For example, say lvm thin pool specified by docker-storage-setup is not there.

This also has side affect of filling logs of messages like.

 systemd[1]: docker.service failed.
 systemd[1]: start request repeated too quickly for docker.service
 systemd[1]: Failed to start Docker Application Container Engine.

And actual error message might get lost or be deep buried in the stack.

So use Restart=on-abnormal instead. That should make sure docker restarts if docker fails abnormally (like core dump). 

Version-Release number of  selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Daniel Walsh 2016-06-03 19:43:50 UTC

Fixed in current release.