Bug 1320275

Summary:	--cgroup-parent doesn't work correctly in docker 1.9
Product:	[Fedora] Fedora	Reporter:	Mrunal Patel <mpatel>
Component:	docker	Assignee:	Lokesh Mandvekar <lsm5>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	23	CC:	adimania, admiller, amurdaca, bkabrda, dwalsh, ichavero, jcajka, jchaloup, lsm5, marianne, miminar, ncoghlan, ttomecek, vbatts
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:	docker-1.9.1-9.gitee06d03.fc23	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1320302 (view as bug list)		Environment:
Last Closed:	2016-04-05 13:52:52 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Mrunal Patel 2016-03-22 17:35:30 UTC

Description of problem:
--cgroup-parent doesn't work as expected. It just changes the name of the scope.
For e.g. /system.slice/specifiedparent.slice-<docker_uuid>.scope

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
Use the --cgroup-parent option with the systemd cgroup driver

Actual results:
/specifiedparent.slice/docker-<uuid>.scope

Expected results:


Additional info:

Comment 1 Lokesh Mandvekar 2016-03-22 17:38:25 UTC

I'll be downgrading docker from 1.10.x to 1.9.1 in fedora 23 updates-testing.

Comment 2 Fedora Update System 2016-03-24 04:36:16 UTC

docker-1.9.1-7.gitc6607d2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-43af1a6b97

Comment 3 Fedora Update System 2016-03-26 15:20:25 UTC

docker-1.9.1-7.gitc6607d2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-43af1a6b97

Comment 4 Bohuslav "Slavek" Kabrda 2016-03-29 08:28:16 UTC

@Lokesh, could you please explain how downgrading to 1.9.1 will solve this? From [1] it seems to me that the problem is the same on 1.9.1 and this bug report doesn't specify what version of docker Mrunal used, so I'm wondering why you think downgrading is going to help.

Is there any other reason for downgrading? (I have to say I became a heavy user of 1.10 features from updates-testing, so I'd be very unhappy to see this happen.)

[1] https://github.com/docker/docker/issues/12849#issuecomment-169507002

Comment 5 Fedora Update System 2016-03-29 18:57:45 UTC

docker-1.9.1-9.gitee06d03.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-6bd77849dd

Comment 6 Fedora Update System 2016-03-30 22:55:34 UTC

docker-1.9.1-9.gitee06d03.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6bd77849dd

Comment 7 Fedora Update System 2016-04-05 13:52:47 UTC

docker-1.9.1-9.gitee06d03.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 8 Lokesh Mandvekar 2016-04-05 14:01:45 UTC

(In reply to Bohuslav "Slavek" Kabrda from comment #4)
> @Lokesh, could you please explain how downgrading to 1.9.1 will solve this?
> From [1] it seems to me that the problem is the same on 1.9.1 and this bug
> report doesn't specify what version of docker Mrunal used, so I'm wondering
> why you think downgrading is going to help.
> 
> Is there any other reason for downgrading? (I have to say I became a heavy
> user of 1.10 features from updates-testing, so I'd be very unhappy to see
> this happen.)
> 
> [1] https://github.com/docker/docker/issues/12849#issuecomment-169507002

f23 updates had 1.9.1 and updates-testing had 1.10.x, and IIUC OpenShift devenvs wanted a 1.9.1 update with this patch and didn't want 1.10.x so I had to downgrade.

I'll leave it for Dan, Derek and Mrunal to comment on if we could re-upgrade to 1.10.x in -testing.

Comment 9 Fedora Update System 2016-04-05 16:20:11 UTC

docker-1.9.1-9.gitee06d03.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Nick Coghlan 2016-04-06 04:02:51 UTC

Please do put 1.10 back into F23's updates-testing - without an "Extras" style repo, plenty of folks were relying on the "known incompatible" 1.10 being available through updates-testing.

That said, a more maintainable solution might be for those of us that were relying on the updates-testing hack to switch over to Adam Miller's docker110 COPR: https://copr.fedorainfracloud.org/coprs/maxamillion/docker110/

Comment 11 Nick Coghlan 2016-04-07 02:53:23 UTC

I tried enabling the COPR repo, but dnf still refused to upgrade docker: https://bugzilla.redhat.com/show_bug.cgi?id=1324694