Bug 1320278

Summary: Safelease package is requiring unrelated package
Product: [Fedora] Fedora Reporter: Nir Soffer <nsoffer>
Component: safeleaseAssignee: Yaniv Bronhaim <bronhaim>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 25CC: bronhaim, danken, dougsland, ybronhei
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-01-09 13:43:48 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Nir Soffer 2016-03-22 17:40:13 UTC
Description of problem:

The safelease package depends on package it does not need.

From safelease.spec.in:

##
# The following requirements are necessary for VDSM to avoid
# platform dependencies. Those are not required by safelease code and should
# remove once vdsm will be able to provide those requirements otherwise.

# Numactl is not available on s390[x] and ARM
%ifnarch s390 s390x %{arm}
Requires: numactl
%endif

%ifarch x86_64
Requires: python-dmidecode
Requires: dmidecode
Requires: virt-v2v
%endif

## hack end.
 
This was added in this commit:

commit c6ff479e157331000ad42fa58664ffd9af322a0e
Author: Yaniv Bronhaim <ybronhei>
Date:   Sun May 17 15:05:47 2015 +0300

    adds vdsm platform requirements to spec
    
    raising release and adding changelog note about that hack. this hack
    should remove later when vdsm will require those packages otherwise.
    
    Change-Id: Ia3063d393b69f6e21b2a7948b275ed6cf59605ec
    Signed-off-by: Yaniv Bronhaim <ybronhei>
    Reviewed-on: https://gerrit.ovirt.org/41015
    Reviewed-by: Dan Kenigsberg <danken>

These false dependencies should be removed. Vdsm dependencies should be handled
within Vdsm.

Comment 1 Nir Soffer 2016-03-22 17:46:31 UTC
See bug 1320281 for the Vdsm side.

Comment 2 Jan Kurik 2016-07-26 04:07:39 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 25 development cycle.
Changing version to '25'.

Comment 3 Nir Soffer 2016-09-11 15:33:16 UTC
I think we can close this as WONTFIX, since changing the requirement in safelease
would break old vdsm versions depending on it.