Bug 1320311

Summary: No list provided for download policy error message
Product: Red Hat Satellite Reporter: jcallaha
Component: APIAssignee: Zach Huntington-Meath <zhunting>
Status: CLOSED ERRATA QA Contact: David Davis <daviddavis>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.2.0CC: bbuckingham, daviddavis
Target Milestone: UnspecifiedKeywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
URL: http://projects.theforeman.org/issues/14386
Whiteboard:
Fixed In Version: rubygem-katello-3.0.0.26-1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-07-27 11:28:09 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description jcallaha 2016-03-22 20:07:42 UTC
Description of problem:
When providing an invalid download_policy value, the error message returned is:
"displayMessage": "Validation failed: Download policy is not included in the list"

Version-Release number of selected component (if applicable):
Satellite 6.2 Beta Snap 4

How reproducible:
Always

Steps to Reproduce:
1. Create or enable a repository
2. submit a put request to /katello/api/repositories/<repo id>
   with an invalid value for download_policy

Actual results:
{
  "displayMessage": "Validation failed: Download policy is not included in the list",
  "errors": {
    "download_policy": [
      "is not included in the list"
    ]
  }
}

Expected results:
{
  "displayMessage": "Validation failed: Download policy is not included in the list: ['immediate', 'download_policy', 'background']",
  "errors": {
    "download_policy": [
      "is not included in the list: ['immediate', 'download_policy', 'background']"
    ]
  }
}

Comment 2 Zach Huntington-Meath 2016-03-29 20:19:17 UTC
Created redmine issue http://projects.theforeman.org/issues/14386 from this bug

Comment 3 Bryan Kearney 2016-04-04 20:10:05 UTC
Moving to POST since upstream bug http://projects.theforeman.org/issues/14386 has been closed
-------------
Zach Huntington-Meath
Applied in changeset commit:katello|f3730a3c57919c8d1cde49fb8d53b813b5b4a3f9.

Comment 4 David Davis 2016-06-30 19:14:44 UTC
Verified.
Version: satellite-6.2.0-18.0.el7sat.noarch

$ h repository create --product-id 1 --name blah --content-type yum --download-policy fjkdls
Could not create the repository:
  Error: option '--download-policy': value must be one of 'immediate', 'on_demand', 'background'

Comment 5 Bryan Kearney 2016-07-27 11:28:09 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1501