Bug 1320380

Summary: Invalid handling of error situation in decode-dimms
Product: [Fedora] Fedora Reporter: Ulrich Drepper <drepper>
Component: i2c-toolsAssignee: Adam Jackson <ajax>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 23CC: ajax, jaromir.capik, miminar
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-12-20 19:36:19 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Patch to the perl script, adding the missing return value none

Description Ulrich Drepper 2016-03-23 05:05:14 UTC
Created attachment 1139322 [details]
Patch to the perl script, adding the missing return value

Description of problem:
When the decode-dimms script cannot find any files in the /sys directory hierarchy the function (get_dimm_list) returns without specifying a return values.  As a result the caller does something stupic and the script terminates with a mysterious message.

Version-Release number of selected component (if applicable):
i2c-tools-3.1.0-15.fc23.x86_64

How reproducible:
always on my machine (you need a machine which has no eeprom support for the DIMMs)

Steps to Reproduce:
1.have such a machine
2.run decode-dimms
3.

Actual results:
Can't use string ("") as a HASH ref while "strict refs" in use at /usr/bin/decode-dimms line 1783.


Expected results:
Number of SDRAM DIMMs detected and decoded: 0


Additional info:
Please just apply the following patch.

Comment 1 Fedora End Of Life 2016-11-24 16:11:59 UTC
This message is a reminder that Fedora 23 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 23. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '23'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 23 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 2 Fedora End Of Life 2016-12-20 19:36:19 UTC
Fedora 23 changed to end-of-life (EOL) status on 2016-12-20. Fedora 23 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.