Bug 1320810

Summary: [Dedicated] Should have space between --group and users
Product: OpenShift Online Reporter: Wei Sun <wsun>
Component: WebsiteAssignee: Stefanie Forrester <dakini>
Status: CLOSED CURRENTRELEASE QA Contact: Wei Sun <wsun>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.xCC: abhgupta, aos-bugs, jokerman, mmccomas, wjiang
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-04-25 16:03:02 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Wei Sun 2016-03-24 03:34:29 UTC
Description of problem:
When running the script to add some users and groups to dedicated admins,should have space between --group and users.
Now,wsun is not added,but wsun=  is added.

Version-Release number of selected component (if applicable):
QE V3 Cluster

How reproducible:
Always

Steps to Reproduce:
1.oc describe clusterrolebinding dedicated-cluster-admin
2.
3.

Actual results:
Users:						wsun=

Expected results:
Should be wsun

Additional info:

Comment 1 Ravi Sankar 2016-03-28 19:58:02 UTC
Looks like incorrect configuration in /etc/sysconfig/openshift-dedicated-role

All the parameters are passed via one variable $OPTIONS in /etc/sysconfig/openshift-dedicated-role and you need to ensure there is a space between each of the parameters.

This is wrong:
OPTIONS="\
--project-role-file=/etc/openshift-dedicated/project-admin-role.json \
...
--users=wsun\
--groups= \
"

It should be:
OPTIONS="\
--project-role-file=/etc/openshift-dedicated/project-admin-role.json \
...
--users=wsun \[should end with space here]
--groups= \
"

Comment 2 Wei Sun 2016-03-29 08:07:13 UTC
Checked the QE V3 Cluster,the wsun is still not dedicated admins,but wsun= is still   dedicated admins .

Comment 3 Abhishek Gupta 2016-03-30 02:29:05 UTC
I believe this bug was moved to ON_QA before the config change was applied to the INT cluster. I will work with Stefanie tomorrow to get this configuration resolved.

Comment 4 Stefanie Forrester 2016-03-30 14:52:55 UTC
Fixed:

OPTIONS="\
--project-role-file=/etc/openshift-dedicated/project-admin-role.json \
--cluster-role-file=/etc/openshift-dedicated/cluster-admin-role.json \
--skip-projects=default,openshift-infra \
--users=wjiang,wsun \
--groups= \
--verbose \
"

Comment 5 Wei Sun 2016-03-31 05:43:54 UTC
Now wjiang, wsun=, wsun are dedicated admin.I think it's better to use -r/--recreate ,then wsun= will be removed from the dedicated admin ,since wsun= is not actual user.

Comment 6 Stefanie Forrester 2016-03-31 13:27:42 UTC
Added --recreate and restarted service.

OPTIONS="\
--project-role-file=/etc/openshift-dedicated/project-admin-role.json \
--cluster-role-file=/etc/openshift-dedicated/cluster-admin-role.json \
--skip-projects=default,openshift-infra \
--users=wjiang,wsun \
--recreate \
--groups= \
--verbose \
"

Comment 7 Wei Sun 2016-04-01 06:41:50 UTC
Sorry,seems like --recreate option could not delete rolebinding,just could delete role.
But anyway wsun is added to dedicated admins.So I verify this bug now.Thanks!