Bug 1320818
Summary: | Over some time Files which were accessible become inaccessible(music files) | |||
---|---|---|---|---|
Product: | [Community] GlusterFS | Reporter: | Raghavendra Bhat <rabhat> | |
Component: | quota | Assignee: | Manikandan <mselvaga> | |
Status: | CLOSED CURRENTRELEASE | QA Contact: | ||
Severity: | unspecified | Docs Contact: | ||
Priority: | unspecified | |||
Version: | mainline | CC: | bugs, byarlaga, nbalacha, nchilaka, pkarampu, rhs-bugs, sasundar, skoduri, smohan | |
Target Milestone: | --- | Keywords: | Triaged, ZStream | |
Target Release: | --- | |||
Hardware: | Unspecified | |||
OS: | Unspecified | |||
Whiteboard: | tier-fuse-nfs-samba | |||
Fixed In Version: | glusterfs-3.8rc2 | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | ||
Clone Of: | 1302355 | |||
: | 1320887 1320892 (view as bug list) | Environment: | ||
Last Closed: | 2016-06-16 14:01:30 UTC | Type: | Bug | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | 1302355 | |||
Bug Blocks: | 1320887, 1320892 |
Description
Raghavendra Bhat
2016-03-24 04:01:12 UTC
REVIEW: http://review.gluster.org/13730 (storage/posix: send proper iatt attributes for the root inode) posted (#5) for review on master by Raghavendra Bhat (raghavendra) REVIEW: http://review.gluster.org/13730 (storage/posix: send proper iatt attributes for the root inode) posted (#6) for review on master by Vijaikumar Mallikarjuna (vmallika) upstream patch: http://review.gluster.org/#/c/13730/ REVIEW: http://review.gluster.org/13730 (storage/posix: send proper iatt attributes for the root inode) posted (#7) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/13730 (storage/posix: send proper iatt attributes for the root inode) posted (#8) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/13730 (storage/posix: send proper iatt attributes for the root inode) posted (#9) for review on master by Vijay Bellur (vbellur) REVIEW: http://review.gluster.org/13730 (storage/posix: send proper iatt attributes for the root inode) posted (#12) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/13730 (storage/posix: send proper iatt attributes for the root inode) posted (#13) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/13730 (storage/posix: send proper iatt attributes for the root inode) posted (#14) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/13730 (storage/posix: send proper iatt attributes for the root inode) posted (#15) for review on master by Vijaikumar Mallikarjuna (vmallika) COMMIT: http://review.gluster.org/13730 committed in master by Raghavendra G (rgowdapp) ------ commit 06d50c1c00fe35c6bc2192a392b8a749984f3efc Author: Raghavendra Bhat <raghavendra> Date: Mon Mar 14 15:10:17 2016 -0400 storage/posix: send proper iatt attributes for the root inode * changes in posix to send proper iatt attributes for the root directory when ancestry is built. Before posix was filling only the gfid and the inode type in the iatt structure keeping rest of the fields zeros. This was cached by posix-acl and used to send EACCES when some fops came on that object if the uid of the caller is same as the uid of the object on the disk. * getting and setting inode_ctx in function 'posix_acl_ctx_get' is not atomic and can lead to memory leak when there are multiple looups for an inode at same time. This patch fix this problem * Linking an inode in posix_build_ancestry, can cause a race in posix_acl. When parent inode is linked in posix_build_ancestry, and before it reaches posix_acl_readdirp_cbkc, reate/lookup can come on a leaf-inode, as parent-inode-ctx not yet updated in posix_acl_readdirp_cbk, create/lookup can fail with EACCESS. So do the inode linking in the quota xlator Change-Id: I3101eefb65551cc4162c4ff2963be1b73deacd6d BUG: 1320818 Signed-off-by: Raghavendra Bhat <raghavendra> Reviewed-on: http://review.gluster.org/13730 Tested-by: Vijaikumar Mallikarjuna <vmallika> Smoke: Gluster Build System <jenkins.com> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.com> Reviewed-by: Raghavendra G <rgowdapp> REVIEW: http://review.gluster.org/13837 (posix_acl: create inode ctx for root inode) posted (#1) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/13837 (server: send lookup on root inode when itable is created) posted (#2) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/13837 (server: send lookup on root inode when itable is created) posted (#3) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/13837 (server: send lookup on root inode when itable is created) posted (#4) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/13837 (server: send lookup on root inode when itable is created) posted (#5) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/13837 (server: send lookup on root inode when itable is created) posted (#6) for review on master by Vijaikumar Mallikarjuna (vmallika) COMMIT: http://review.gluster.org/13837 committed in master by Jeff Darcy (jdarcy) ------ commit 773e660de0c45221b53cf2a489f28209145475db Author: vmallika <vmallika> Date: Tue Mar 29 18:34:11 2016 +0530 server: send lookup on root inode when itable is created * xlators like quota, marker, posix_acl can cause problems if inode-ctx are not created. sometime these xlarors may not get lookup on root inode with below cases 1) client may not send lookup on root inode (like NSR leader) 2) if the xlators on one of the bricks are not up, and client sending lookup during this time: brick can miss the lookup It is always better to make sure that there is one lookup on root. So send a first lookup when the inode table is created * When sending lookup on root, new inode is created, we need to use itable->root instead Change-Id: Iff2eeaa1a89795328833a7761789ef588f11218f BUG: 1320818 Signed-off-by: vmallika <vmallika> Reviewed-on: http://review.gluster.org/13837 Smoke: Gluster Build System <jenkins.com> CentOS-regression: Gluster Build System <jenkins.com> NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: Jeff Darcy <jdarcy> REVIEW: http://review.gluster.org/13857 (marker: build_ancestry in marker) posted (#7) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/13892 (marker: optimize mq_update_dirty_inode_task) posted (#1) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/13894 (posix_acl: log for inode ctx NULL) posted (#1) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/13894 (posix_acl: log for inode ctx NULL) posted (#2) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/13894 (posix_acl: log for inode ctx NULL) posted (#3) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/13892 (marker: optimize mq_update_dirty_inode_task) posted (#2) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/13857 (marker: build_ancestry in marker) posted (#8) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/13894 (posix_acl: log for inode ctx NULL) posted (#4) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/13894 (posix_acl: skip acl_permits for special clients) posted (#5) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/13894 (posix_acl: skip acl_permits for special clients) posted (#6) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/13857 (marker: build_ancestry in marker) posted (#9) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/13902 (quota: script to test EACCES and quota usage with untar) posted (#1) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/13902 (quota: script to test EACCES and quota usage with untar) posted (#2) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/13894 (posix_acl: skip acl_permits for special clients) posted (#7) for review on master by Vijaikumar Mallikarjuna (vmallika) COMMIT: http://review.gluster.org/13857 committed in master by Raghavendra G (rgowdapp) ------ commit 81955d8aaee8a2c7bf6370970926bc7b403a6efa Author: vmallika <vmallika> Date: Wed Mar 30 20:16:32 2016 +0530 marker: build_ancestry in marker * quota-enforcer doesn't execute build_ancestry in the below code path 1) Special client (PID < 0) 2) unlink 3) rename within the same directory 4) link within the same directory In these cases, marker accounting can fail as parent not found. We need to build_ancestry in marker if it doesn't find parent during update txn Change-Id: Idb7a2906500647baa6d183ba859b15e34769029c BUG: 1320818 Signed-off-by: vmallika <vmallika> Reviewed-on: http://review.gluster.org/13857 CentOS-regression: Gluster Build System <jenkins.com> Reviewed-by: Raghavendra G <rgowdapp> Tested-by: Raghavendra G <rgowdapp> NetBSD-regression: NetBSD Build System <jenkins.org> Smoke: Gluster Build System <jenkins.com> REVIEW: http://review.gluster.org/13902 (quota: script to test EACCES and quota usage with untar) posted (#3) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/13894 (posix_acl: skip acl_permits for special clients) posted (#8) for review on master by Vijaikumar Mallikarjuna (vmallika) COMMIT: http://review.gluster.org/13894 committed in master by Vijaikumar Mallikarjuna (vmallika) ------ commit 1546572b7d46c1aee906608140c843160a529937 Author: vmallika <vmallika> Date: Sat Apr 2 12:02:22 2016 +0530 posix_acl: skip acl_permits for special clients Change-Id: I3f478b7e4ecab517200f50eb09f65a634c029437 BUG: 1320818 Signed-off-by: vmallika <vmallika> Reviewed-on: http://review.gluster.org/13894 Smoke: Gluster Build System <jenkins.com> NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: jiffin tony Thottan <jthottan> CentOS-regression: Gluster Build System <jenkins.com> COMMIT: http://review.gluster.org/13892 committed in master by Vijaikumar Mallikarjuna (vmallika) ------ commit 34d1c81dc4c730eb0cd2b8fd756b8bffed655e9c Author: vmallika <vmallika> Date: Sat Apr 2 08:57:00 2016 +0530 marker: optimize mq_update_dirty_inode_task In function mq_update_dirty_inode_task we do readdirp on a dirty directory and for entry we again do lookup to fecth the contribution xattr. We can fetch this contribution as part of readdirp Change-Id: I766593c0dba793f1ab3b43625acce1c7d9af8d7f BUG: 1320818 Signed-off-by: vmallika <vmallika> Reviewed-on: http://review.gluster.org/13892 NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.com> Smoke: Gluster Build System <jenkins.com> Reviewed-by: Manikandan Selvaganesh <mselvaga> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report. glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/ [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |