| Summary: | Review request: gnome-shell-extension-taskbar - GNOME Shell Extension TaskBar | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | zpydr |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | carl, package-review, vwfoxguru, zbyszek, zpydr |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-02-25 17:00:01 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 177841 | ||
|
Description
zpydr
2016-03-24 13:24:44 UTC
A good start. Here's my initial comments:
The mkdir -p %{buildroot}%{_datadir}/gnome-shell/extensions/TaskBar@zpydr/ line is unnecessary since other mkdir -p will generate it
It is not usual nomenclature to have an '@' in a filesystem path, especially when the @ appears to be your username. It's uncommon to have '@' in a fs path, but it looks like other Gnome extensions use this. I did notice, however, that the extensions generally point back to an upstream URL rather than a username, such as a GitHub account, but I do see an exception in gnome-shell-extension-pidgin, where the username is used instead. I don't see anything in the packaging guidelines against this, but bringing it up to show what other existing gnome extension packages are doing.
For the language support, since you just have a few, you should use %find_lang (See https://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files )
Otherwise, rpmlint shows no errors.
Do you still plan to get this package into Fedora? Yes I do want to get TaskBar into Fedora, but unfortunately I am very busy for the time being. Spec URL: https://raw.githubusercontent.com/zpydr/gnome-shell-extension-taskbar-rpm/master/gnome-shell-extension-taskbar.spec SRPM URL: https://github.com/zpydr/gnome-shell-extension-taskbar-rpm/blob/master/gnome-shell-extension-taskbar-53.0-1.fc24.src.rpm?raw=true Description: TaskBar displays icons of running applications on the top panel. https://extensions.gnome.org/extension/584/taskbar/ Fedora Account System Username: zpydr I have updated the files according to Scott's comment. rpmlint shows no errors. Package looks all right, no issues here. But to become a maintainer, so more work would be needed (reviews of other packages). Let me know if you want to do it. Yes absolutely, I've read the relevant documentation. This looks to be dead upstream. https://github.com/zpydr/gnome-shell-extension-taskbar/commit/eb79254d884dab82e2661969fa0e31374f3bff43 We shouldn't add dead software to Fedora. I'm going to close this for now, but if you find a maintained fork and would like to pick this back up please re-open it. |