| Summary: | ssm list report error when vg is exported | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Praveen Singareddy <psingare> |
| Component: | system-storage-manager | Assignee: | Jan Tulak <jtulak> |
| Status: | CLOSED ERRATA | QA Contact: | Boyang Xue <bxue> |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 7.2 | CC: | agk, dwysocha, esandeen, jpittman, jtulak, jwaterwo, lczerner, mthacker, prajnoha, xzhou, zkabelac |
| Target Milestone: | rc | ||
| Target Release: | 7.6 | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | system-storage-manager-0.4-8.el7 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-10-30 11:39:05 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 1298243, 1420851, 1477664, 1546181 | ||
|
Description
Praveen Singareddy
2016-03-25 05:21:19 UTC
this occurs because ssm expects a zero return from lvs. If the system contains an exported vg, lvs will have a return of 5 regardless of successful run.
ssm has the ability to ignore failures and continue, but it appears to be an all or nothing setting.
I spoke with the LVM developers who stated that lvs will have a non-zero return under the following conditions:
* inconsistent Volume Group
* Problems with System ID
* Clustered VG
* Exported VG
perhaps it would be nice to add the can_fail=True option to _parse_data() so that it can be passed on to the misc.run() call, allowing it to be specifically targeted for lvs.. although im not sure how important it is that lvs return successfully for the rest of the code path.
Or perhaps the real answer here is to address why `lvs` returns a non-zero value for things like 'there is a clustered vg on the system!'. it should be informational; allowing a zero return. opened a bz with the lvm team: https://bugzilla.redhat.com/show_bug.cgi?id=1321617 perhaps we can close this out as duplicate after review from lczerner This lvs behavior is weird. I'll try to get some more information from lvm team, or try to convincem to change that (which I do not believe it will happen). Thanks for the report and the suggestion on how to fix it! -Lukas It looks like based on the responses in https://bugzilla.redhat.com/show_bug.cgi?id=1321617 there may be a couple options: 1. Make this bug depend on the "per-object error code" patchset from Petr R (see https://bugzilla.redhat.com/show_bug.cgi?id=1321617#c3) and modify ssm to use the per object error codes. Unclear if this is suitable for RHEL7.4 2. Find some way to filter or ignore specific errors that may occur when asking for the full list of LVs (Implied when 'lvs' is given with no specific lv name) At least may want to explain what an error with this command means - i.e. an error occurred listing one or more of the LVs on the system, the following list may be incomplete, etc. Removing from the 7.4 Filesystems and storage RPL. Doesn't mean the work can't be done, just not tracking it at the RPL level. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2018:3277 |