| Summary: | Review Request: SuperLU43 - Subroutines to solve sparse linear systems | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mukundan Ragavan <nonamedotc> | ||||
| Component: | Package Review | Assignee: | gil cattaneo <puntogil> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | package-review, puntogil | ||||
| Target Milestone: | --- | Flags: | puntogil:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2016-04-11 09:13:28 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Attachments: |
|
||||||
|
Description
Mukundan Ragavan
2016-03-27 03:52:14 UTC
$ rpmlint compat-SuperLU-43.spec ../SRPMS/compat-SuperLU-43-4.3-1.fc23.src.rpm compat-SuperLU-43.src: W: spelling-error %description -l en_US preordered -> reordered, p reordered, prerecorded compat-SuperLU-43.src: W: spelling-error %description -l en_US preordering -> reordering, p reordering, preordaining 1 packages and 1 specfiles checked; 0 errors, 2 warnings. For conflicts, I have followed this page - https://fedoraproject.org/wiki/Packaging:Conflicts#Compat_Package_Conflicts The name looks weird to me. Why is it needed to use compat in the package name? (In reply to Raphael Groner from comment #3) > The name looks weird to me. Why is it needed to use compat in the package > name? Simply use %{pkgname}43 as the package name (without any dash). The digits inside the name should be enough to show it's a compat package. https://fedoraproject.org/wiki/Packaging:NamingGuidelines#CommonCharacterSet Maybe you'd look also into package renaming guideline. https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages -- Please move 'make -C TESTING' into (new) %check. We do not want to build tests with rpmbuild --nocheck . Why is there no license text file with %license ? Please poke upstream to clear what BSD version we have here. https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text Last, a general advice to generally use macros where possible. - URL: http://crd-legacy.lbl.gov/~xiaoye/SuperLU/ - Source0: http://crd-legacy.lbl.gov/~xiaoye/SuperLU/%{archname}_%{version}.tar.gz URL: http://crd-legacy.lbl.gov/~xiaoye/%{pkgname} Source0: %{url}/%{archname}_%{version}.tar.gz (In reply to Raphael Groner from comment #4) > (In reply to Raphael Groner from comment #3) > > The name looks weird to me. Why is it needed to use compat in the package > > name? > > Simply use %{pkgname}43 as the package name (without any dash). The digits > inside the name should be enough to show it's a compat package. > https://fedoraproject.org/wiki/Packaging:NamingGuidelines#CommonCharacterSet > > Maybe you'd look also into package renaming guideline. > https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming. > 2FReplacing_Existing_Packages > Well, as far as I can tell, the package name, while weird, does comply with the guidelines. Having said that, you are right. superlu43 is certainly sufficient. I will change it. > -- > Please move 'make -C TESTING' into (new) %check. We do not want to build > tests with rpmbuild --nocheck . > Fair enough. done. Just to be sure, there IS a %check section. > Why is there no license text file with %license ? Please poke upstream to > clear what BSD version we have here. > https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses > https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/ > LicensingGuidelines#License_Text > License text is there! %doc README contains the license text AND other stuff. Perhaps I can add a license text .. perhaps I can move this file to %license .. > Last, a general advice to generally use macros where possible. > - URL: http://crd-legacy.lbl.gov/~xiaoye/SuperLU/ > - Source0: > http://crd-legacy.lbl.gov/~xiaoye/SuperLU/%{archname}_%{version}.tar.gz > URL: http://crd-legacy.lbl.gov/~xiaoye/%{pkgname} > Source0: %{url}/%{archname}_%{version}.tar.gz I missed that. I was changing macros a few times when I made this spec file that I missed this one. Will fix it. Spec and SRPM updated. SPEC URL: https://nonamedotc.fedorapeople.org/pkgreview/compat-superlu-43/SuperLU43.spec SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/compat-superlu-43/SuperLU43-4.3-2.fc23.src.rpm Changelog from the updated spec file * Sun Mar 27 2016 Mukundan Ragavan <nonamedotc> - 4.3-2 114 - Renamed the package to SuperLU43 115 - Renamed devel shared lib to libsuperlu43 116 - Removed conflicts since the latest version and this can co-exist Here is the koji scratch build - https://koji.fedoraproject.org/koji/taskinfo?taskID=13475506 Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 6748160 bytes in 368 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [?]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "GPL (with incorrect FSF address)", "Unknown or generated". 445 files have unknown license. Detailed output of licensecheck in /home/gil/1321440-SuperLU43/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in SuperLU43-debuginfo [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 6768640 bytes in /usr/share [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 1.2.15 starting (python version = 3.4.3)... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata Mock Version: 1.2.15 INFO: Mock Version: 1.2.15 Finish: chroot init INFO: installing package(s): /home/gil/1321440-SuperLU43/results/SuperLU43-4.3-2.fc25.i686.rpm /home/gil/1321440-SuperLU43/results/SuperLU43-devel-4.3-2.fc25.i686.rpm /home/gil/1321440-SuperLU43/results/SuperLU43-debuginfo-4.3-2.fc25.i686.rpm /home/gil/1321440-SuperLU43/results/SuperLU43-debuginfo-4.3-2.fc25.i686.rpm ERROR: Command failed. See logs for output. # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-i386/root/ --releasever 25 --disableplugin=local --setopt=deltarpm=false install /home/gil/1321440-SuperLU43/results/SuperLU43-4.3-2.fc25.i686.rpm /home/gil/1321440-SuperLU43/results/SuperLU43-devel-4.3-2.fc25.i686.rpm /home/gil/1321440-SuperLU43/results/SuperLU43-debuginfo-4.3-2.fc25.i686.rpm /home/gil/1321440-SuperLU43/results/SuperLU43-debuginfo-4.3-2.fc25.i686.rpm --setopt=tsflags=nocontexts WARNING: unable to delete selinux filesystems (/tmp/mock-selinux-plugin.j_tj20ck): [Errno 1] Operation not permitted: '/tmp/mock-selinux-plugin.j_tj20ck' Rpmlint ------- Checking: SuperLU43-4.3-2.fc25.i686.rpm SuperLU43-devel-4.3-2.fc25.i686.rpm SuperLU43-debuginfo-4.3-2.fc25.i686.rpm SuperLU43-4.3-2.fc25.src.rpm SuperLU43.i686: W: spelling-error %description -l en_US preordered -> reordered, p reordered, prerecorded SuperLU43.i686: W: spelling-error %description -l en_US preordering -> reordering, p reordering, preordaining SuperLU43.i686: W: spelling-error %description -l en_US compat -> compact, combat, cowpat SuperLU43.i686: W: shared-lib-calls-exit /usr/lib/libsuperlu.so.4.3 exit SuperLU43-devel.i686: W: spelling-error %description -l en_US compat -> compact, combat, cowpat SuperLU43-devel.i686: E: incorrect-fsf-address /usr/share/doc/SuperLU43-devel/EXAMPLE/dfgmr.c SuperLU43-devel.i686: E: incorrect-fsf-address /usr/share/doc/SuperLU43-devel/EXAMPLE/sfgmr.c SuperLU43-devel.i686: E: incorrect-fsf-address /usr/share/doc/SuperLU43-devel/EXAMPLE/zfgmr.c SuperLU43-devel.i686: E: incorrect-fsf-address /usr/share/doc/SuperLU43-devel/EXAMPLE/cfgmr.c SuperLU43.src: W: spelling-error %description -l en_US preordered -> reordered, p reordered, prerecorded SuperLU43.src: W: spelling-error %description -l en_US preordering -> reordering, p reordering, preordaining SuperLU43.src: W: spelling-error %description -l en_US compat -> compact, combat, cowpat 4 packages and 0 specfiles checked; 4 errors, 8 warnings. Requires -------- SuperLU43-debuginfo (rpmlib, GLIBC filtered): SuperLU43-devel (rpmlib, GLIBC filtered): SuperLU43(x86-32) libsuperlu.so.4.3 SuperLU43 (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6 libsatlas.so.3 rtld(GNU_HASH) Provides -------- SuperLU43-debuginfo: SuperLU43-debuginfo SuperLU43-debuginfo(x86-32) SuperLU43-devel: SuperLU43-devel SuperLU43-devel(x86-32) SuperLU43: SuperLU43 SuperLU43(x86-32) libsuperlu.so.4.3 Source checksums ---------------- http://crd-legacy.lbl.gov/~xiaoye/SuperLU/superlu_4.3.tar.gz : CHECKSUM(SHA256) this package : 169920322eb9b9c6a334674231479d04df72440257c17870aaa0139d74416781 CHECKSUM(SHA256) upstream package : 169920322eb9b9c6a334674231479d04df72440257c17870aaa0139d74416781 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -b 1321440 -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 Issues: - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 6748160 bytes in 368 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation Please, add suggested sub package [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "GPL (with incorrect FSF address)", "Unknown or generated". 445 files have unknown license. Detailed output of licensecheck in /home/gil/1321440-SuperLU43/licensecheck.txt The package contains some files with GPLv2 license, but have incorrect Free Software Foundation address. To ensure that the problem does not re present more, please, report this bug upstream https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address The following source files are without license headers: SuperLU_4.3/CBLAS/caxpy.c SuperLU_4.3/CBLAS/ccopy.c SuperLU_4.3/CBLAS/cdotc.c SuperLU_4.3/CBLAS/cgemv.c SuperLU_4.3/CBLAS/cgerc.c SuperLU_4.3/CBLAS/chemv.c SuperLU_4.3/CBLAS/cher2.c SuperLU_4.3/CBLAS/cscal.c SuperLU_4.3/CBLAS/cswap.c SuperLU_4.3/CBLAS/ctrsv.c SuperLU_4.3/CBLAS/dasum.c SuperLU_4.3/CBLAS/daxpy.c SuperLU_4.3/CBLAS/dcabs1.c SuperLU_4.3/CBLAS/dcopy.c SuperLU_4.3/CBLAS/ddot.c SuperLU_4.3/CBLAS/dgemv.c SuperLU_4.3/CBLAS/dger.c SuperLU_4.3/CBLAS/dnrm2.c SuperLU_4.3/CBLAS/drot.c SuperLU_4.3/CBLAS/dscal.c SuperLU_4.3/CBLAS/dswap.c SuperLU_4.3/CBLAS/dsymv.c SuperLU_4.3/CBLAS/dsyr2.c SuperLU_4.3/CBLAS/dtrsv.c SuperLU_4.3/CBLAS/dzasum.c SuperLU_4.3/CBLAS/dznrm2.c SuperLU_4.3/CBLAS/f2c.h SuperLU_4.3/CBLAS/icamax.c SuperLU_4.3/CBLAS/idamax.c SuperLU_4.3/CBLAS/isamax.c SuperLU_4.3/CBLAS/izamax.c SuperLU_4.3/CBLAS/sasum.c SuperLU_4.3/CBLAS/saxpy.c SuperLU_4.3/CBLAS/scasum.c SuperLU_4.3/CBLAS/scnrm2.c SuperLU_4.3/CBLAS/scopy.c SuperLU_4.3/CBLAS/sdot.c SuperLU_4.3/CBLAS/sgemv.c SuperLU_4.3/CBLAS/sger.c SuperLU_4.3/CBLAS/slu_Cnames.h SuperLU_4.3/CBLAS/snrm2.c SuperLU_4.3/CBLAS/srot.c SuperLU_4.3/CBLAS/sscal.c SuperLU_4.3/CBLAS/sswap.c SuperLU_4.3/CBLAS/ssymv.c SuperLU_4.3/CBLAS/ssyr2.c SuperLU_4.3/CBLAS/strsv.c SuperLU_4.3/CBLAS/superlu_f2c.h SuperLU_4.3/CBLAS/zaxpy.c SuperLU_4.3/CBLAS/zcopy.c SuperLU_4.3/CBLAS/zdotc.c SuperLU_4.3/CBLAS/zgemv.c SuperLU_4.3/CBLAS/zgerc.c SuperLU_4.3/CBLAS/zhemv.c SuperLU_4.3/CBLAS/zher2.c SuperLU_4.3/CBLAS/zscal.c SuperLU_4.3/CBLAS/zswap.c SuperLU_4.3/CBLAS/ztrsv.c SuperLU_4.3/DOC/html/doxygen.css SuperLU_4.3/DOC/html/tabs.css SuperLU_4.3/DoxyConfig SuperLU_4.3/EXAMPLE/citersol.c SuperLU_4.3/EXAMPLE/citersol1.c SuperLU_4.3/EXAMPLE/clinsol.c SuperLU_4.3/EXAMPLE/clinsol1.c SuperLU_4.3/EXAMPLE/clinsolx.c SuperLU_4.3/EXAMPLE/clinsolx1.c SuperLU_4.3/EXAMPLE/clinsolx2.c SuperLU_4.3/EXAMPLE/ditersol.c SuperLU_4.3/EXAMPLE/ditersol1.c SuperLU_4.3/EXAMPLE/dlinsol.c SuperLU_4.3/EXAMPLE/dlinsol1.c SuperLU_4.3/EXAMPLE/dlinsolx.c SuperLU_4.3/EXAMPLE/dlinsolx1.c SuperLU_4.3/EXAMPLE/dlinsolx2.c SuperLU_4.3/EXAMPLE/fgmr.c SuperLU_4.3/EXAMPLE/sitersol.c SuperLU_4.3/EXAMPLE/sitersol1.c SuperLU_4.3/EXAMPLE/slinsol.c SuperLU_4.3/EXAMPLE/slinsol1.c SuperLU_4.3/EXAMPLE/slinsolx.c SuperLU_4.3/EXAMPLE/slinsolx1.c SuperLU_4.3/EXAMPLE/slinsolx2.c SuperLU_4.3/EXAMPLE/sp_ienv.c SuperLU_4.3/EXAMPLE/superlu.c SuperLU_4.3/EXAMPLE/zitersol.c SuperLU_4.3/EXAMPLE/zitersol1.c SuperLU_4.3/EXAMPLE/zlinsol.c SuperLU_4.3/EXAMPLE/zlinsol1.c SuperLU_4.3/EXAMPLE/zlinsolx.c SuperLU_4.3/EXAMPLE/zlinsolx1.c SuperLU_4.3/EXAMPLE/zlinsolx2.c SuperLU_4.3/FORTRAN/c_fortran_cgssv.c SuperLU_4.3/FORTRAN/c_fortran_dgssv.c SuperLU_4.3/FORTRAN/c_fortran_sgssv.c SuperLU_4.3/FORTRAN/c_fortran_zgssv.c SuperLU_4.3/FORTRAN/f77_main.f SuperLU_4.3/FORTRAN/hbcode1.f SuperLU_4.3/FORTRAN/z_f77_main.f SuperLU_4.3/FORTRAN/zhbcode1.f SuperLU_4.3/INSTALL/dlamch.c SuperLU_4.3/INSTALL/dlamchtst.c SuperLU_4.3/INSTALL/lsame.c SuperLU_4.3/INSTALL/slamch.c SuperLU_4.3/INSTALL/slamchtst.c SuperLU_4.3/INSTALL/superlu_timer.c SuperLU_4.3/INSTALL/timertst.c SuperLU_4.3/MATLAB/babble.m SuperLU_4.3/MATLAB/burble.m SuperLU_4.3/MATLAB/copyright.m SuperLU_4.3/MATLAB/hbo.m SuperLU_4.3/MATLAB/isperm.m SuperLU_4.3/MATLAB/lusolve.m SuperLU_4.3/MATLAB/mexlusolve.c SuperLU_4.3/MATLAB/mexlusolve.m SuperLU_4.3/MATLAB/mexsuperlu.c SuperLU_4.3/MATLAB/mexsuperlu.m SuperLU_4.3/MATLAB/permutation.m SuperLU_4.3/MATLAB/resetrandoms.m SuperLU_4.3/MATLAB/spart2.m SuperLU_4.3/MATLAB/spypart.m SuperLU_4.3/MATLAB/superlu.m SuperLU_4.3/MATLAB/time.m SuperLU_4.3/MATLAB/try2.m SuperLU_4.3/MATLAB/try3.m SuperLU_4.3/MATLAB/try4.m SuperLU_4.3/MATLAB/trylusolve.m SuperLU_4.3/MATLAB/trysuperlu.m SuperLU_4.3/MATLAB/trytime.m SuperLU_4.3/MATLAB/verbose.m SuperLU_4.3/SRC/ccolumn_bmod.c SuperLU_4.3/SRC/ccolumn_dfs.c SuperLU_4.3/SRC/ccopy_to_ucol.c SuperLU_4.3/SRC/cdiagonal.c SuperLU_4.3/SRC/cgscon.c SuperLU_4.3/SRC/cgsequ.c SuperLU_4.3/SRC/cgsisx.c SuperLU_4.3/SRC/cgsitrf.c SuperLU_4.3/SRC/cgsrfs.c SuperLU_4.3/SRC/cgssv.c SuperLU_4.3/SRC/cgssvx.c SuperLU_4.3/SRC/cgstrf.c SuperLU_4.3/SRC/cgstrs.c SuperLU_4.3/SRC/clacon.c SuperLU_4.3/SRC/clangs.c SuperLU_4.3/SRC/claqgs.c SuperLU_4.3/SRC/cldperm.c SuperLU_4.3/SRC/cmemory.c SuperLU_4.3/SRC/cmyblas2.c SuperLU_4.3/SRC/colamd.c SuperLU_4.3/SRC/colamd.h SuperLU_4.3/SRC/cpanel_bmod.c SuperLU_4.3/SRC/cpanel_dfs.c SuperLU_4.3/SRC/cpivotL.c SuperLU_4.3/SRC/cpivotgrowth.c SuperLU_4.3/SRC/cpruneL.c SuperLU_4.3/SRC/creadhb.c SuperLU_4.3/SRC/creadrb.c SuperLU_4.3/SRC/creadtriple.c SuperLU_4.3/SRC/csnode_bmod.c SuperLU_4.3/SRC/csnode_dfs.c SuperLU_4.3/SRC/csp_blas2.c SuperLU_4.3/SRC/csp_blas3.c SuperLU_4.3/SRC/cutil.c SuperLU_4.3/SRC/dcolumn_bmod.c SuperLU_4.3/SRC/dcolumn_dfs.c SuperLU_4.3/SRC/dcomplex.c SuperLU_4.3/SRC/dcopy_to_ucol.c SuperLU_4.3/SRC/ddiagonal.c SuperLU_4.3/SRC/dgscon.c SuperLU_4.3/SRC/dgsequ.c SuperLU_4.3/SRC/dgsisx.c SuperLU_4.3/SRC/dgsitrf.c SuperLU_4.3/SRC/dgsrfs.c SuperLU_4.3/SRC/dgssv.c SuperLU_4.3/SRC/dgssvx.c SuperLU_4.3/SRC/dgstrf.c SuperLU_4.3/SRC/dgstrs.c SuperLU_4.3/SRC/dlacon.c SuperLU_4.3/SRC/dlamch.c SuperLU_4.3/SRC/dlangs.c SuperLU_4.3/SRC/dlaqgs.c SuperLU_4.3/SRC/dldperm.c SuperLU_4.3/SRC/dmemory.c SuperLU_4.3/SRC/dmyblas2.c SuperLU_4.3/SRC/dpanel_bmod.c SuperLU_4.3/SRC/dpanel_dfs.c SuperLU_4.3/SRC/dpivotL.c SuperLU_4.3/SRC/dpivotgrowth.c SuperLU_4.3/SRC/dpruneL.c SuperLU_4.3/SRC/dreadhb.c SuperLU_4.3/SRC/dreadrb.c SuperLU_4.3/SRC/dreadtriple.c SuperLU_4.3/SRC/dsnode_bmod.c SuperLU_4.3/SRC/dsnode_dfs.c SuperLU_4.3/SRC/dsp_blas2.c SuperLU_4.3/SRC/dsp_blas3.c SuperLU_4.3/SRC/dutil.c SuperLU_4.3/SRC/dzsum1.c SuperLU_4.3/SRC/get_perm_c.c SuperLU_4.3/SRC/heap_relax_snode.c SuperLU_4.3/SRC/html_mainpage.h SuperLU_4.3/SRC/icmax1.c SuperLU_4.3/SRC/ilu_ccolumn_dfs.c SuperLU_4.3/SRC/ilu_ccopy_to_ucol.c SuperLU_4.3/SRC/ilu_cdrop_row.c SuperLU_4.3/SRC/ilu_cpanel_dfs.c SuperLU_4.3/SRC/ilu_cpivotL.c SuperLU_4.3/SRC/ilu_csnode_dfs.c SuperLU_4.3/SRC/ilu_dcolumn_dfs.c SuperLU_4.3/SRC/ilu_dcopy_to_ucol.c SuperLU_4.3/SRC/ilu_ddrop_row.c SuperLU_4.3/SRC/ilu_dpanel_dfs.c SuperLU_4.3/SRC/ilu_dpivotL.c SuperLU_4.3/SRC/ilu_dsnode_dfs.c SuperLU_4.3/SRC/ilu_heap_relax_snode.c SuperLU_4.3/SRC/ilu_relax_snode.c SuperLU_4.3/SRC/ilu_scolumn_dfs.c SuperLU_4.3/SRC/ilu_scopy_to_ucol.c SuperLU_4.3/SRC/ilu_sdrop_row.c SuperLU_4.3/SRC/ilu_spanel_dfs.c SuperLU_4.3/SRC/ilu_spivotL.c SuperLU_4.3/SRC/ilu_ssnode_dfs.c SuperLU_4.3/SRC/ilu_zcolumn_dfs.c SuperLU_4.3/SRC/ilu_zcopy_to_ucol.c SuperLU_4.3/SRC/ilu_zdrop_row.c SuperLU_4.3/SRC/ilu_zpanel_dfs.c SuperLU_4.3/SRC/ilu_zpivotL.c SuperLU_4.3/SRC/ilu_zsnode_dfs.c SuperLU_4.3/SRC/izmax1.c SuperLU_4.3/SRC/lsame.c SuperLU_4.3/SRC/mark_relax.c SuperLU_4.3/SRC/mc64ad.c SuperLU_4.3/SRC/memory.c SuperLU_4.3/SRC/mmd.c SuperLU_4.3/SRC/qselect.c SuperLU_4.3/SRC/relax_snode.c SuperLU_4.3/SRC/scolumn_bmod.c SuperLU_4.3/SRC/scolumn_dfs.c SuperLU_4.3/SRC/scomplex.c SuperLU_4.3/SRC/scopy_to_ucol.c SuperLU_4.3/SRC/scsum1.c SuperLU_4.3/SRC/sdiagonal.c SuperLU_4.3/SRC/sgscon.c SuperLU_4.3/SRC/sgsequ.c SuperLU_4.3/SRC/sgsisx.c SuperLU_4.3/SRC/sgsitrf.c SuperLU_4.3/SRC/sgsrfs.c SuperLU_4.3/SRC/sgssv.c SuperLU_4.3/SRC/sgssvx.c SuperLU_4.3/SRC/sgstrf.c SuperLU_4.3/SRC/sgstrs.c SuperLU_4.3/SRC/slacon.c SuperLU_4.3/SRC/slamch.c SuperLU_4.3/SRC/slangs.c SuperLU_4.3/SRC/slaqgs.c SuperLU_4.3/SRC/sldperm.c SuperLU_4.3/SRC/slu_Cnames.h SuperLU_4.3/SRC/slu_cdefs.h SuperLU_4.3/SRC/slu_dcomplex.h SuperLU_4.3/SRC/slu_ddefs.h SuperLU_4.3/SRC/slu_scomplex.h SuperLU_4.3/SRC/slu_sdefs.h SuperLU_4.3/SRC/slu_util.h SuperLU_4.3/SRC/slu_zdefs.h SuperLU_4.3/SRC/smemory.c SuperLU_4.3/SRC/smyblas2.c SuperLU_4.3/SRC/sp_coletree.c SuperLU_4.3/SRC/sp_ienv.c SuperLU_4.3/SRC/sp_preorder.c SuperLU_4.3/SRC/spanel_bmod.c SuperLU_4.3/SRC/spanel_dfs.c SuperLU_4.3/SRC/spivotL.c SuperLU_4.3/SRC/spivotgrowth.c SuperLU_4.3/SRC/spruneL.c SuperLU_4.3/SRC/sreadhb.c SuperLU_4.3/SRC/sreadrb.c SuperLU_4.3/SRC/sreadtriple.c SuperLU_4.3/SRC/ssnode_bmod.c SuperLU_4.3/SRC/ssnode_dfs.c SuperLU_4.3/SRC/ssp_blas2.c SuperLU_4.3/SRC/ssp_blas3.c SuperLU_4.3/SRC/superlu_enum_consts.h SuperLU_4.3/SRC/superlu_timer.c SuperLU_4.3/SRC/supermatrix.h SuperLU_4.3/SRC/sutil.c SuperLU_4.3/SRC/temp SuperLU_4.3/SRC/util.c SuperLU_4.3/SRC/xerbla.c SuperLU_4.3/SRC/zcolumn_bmod.c SuperLU_4.3/SRC/zcolumn_dfs.c SuperLU_4.3/SRC/zcopy_to_ucol.c SuperLU_4.3/SRC/zdiagonal.c SuperLU_4.3/SRC/zgscon.c SuperLU_4.3/SRC/zgsequ.c SuperLU_4.3/SRC/zgsisx.c SuperLU_4.3/SRC/zgsitrf.c SuperLU_4.3/SRC/zgsrfs.c SuperLU_4.3/SRC/zgssv.c SuperLU_4.3/SRC/zgssvx.c SuperLU_4.3/SRC/zgstrf.c SuperLU_4.3/SRC/zgstrs.c SuperLU_4.3/SRC/zlacon.c SuperLU_4.3/SRC/zlangs.c SuperLU_4.3/SRC/zlaqgs.c SuperLU_4.3/SRC/zldperm.c SuperLU_4.3/SRC/zmemory.c SuperLU_4.3/SRC/zmyblas2.c SuperLU_4.3/SRC/zpanel_bmod.c SuperLU_4.3/SRC/zpanel_dfs.c SuperLU_4.3/SRC/zpivotL.c SuperLU_4.3/SRC/zpivotgrowth.c SuperLU_4.3/SRC/zpruneL.c SuperLU_4.3/SRC/zreadhb.c SuperLU_4.3/SRC/zreadrb.c SuperLU_4.3/SRC/zreadtriple.c SuperLU_4.3/SRC/zsnode_bmod.c SuperLU_4.3/SRC/zsnode_dfs.c SuperLU_4.3/SRC/zsp_blas2.c SuperLU_4.3/SRC/zsp_blas3.c SuperLU_4.3/SRC/zutil.c SuperLU_4.3/TESTING/MATGEN/cdotc.c SuperLU_4.3/TESTING/MATGEN/clacgv.c SuperLU_4.3/TESTING/MATGEN/clagge.c SuperLU_4.3/TESTING/MATGEN/claghe.c SuperLU_4.3/TESTING/MATGEN/clagsy.c SuperLU_4.3/TESTING/MATGEN/clarge.c SuperLU_4.3/TESTING/MATGEN/clarnd.c SuperLU_4.3/TESTING/MATGEN/clarnv.c SuperLU_4.3/TESTING/MATGEN/claror.c SuperLU_4.3/TESTING/MATGEN/clarot.c SuperLU_4.3/TESTING/MATGEN/clartg.c SuperLU_4.3/TESTING/MATGEN/claset.c SuperLU_4.3/TESTING/MATGEN/clatb4.c SuperLU_4.3/TESTING/MATGEN/clatm2.c SuperLU_4.3/TESTING/MATGEN/clatm3.c SuperLU_4.3/TESTING/MATGEN/clatme.c SuperLU_4.3/TESTING/MATGEN/clatmr.c SuperLU_4.3/TESTING/MATGEN/clatms.c SuperLU_4.3/TESTING/MATGEN/csymv.c SuperLU_4.3/TESTING/MATGEN/d_lg10.c SuperLU_4.3/TESTING/MATGEN/d_sign.c SuperLU_4.3/TESTING/MATGEN/dlabad.c SuperLU_4.3/TESTING/MATGEN/dlagge.c SuperLU_4.3/TESTING/MATGEN/dlagsy.c SuperLU_4.3/TESTING/MATGEN/dlaran.c SuperLU_4.3/TESTING/MATGEN/dlarge.c SuperLU_4.3/TESTING/MATGEN/dlarnd.c SuperLU_4.3/TESTING/MATGEN/dlarnv.c SuperLU_4.3/TESTING/MATGEN/dlaror.c SuperLU_4.3/TESTING/MATGEN/dlarot.c SuperLU_4.3/TESTING/MATGEN/dlartg.c SuperLU_4.3/TESTING/MATGEN/dlaruv.c SuperLU_4.3/TESTING/MATGEN/dlaset.c SuperLU_4.3/TESTING/MATGEN/dlatb4.c SuperLU_4.3/TESTING/MATGEN/dlatm1.c SuperLU_4.3/TESTING/MATGEN/dlatm2.c SuperLU_4.3/TESTING/MATGEN/dlatm3.c SuperLU_4.3/TESTING/MATGEN/dlatme.c SuperLU_4.3/TESTING/MATGEN/dlatmr.c SuperLU_4.3/TESTING/MATGEN/dlatms.c SuperLU_4.3/TESTING/MATGEN/f2c.h SuperLU_4.3/TESTING/MATGEN/lsamen.c SuperLU_4.3/TESTING/MATGEN/pow_dd.c SuperLU_4.3/TESTING/MATGEN/r_lg10.c SuperLU_4.3/TESTING/MATGEN/r_sign.c SuperLU_4.3/TESTING/MATGEN/slabad.c SuperLU_4.3/TESTING/MATGEN/slagge.c SuperLU_4.3/TESTING/MATGEN/slagsy.c SuperLU_4.3/TESTING/MATGEN/slaran.c SuperLU_4.3/TESTING/MATGEN/slarge.c SuperLU_4.3/TESTING/MATGEN/slarnd.c SuperLU_4.3/TESTING/MATGEN/slarnv.c SuperLU_4.3/TESTING/MATGEN/slaror.c SuperLU_4.3/TESTING/MATGEN/slarot.c SuperLU_4.3/TESTING/MATGEN/slartg.c SuperLU_4.3/TESTING/MATGEN/slaruv.c SuperLU_4.3/TESTING/MATGEN/slaset.c SuperLU_4.3/TESTING/MATGEN/slatb4.c SuperLU_4.3/TESTING/MATGEN/slatm1.c SuperLU_4.3/TESTING/MATGEN/slatm2.c SuperLU_4.3/TESTING/MATGEN/slatm3.c SuperLU_4.3/TESTING/MATGEN/slatme.c SuperLU_4.3/TESTING/MATGEN/slatmr.c SuperLU_4.3/TESTING/MATGEN/slatms.c SuperLU_4.3/TESTING/MATGEN/slu_Cnames.h SuperLU_4.3/TESTING/MATGEN/zdotc.c SuperLU_4.3/TESTING/MATGEN/zlacgv.c SuperLU_4.3/TESTING/MATGEN/zlagge.c SuperLU_4.3/TESTING/MATGEN/zlaghe.c SuperLU_4.3/TESTING/MATGEN/zlagsy.c SuperLU_4.3/TESTING/MATGEN/zlarge.c SuperLU_4.3/TESTING/MATGEN/zlarnd.c SuperLU_4.3/TESTING/MATGEN/zlarnv.c SuperLU_4.3/TESTING/MATGEN/zlaror.c SuperLU_4.3/TESTING/MATGEN/zlarot.c SuperLU_4.3/TESTING/MATGEN/zlartg.c SuperLU_4.3/TESTING/MATGEN/zlaset.c SuperLU_4.3/TESTING/MATGEN/zlatb4.c SuperLU_4.3/TESTING/MATGEN/zlatm2.c SuperLU_4.3/TESTING/MATGEN/zlatm3.c SuperLU_4.3/TESTING/MATGEN/zlatme.c SuperLU_4.3/TESTING/MATGEN/zlatmr.c SuperLU_4.3/TESTING/MATGEN/zlatms.c SuperLU_4.3/TESTING/MATGEN/zsymv.c SuperLU_4.3/TESTING/cdrive.c SuperLU_4.3/TESTING/cgst01.c SuperLU_4.3/TESTING/cgst02.c SuperLU_4.3/TESTING/cgst04.c SuperLU_4.3/TESTING/cgst07.c SuperLU_4.3/TESTING/ddrive.c SuperLU_4.3/TESTING/dgst01.c SuperLU_4.3/TESTING/dgst02.c SuperLU_4.3/TESTING/dgst04.c SuperLU_4.3/TESTING/dgst07.c SuperLU_4.3/TESTING/sdrive.c SuperLU_4.3/TESTING/sgst01.c SuperLU_4.3/TESTING/sgst02.c SuperLU_4.3/TESTING/sgst04.c SuperLU_4.3/TESTING/sgst07.c SuperLU_4.3/TESTING/sp_cconvert.c SuperLU_4.3/TESTING/sp_dconvert.c SuperLU_4.3/TESTING/sp_ienv.c SuperLU_4.3/TESTING/sp_sconvert.c SuperLU_4.3/TESTING/sp_zconvert.c SuperLU_4.3/TESTING/zdrive.c SuperLU_4.3/TESTING/zgst01.c SuperLU_4.3/TESTING/zgst02.c SuperLU_4.3/TESTING/zgst04.c SuperLU_4.3/TESTING/zgst07.c SuperLU_4.3/b/SRC/mc64ad.c Please, ask to upstream to add license headers https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification Created attachment 1140717 [details]
licensecheck
- Added the doc subpackage - Added GPLV2+ on the license field. - I will send an email to upstream about adding the license headers on individual files along with licensecheck.txt file. Updated SPEC and SRPM below - SPEC URL: https://nonamedotc.fedorapeople.org/pkgreview/compat-superlu-43/SuperLU43.spec SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/compat-superlu-43/SuperLU43-4.3-3.fc23.src.rpm koji scratch build - https://koji.fedoraproject.org/koji/taskinfo?taskID=13477517 (In reply to Mukundan Ragavan from comment #12) > - Added the doc subpackage > - Added GPLV2+ on the license field. Maybe, should be added only for doc sub package ... ? > - I will send an email to upstream about adding the license headers on > individual files along with licensecheck.txt file. Thanks Approved Thanks gil for the review! Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/SuperLU43 SuperLU43-4.3-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3e571d5368 SuperLU43-4.3-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-3e571d5368 SuperLU43-4.3-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. |