Bug 1321655
Summary: | Catalog Item : editing catalog item randomly throws error " undefined method `[]' for nil:NilClass [catalog/atomic_form_field_changed] " | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Red Hat CloudForms Management Engine | Reporter: | Shveta <sshveta> | ||||||||
Component: | UI - OPS | Assignee: | Harpreet Kataria <hkataria> | ||||||||
Status: | CLOSED ERRATA | QA Contact: | Shveta <sshveta> | ||||||||
Severity: | medium | Docs Contact: | |||||||||
Priority: | high | ||||||||||
Version: | 5.5.0 | CC: | dclarizi, hkataria, jhardy, jprause, mfeifer, mpovolny, obarenbo, simaishi | ||||||||
Target Milestone: | GA | Keywords: | ZStream | ||||||||
Target Release: | 5.6.0 | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Whiteboard: | service:catalog | ||||||||||
Fixed In Version: | 5.6.0.0 | Doc Type: | Bug Fix | ||||||||
Doc Text: | Story Points: | --- | |||||||||
Clone Of: | |||||||||||
: | 1322022 (view as bug list) | Environment: | |||||||||
Last Closed: | 2016-06-29 15:45:19 UTC | Type: | Bug | ||||||||
Regression: | --- | Mount Type: | --- | ||||||||
Documentation: | --- | CRM: | |||||||||
Verified Versions: | Category: | --- | |||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||||
Embargoed: | |||||||||||
Bug Depends On: | |||||||||||
Bug Blocks: | 1322022 | ||||||||||
Attachments: |
|
Created attachment 1141029 [details]
production log
Created attachment 1141031 [details]
self_Service_tab
*** Bug 1321657 has been marked as a duplicate of this bug. *** Steps : 1) Two tabs were open.https://IP and https://IP/self_service 2) In self_service tab under Myservice , open a service and then in CFME edit that catalog item 3) see error Fixed on upstream by https://github.com/ManageIQ/manageiq/pull/6547 New commit detected on cfme/5.5.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=30c8b5cdfd503ea486aa53a6331de5ec2ad3003a commit 30c8b5cdfd503ea486aa53a6331de5ec2ad3003a Author: Martin Hradil <mhradil> AuthorDate: Mon Feb 8 09:14:20 2016 -0500 Commit: Harpreet Kataria <hkataria> CommitDate: Wed Mar 30 09:35:06 2016 -0400 ApiController - Disable get/set_global_session_data API requests should ideally not touch the session at all, but for now, at least don't break it. Without this, any API request clears `edit`, `view` and `layout` (possibly others) from session, because `set_global_session_data` expects `@edit` (etc) to be populated with the right new value, and `load_edit` is never called in the api (nor does it make sense to call it there). Fixes #6545 https://bugzilla.redhat.com/show_bug.cgi?id=1321655 https://bugzilla.redhat.com/show_bug.cgi?id=1322022 (cherry picked from commit 7f7864d) app/controllers/api_controller.rb | 3 +++ 1 file changed, 3 insertions(+) New commit detected on cfme/5.5.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=5a2eac8368e4a73ece4f27b0b7281afa8ec146a6 commit 5a2eac8368e4a73ece4f27b0b7281afa8ec146a6 Merge: ea5176f 30c8b5c Author: Dan Clarizio <dclarizi> AuthorDate: Thu Apr 14 16:51:59 2016 -0400 Commit: Dan Clarizio <dclarizi> CommitDate: Thu Apr 14 16:51:59 2016 -0400 Merge branch 'api_transaction_fix' into '5.5.z' ApiController - Disable get/set_global_session_data API requests should ideally not touch the session at all, but for now, at least don't break it. Without this, any API request clears `edit`, `view` and `layout` (possibly others) from session, because `set_global_session_data` expects `@edit` (etc) to be populated with the right new value, and `load_edit` is never called in the api (nor does it make sense to call it there). Fixes #6545 https://bugzilla.redhat.com/show_bug.cgi?id=1321655 https://bugzilla.redhat.com/show_bug.cgi?id=1322022 (cherry picked from commit 7f7864d) @dclarizi please review, this is clean cherry-pick from https://github.com/ManageIQ/manageiq/pull/6547 See merge request !874 app/controllers/api_controller.rb | 3 +++ 1 file changed, 3 insertions(+) Verified in 5.6.0.4-beta2.3.20160421172650_719e256 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2016:1348 |
Created attachment 1140985 [details] error Description of problem: Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. I ran into this issue several times but steps of reproduction were different .Create a catalog item and select catalog and dialog and then check "display in catalog " shows error 2. Or create a catalog and save and then edit and change any field . See this error as in attached screenshot 3. Actual results: Expected results: Additional info: 5.5.3.2.20160318152106_92d2d67 Production log =============== [----] F, [2016-03-28T15:10:14.978741 #3000:61d988] FATAL -- : Error caught: [NoMethodError] undefined method `[]' for nil:NilClass /var/www/miq/vmdb/app/controllers/catalog_controller.rb:148:in `atomic_form_field_changed' /opt/rh/cfme-gemset/gems/actionpack-4.2.6/lib/action_controller/metal/implicit_render.rb:4:in `send_action' /opt/rh/cfme-gemset/gems/actionpack-4.2.6/lib/abstract_controller/base.rb:198:in `process_action' /opt/rh/cfme-gemset/gems/actionpack-4.2.6/lib/action_controller/metal/rendering.rb:10:in `process_action' /opt/rh/cfme-gemset/gems/actionpack-4.2.6/lib/abstract_controller/callbacks.rb:20:in `block in process_action' /opt/rh/cfme-gemset/gems/activesupport-4.2.6/lib/active_support/callbacks.rb:117:in `call' /opt/rh/cfme-gemset/gems/activesupport-4.2.6/lib/active_support/callbacks.rb:117:in `call' /opt/rh/cfme-gemset/gems/activesupport-4.2.6/lib/active_support/callbacks.rb:555:in `block (2 levels) in compile' /opt/rh/cfme-gemset/gems/activesupport-4.2.6/lib/active_support/callbacks.rb:505:in `call' /opt/rh/cfme-gemset/gems/activesupport-4.2.6/lib/active_support/callbacks.rb:505:in `call' /opt/rh/cfme-gemset/gems/activesupport-4.2.6/lib/active_support/callbacks.rb:92:in `__run_callbacks__' /opt/rh/cfme-gemset/gems/activesupport-4.2.6/lib/active_support/callbacks.rb:778:in `_run_process_action_callbacks' /opt/rh/cfme-gemset/gems/activesupport-4.2.6/lib/active_support/callbacks.rb:81:in `run_callbacks' /opt/rh/cfme-gemset/gems/actionpack-4.2.6/lib/abstract_controller/callbacks.rb:19:in `process_action' /opt/rh/cfme-gemset/gems/actionpack-4.2.6/lib/action_controller/metal/rescue.rb:29:in `process_action' /opt/rh/cfme-gemset/gems/actionpack-4.2.6/lib/action_controller/metal/instrumentation.rb:32:in `block in process_action' /opt/rh/cfme-gemset/gems/activesupport-4.2.6/lib/active_support/notifications.rb:164:in `block in instrument' /opt/rh/cfme-gemset/gems/activesupport-4.2.6/lib/active_support/notifications/instrumenter.rb:20:in `instrument' /opt/rh/cfme-gemset/gems/activesupport-4.2.6/lib/active_support/notifications.rb:164:in `instrument' /opt/rh/cfme-gemset/gems/actionpack-4.2.6/lib/action_controller/metal/instrumentation.rb:30:in `process_action' /opt/rh/cfme-gemset/gems/actionpack-4.2.6/lib/action_controller/metal/params_wrapper.rb:250:in `process_action' /opt/rh/cfme-gemset/gems/activerecord-4.2.6/lib/active_record/railties/controller_runtime.rb:18:in `process_action' /opt/rh/cfme-gemset/gems/actionpack-4.2.6/lib/abstract_controller/base.rb:137:in `process' /opt/rh/cfme-gemset/gems/actionview-4.2.6/lib/action_view/rendering.rb:30:in `process' /opt/rh/cfme-gemset/gems/actionpack-4.2.6/lib/action_controller/metal.rb:196:in `dispatch' /opt/rh/cfme-gemset/gems/actionpack-4.2.6/lib/action_controller/metal/rack_delegation.rb:13:in `dispatch' /opt/rh/cfme-gemset/gems/actionpack-4.2.6/lib/action_controller/metal.rb:237:in `block in action' /opt/rh/cfme-gemset/gems/actionpack-4.2.6/lib/action_dispatch/routing/route_set.rb:74:in `call' /opt/rh/cfme-gemset/gems/actionpack-4.2.6/lib/action_dispatch/routing/route_set.rb:74:in `dispatch' /opt/rh/cfme-gemset/gems/actionpack-4.2.6/lib/action_dispatch/routing/route_set.rb:43:in `serve' /opt/rh/cfme-gemset/gems/actionpack-4.2.6/lib/action_dispatch/journey/router.rb:43:in `block in serve' /opt/rh/cfme-gemset/gems/actionpack-4.2.6/lib/action_dispatch/journey/router.rb:30:in `each' /opt/rh/cfme-gemset/gems/actionpack-4.2.6/lib/action_dispatch/journey/router.rb:30:in `serve' /opt/rh/cfme-gemset/gems/actionpack-4.2.6/lib/action_dispatch/routing/route_set.rb:817:in `call' /opt/rh/cfme-gemset/gems/rack-1.6.4/lib/rack/etag.rb:24:in `call' /opt/rh/cfme-gemset/gems/rack-1.6.4/lib/rack/conditionalget.rb:38:in `call' /opt/rh/cfme-gemset/gems/rack-1.6.4/lib/rack/head.rb:13:in `call' /opt/rh/cfme-gemset/gems/actionpack-4.2.6/lib/action_dispatch/middleware/params_parser.rb:27:in `call' /opt/rh/cfme-gemset/gems/actionpack-4.2.6/lib/action_dispatch/middleware/flash.rb:260:in `call' /opt/rh/cfme-gemset/gems/rack-1.6.4/lib/rack/session/abstract/id.rb:225:in `context' /opt/rh/cfme-gemset/gems/rack-1.6.4/lib/rack/session/abstract/id.rb:220:in `call' /opt/rh/cfme-gemset/gems/actionpack-4.2.6/lib/action_dispatch/middleware/cookies.rb:560:in `call' /opt/rh/cfme-gemset/gems/activerecord-4.2.6/lib/active_record/query_cache.rb:36:in `call' /opt/rh/cfme-gemset/gems/activerecord-4.2.6/lib/active_record/connection_adapters/abstract/connection_pool.rb:653:in `call' /opt/rh/cfme-gemset/gems/actionpack-4.2.6/lib/action_dispatch/middleware/callbacks.rb:29:in `block in call' /opt/rh/cfme-gemset/gems/activesupport-4.2.6/lib/active_support/callbacks.rb:88:in `__run_callbacks__' /opt/rh/cfme-gemset/gems/activesupport-4.2.6/lib/active_support/callbacks.rb:778:in `_run_call_callbacks' /opt/rh/cfme-gemset/gems/activesupport-4.2.6/lib/active_support/callbacks.rb:81:in `run_callbacks' /opt/rh/cfme-gemset/gems/actionpack-4.2.6/lib/action_dispatch/middleware/callbacks.rb:27:in `call' /opt/rh/cfme-gemset/gems/actionpack-4.2.6/lib/action_dispatch/middleware/remote_ip.rb:78:in `call' /opt/rh/cfme-gemset/gems/actionpack-4.2.6/lib/action_dispatch/middleware/debug_exceptions.rb:17:in `call' /opt/rh/cfme-gemset/gems/actionpack-4.2.6/lib/action_dispatch/middleware/show_exceptions.rb:30:in `call' /opt/rh/cfme-gemset/gems/railties-4.2.6/lib/rails/rack/logger.rb:38:in `call_app' /opt/rh/cfme-gemset/gems/railties-4.2.6/lib/rails/rack/logger.rb:22:in `call' /opt/rh/cfme-gemset/gems/actionpack-4.2.6/lib/action_dispatch/middleware/request_id.rb:21:in `call' /opt/rh/cfme-gemset/gems/rack-1.6.4/lib/rack/methodoverride.rb:22:in `call' /opt/rh/cfme-gemset/gems/rack-1.6.4/lib/rack/runtime.rb:18:in `call' /opt/rh/cfme-gemset/gems/activesupport-4.2.6/lib/active_support/cache/strategy/local_cache_middleware.rb:28:in `call' /opt/rh/cfme-gemset/gems/rack-1.6.4/lib/rack/lock.rb:17:in `call' /opt/rh/cfme-gemset/gems/actionpack-4.2.6/lib/action_dispatch/middleware/static.rb:120:in `call' /opt/rh/cfme-gemset/gems/actionpack-4.2.6/lib/action_dispatch/middleware/static.rb:120:in `call' /opt/rh/cfme-gemset/gems/rack-1.6.4/lib/rack/sendfile.rb:113:in `call' /opt/rh/cfme-gemset/gems/railties-4.2.6/lib/rails/engine.rb:518:in `call' /opt/rh/cfme-gemset/gems/railties-4.2.6/lib/rails/application.rb:165:in `call' /opt/rh/cfme-gemset/gems/rack-1.6.4/lib/rack/content_length.rb:15:in `call' /opt/rh/rh-ruby22/root/usr/share/gems/gems/thin-1.6.3/lib/thin/connection.rb:86:in `block in pre_process' /opt/rh/rh-ruby22/root/usr/share/gems/gems/thin-1.6.3/lib/thin/connection.rb:84:in `catch' /opt/rh/rh-ruby22/root/usr/share/gems/gems/thin-1.6.3/lib/thin/connection.rb:84:in `pre_process' /opt/rh/rh-ruby22/root/usr/share/gems/gems/thin-1.6.3/lib/thin/connection.rb:53:in `process' /opt/rh/rh-ruby22/root/usr/share/gems/gems/thin-1.6.3/lib/thin/connection.rb:39:in `receive_data' /opt/rh/rh-ruby22/root/usr/share/gems/gems/eventmachine-1.0.7/lib/eventmachine.rb:187:in `run_machine' /opt/rh/rh-ruby22/root/usr/share/gems/gems/eventmachine-1.0.7/lib/eventmachine.rb:187:in `run' /opt/rh/rh-ruby22/root/usr/share/gems/gems/thin-1.6.3/lib/thin/backends/base.rb:73:in `start' /opt/rh/rh-ruby22/root/usr/share/gems/gems/thin-1.6.3/lib/thin/server.rb:162:in `start' /opt/rh/cfme-gemset/gems/rack-1.6.4/lib/rack/handler/thin.rb:19:in `run' /opt/rh/cfme-gemset/gems/rack-1.6.4/lib/rack/server.rb:286:in `start' /opt/rh/cfme-gemset/gems/railties-4.2.6/lib/rails/commands/commands_tasks.rb:80:in `block in server' /opt/rh/cfme-gemset/gems/railties-4.2.6/lib/rails/commands/commands_tasks.rb:75:in `tap' /opt/rh/cfme-gemset/gems/railties-4.2.6/lib/rails/commands/commands_tasks.rb:75:in `server' /opt/rh/cfme-gemset/gems/railties-4.2.6/lib/rails/commands/commands_tasks.rb:39:in `run_command!' /opt/rh/cfme-gemset/gems/railties-4.2.6/lib/rails/commands.rb:17:in `<top (required)>' /var/www/miq/vmdb/bin/rails:4:in `require' /var/www/miq/vmdb/bin/rails:4:in `<main>'