Bug 1321902 (qt5ct)
| Summary: | Review Request: qt5ct - Qt5 Configuration Tool | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christian Dersch <lupinix.fedora> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | michael, package-review, projects.rg, rdieter |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | rdieter:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | Trivial | ||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-05-20 23:51:49 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 928937 | ||
|
Description
Christian Dersch
2016-03-29 11:02:43 UTC
New Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=13494545 New Koji build to reflect current spec status: http://koji.fedoraproject.org/koji/taskinfo?taskID=13495637 Change: Added BuildRequires: gcc-c++ required by https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B#BuildRequires_and_Requires Thanks for working on this, been meaning to look into it myself for awhile. Completely UNOFFICIAL comments following: * the Source0 URL is not a direct link to the tarball (it goes to sourceforge's redirect page) => https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Sourceforge.net suggests Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz * 0.23 just came out (minor point since it came out after this was submitted) * Package installs and seems to run correctly I can do a formal review today. naming: ok sources: ok 28af9b3aa030fb31c00932453e59f635 qt5ct-0.22.tar.bz2 though I agree per comment #4 above, 1. SHOULD update URL to match SourceURL guidelines for sourceforge projects license: ok macros: mostly ok 2. SHOULD: %make_install should be used only for autoconf-based packages, use instead: make install INSTALL_ROOT=%{buildroot} scriptlets: NOT ok 3. SHOULD remove not-needed ldconfig and icon scriptlets. This package contains neither any shared libraries or icons. I don't see any blockers, but please consider addressing those 3 SHOULD items prior to doing any official builds. APPROVED Done, thank you for reviewing :) I'll also import the new version 0.23 released some days ago. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/qt5ct qt5ct-0.23-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-19c9d2ffbf qt5ct-0.23-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-002673fb41 qt5ct-0.23-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-93684d7e11 qt5ct-0.23-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-64b17587f7 qt5ct-0.23-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-19c9d2ffbf qt5ct-0.23-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. qt5ct-0.23-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-93684d7e11 qt5ct-0.23-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-002673fb41 qt5ct-0.23-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-64b17587f7 qt5ct-0.23-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. qt5ct-0.23-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. qt5ct-0.23-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |