Bug 1322046

Summary: update to flashrom-0.9.9
Product: [Fedora] Fedora Reporter: Jeff Bastian <jbastian>
Component: flashromAssignee: Peter Lemenkov <lemenkov>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: medium    
Version: 25CC: dwmw2, lemenkov, voxadam
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://www.flashrom.org/git/flashrom.git/
Whiteboard:
Fixed In Version: flashrom-0.9.9-2.fc25 flashrom-0.9.9-2.fc24 flashrom-0.9.9-3.fc26 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-03-20 01:49:52 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
flashrom-0.9.9 src rpm none

Description Jeff Bastian 2016-03-29 15:58:02 UTC
Created attachment 1141330 [details]
flashrom-0.9.9 src rpm

Description of problem:
Please update the Fedora flashrom rpm to the upstream 0.9.9 version.  It includes support for more hardware, e.g., the Macronix MX25L12835F, which I'm trying to flash.

I used the spec file from the 0.9.7 rpm and removed the patches and it builds cleanly on x86_64.  See the attached src rpm.

Comment 1 David Woodhouse 2016-04-04 20:43:52 UTC
Dediprog SF600 support would be extremely useful too. Any objection if I push this update to rawhide, and potentially then to F23?

Comment 2 David Woodhouse 2016-04-04 20:48:25 UTC
Hm, it seems those patches convert the build system to autotools. Is there a reason we're carrying such patches in our own package? When was the last attempt made to push them upstream?

Comment 3 Jeff Bastian 2016-04-04 21:29:44 UTC
The dates in all the autotools patches are from June and September, 2010.  I don't know if there have been any more recent attempts to get them merged upstream, but if they still haven't been accepted after almost 6 years, maybe we don't need them.

Comment 4 Peter Lemenkov 2016-04-05 11:23:09 UTC
(In reply to David Woodhouse from comment #2)
> Hm, it seems those patches convert the build system to autotools. Is there a
> reason we're carrying such patches in our own package? When was the last
> attempt made to push them upstream?

David, Jeff, it turned out that some of Flashrom upstream developers are very much against autotools (as well as against Git, for example), so I lost interest in maintaining and rebasing them. Feel free to update.

David just in case if you want to (co)maintain this - I'd like to grant you additional rights. In fact this package needs love and I;m not a right person to maintain it (my last real world and very positive experience with this tool was ~5 years ago).

Comment 5 David Woodhouse 2016-04-05 18:49:07 UTC
I don't need rights; only permission — which I'm inferring from your comment; thanks :)

I had wondered if the autotools change also helped with portability to Fedora architectures; I'll try to keep an eye on that as I attempt to do the update. Do you know if there were ever any actual users on non-x86?

Comment 6 Peter Lemenkov 2016-04-05 18:54:57 UTC
(In reply to David Woodhouse from comment #5)
> I don't need rights; only permission — which I'm inferring from your
> comment; thanks :)
> 
> I had wondered if the autotools change also helped with portability to
> Fedora architectures; I'll try to keep an eye on that as I attempt to do the
> update. Do you know if there were ever any actual users on non-x86?

Some flashrom upstream developers believe that portability must be achieved with nested #ifdef...#endif in the source code, not with autotools (or CMake).
 
I was a non-x86 user (I played with the contents of my Mac Mini G4' ROM for a while). But I got rid from all non-x86_64 hardware a long time ago. So yes - such users existed actually.

Comment 7 Jan Kurik 2016-07-26 04:33:41 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 25 development cycle.
Changing version to '25'.

Comment 8 Adam Hunt 2017-01-28 18:45:59 UTC
As I haven't so much as glanced as the project's source it seems like they've at least seen light and moved to git.

Comment 9 Fedora Update System 2017-03-07 15:58:07 UTC
flashrom-0.9.9-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-9a4449b912

Comment 10 Fedora Update System 2017-03-07 15:58:27 UTC
flashrom-0.9.9-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-4b615bb464

Comment 11 Fedora Update System 2017-03-07 15:58:42 UTC
flashrom-0.9.9-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-768f1b0e0e

Comment 12 Fedora Update System 2017-03-08 14:53:47 UTC
flashrom-0.9.9-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-4b615bb464

Comment 13 Fedora Update System 2017-03-08 14:54:38 UTC
flashrom-0.9.9-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-9a4449b912

Comment 14 Fedora Update System 2017-03-08 17:55:59 UTC
flashrom-0.9.9-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-d82f8c61df

Comment 15 Fedora Update System 2017-03-08 17:56:26 UTC
flashrom-0.9.9-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-739b22618c

Comment 16 Fedora Update System 2017-03-08 17:56:43 UTC
flashrom-0.9.9-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e0e0301560

Comment 17 Fedora Update System 2017-03-09 14:26:15 UTC
flashrom-0.9.9-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e0e0301560

Comment 18 Fedora Update System 2017-03-09 14:58:13 UTC
flashrom-0.9.9-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-d82f8c61df

Comment 19 Fedora Update System 2017-03-10 23:22:26 UTC
flashrom-0.9.9-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-739b22618c

Comment 20 Fedora Update System 2017-03-12 12:16:29 UTC
flashrom-0.9.9-3.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-1d0fec77e2

Comment 21 Fedora Update System 2017-03-13 01:51:26 UTC
flashrom-0.9.9-3.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-1d0fec77e2

Comment 22 Fedora Update System 2017-03-20 01:49:52 UTC
flashrom-0.9.9-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 23 Fedora Update System 2017-03-20 05:49:35 UTC
flashrom-0.9.9-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 24 Fedora Update System 2017-04-01 16:57:35 UTC
flashrom-0.9.9-3.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.