Bug 1322050 (CVE-2016-3072)

Summary: CVE-2016-3072 Katello: Authenticated sql injection via sort_by and sort_order request parameter
Product: [Other] Security Response Reporter: Kurt Seifried <kseifried>
Component: vulnerabilityAssignee: Red Hat Product Security <security-response-team>
Status: CLOSED ERRATA QA Contact:
Severity: high Docs Contact:
Priority: high    
Version: unspecifiedCC: bkearney, cbillett, cpelland, cperry, jmatthew, kseifried, mmccune, ohadlevy, security-response-team, taw, tjay, tlestach, tomckay, tsanders
Target Milestone: ---Keywords: Security
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
An input sanitization flaw was found in the scoped search parameters sort_by and sort_order in the REST API. An authenticated user could use this flaw to perform an SQL injection attack on the Katello back end database.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2016-06-01 19:34:11 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1321635, 1350803    
Bug Blocks: 1322054    

Description Kurt Seifried 2016-03-29 16:05:39 UTC 
Description of problem:

The foreman & Katello projects received an upstream notification about the discovery of an authenticated sql injection vulnerability within katello:

Dear Katello/Foreman Team,

During an internal test it was discovered that the scoped search
parameters sort_by and sort_order are vulnerable to an authenticated SQL
injection.

If we access:
https://x.x.x.x/katello/api/v2/organizations/1/sync_plans/1/products?available_for=sync_plan&full_result=true&page=1&search=&sort_by=name&sort_order=ASC'

we will see the following error:

{"displayMessage":"PG::Error: ERROR:  unterminated quoted string at or
near \"', katello_products.id <http://katello_products.id> DESC\"\nLINE
1: ...n_id IS NULL))  ORDER BY katello_products.name
<http://katello_products.name> ASC', katello...\n
                                      ^\n: SELECT \"katello_products\".*
FROM \"katello_products\"  WHERE \"katello_products\".\"id\" IN (SELECT
DISTINCT \"katello_products\".\"id\" FROM \"katello_products\"  WHERE
\"katello_products\".\"organization_id\" = 1 AND (katello_products.id
<http://katello_products.id> in (NULL) or katello_products.id
<http://katello_products.id> in (6,5,4,2,3,1)) AND (sync_plan_id != '1'
OR sync_plan_id IS NULL))  ORDER BY katello_products.name
<http://katello_products.name> ASC', katello_products.id
<http://katello_products.id> DESC","errors":["PG::Error: ERROR:
unterminated quoted string at or near \"', katello_products.id
<http://katello_products.id> DESC\"\nLINE 1: ...n_id IS NULL))  ORDER BY
katello_products.name <http://katello_products.name> ASC', katello...\n


The injection can be exploited as a blind time based injection.

Best Regards
Oliver

External reference:
The line of code in question here is:  https://github.com/Katello/katello/blob/KATELLO-3.0/app/controllers/katello/api/v2/api_controller.rb#L67
Comment 2 errata-xmlrpc 2016-05-16 19:16:04 UTC 
This issue has been addressed in the following products:

  Red Hat Satellite 6.1

Via RHSA-2016:1083 https://access.redhat.com/errata/RHSA-2016:1083