Bug 1322101

Summary:	vm reconfigure event passing invalid data to Automate.
Product:	Red Hat CloudForms Management Engine	Reporter:	Tina Fitzgerald <tfitzger>
Component:	Automate	Assignee:	William Fitzgerald <wfitzger>
Status:	CLOSED ERRATA	QA Contact:	Milan Falešník <mfalesni>
Severity:	high	Docs Contact:
Priority:	high
Version:	5.6.0	CC:	jhardy, mkanoor, obarenbo, tfitzger, wfitzger
Target Milestone:	GA
Target Release:	5.6.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	automate:reconfigure
Fixed In Version:	5.6.0.1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-06-29 15:45:51 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Tina Fitzgerald 2016-03-29 19:49:14 UTC

Description of problem:
Invalid data passed from the vm_reconfigure event prevents the expected $evm.root object vm attribute from containing the vm object. 

The Instantiate line below contains details of the issue:
1. The "VmOrTemplate%3A%3Avm=2225" reference is correct and would result in the $evm.root object vm attribute containing the vm object.
2. The "manageiq%3A%3Aproviders%3A%3Avmware%3A%3Ainframanager%3A%3Avm=2225" is invalid for automate and overrides the object in #1. The result is a $evm.root attribute, vm having the value of the id, 2225 instead of the vm object with id 2225.

Instantiating [/System/Process/Event?EventStream%3A%3Aevent_stream=673608&
MiqEvent%3A%3Amiq_event=673608&
MiqServer%3A%3Amiq_server=1&
User%3A%3Auser=1&
VmOrTemplate%3A%3Avm=2225&
ems_event=673535&
event_stream_id=673608&
event_type=vm_reconfigure
&ext_management_systems=7&
manageiq%3A%3Aproviders%3A%3Avmware%3A%3Ainframanager%3A%3Avm=2225&
miq_event_id=673608&
object_name=Event&
vmdb_object_type=vm]


Steps to Reproduce:
1. Reconfigure VM.
2. Look in the automation.log for the instantiate line as shown above.

Actual results:
Automation.log Instantiate line shows as above containing the "manageiq%3A%3Aproviders%3A%3Avmware%3A%3Ainframanager%3A%3Avm= string.
Inspecting the $evm.root object vm attribute contains the vm id.

Expected results:
Automation.log Instantiate line shows as above and does not contain the "manageiq%3A%3Aproviders%3A%3Avmware%3A%3Ainframanager%3A%3Avm= string.
Inspecting the $evm.root object vm attribute contains the vm object.

Comment 2 CFME Bot 2016-04-09 13:50:46 UTC

https://github.com/ManageIQ/manageiq/pull/7846

Comment 3 CFME Bot 2016-04-11 14:00:52 UTC

New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/a3803a66aef8ddac5fa3408692dac0d809a77845

commit a3803a66aef8ddac5fa3408692dac0d809a77845
Author:     william fitzgerald <wfitzger>
AuthorDate: Sat Apr 9 09:38:45 2016 -0400
Commit:     william fitzgerald <wfitzger>
CommitDate: Sat Apr 9 09:39:59 2016 -0400

    Automate - Vm reconfigure event passing invalid data.
    
    One line removed from Automate method.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1322101

 app/models/ems_event/automate.rb | 1 -
 1 file changed, 1 deletion(-)

Comment 4 Milan Falešník 2016-04-18 14:31:57 UTC

Verified in 5.6.0.2-beta2

Instantiating [/System/Process/Event?EventStream%3A%3Aevent_stream=6543&MiqEvent%3A%3Amiq_event=6543&MiqServer%3A%3Amiq_server=1&User%3A%3Auser=1&VmOrTemplate%3A%3Avm=450&ems_event=6534&event_stream_id=6543&event_type=vm_reconfigure&ext_management_systems=1&miq_event_id=6543&object_name=Event&vmdb_object_type=vm]

# cat log/automation.log | egrep inframanager
#

Comment 6 errata-xmlrpc 2016-06-29 15:45:51 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1348