Bug 1322197

Summary:	recent php-sabre-dav update broke Horde-DAV
Product:	[Fedora] Fedora	Reporter:	Solomon Peachy <pizza>
Component:	php-horde-Horde-Dav	Assignee:	Remi Collet <fedora>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	urgent	Docs Contact:
Priority:	unspecified
Version:	22	CC:	fedora
Target Milestone:	---
Target Release:	---
Hardware:	noarch
OS:	Linux
Whiteboard:
Fixed In Version:	php-horde-Horde-Dav-1.1.2-3.fc22 php-horde-Horde-Dav-1.1.2-3.fc23	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-04-07 15:48:29 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Solomon Peachy 2016-03-30 01:44:08 UTC

Description of problem:

A recent update of php-sabre-dav broke the Horde's DAV functionality.

Version-Release number of selected component (if applicable):

php-horde-Horde-Dav-1.1.2-1.fc22.noarch

To reproduce, hit the 'rpc.php' page on a horde installation:

With php-sabre-dav 2.1.6-1.fc22, it blows up:

[Tue Mar 29 20:16:04.185905 2016] [:error] [pid 14258] [client 2001:470:8:6c7:48
2f:7a5f:1be7:f037:38452] PHP Fatal error:  Declaration of Horde_Dav_Principals::
updatePrincipal() must be compatible with Sabre\\DAVACL\\PrincipalBackend\\Backe
ndInterface::updatePrincipal($path, Sabre\\DAV\\PropPatch $propPatch) in /usr/sh
are/pear/Horde/Dav/Principals.php on line 29

With php-sabre-dav-1.8.12-1.fc22, it works and prompts you for credentials.

This is a significant regression, but given that upstream stable Horde_Dav is still 1.1.2, this is probably an upstream problem.

Upstream unstable Horde_Dav 1.1.3 has supposedly been updated to work with sabre-dav 2.1.

(See https://github.com/horde/horde/commits/master/framework/Dav)

Comment 1 Remi Collet 2016-03-30 05:10:41 UTC

Thanks for the report, this is my fault, I forget to apply change done in F24+ in stable branch.

Update will come very soon.

Comment 2 Fedora Update System 2016-03-30 05:14:49 UTC

php-horde-Horde-Autoloader-2.1.2-1.fc23 php-horde-Horde-Dav-1.1.2-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-47211b863d

Comment 3 Fedora Update System 2016-03-30 05:14:55 UTC

php-horde-Horde-Autoloader-2.1.2-1.fc22 php-horde-Horde-Dav-1.1.2-3.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-14decc4b98

Comment 4 Solomon Peachy 2016-03-30 11:01:32 UTC

Thanks for the rapid turnaround!  I installed the updates, and Horde RPC now properly prompts me for credentials instead of going kaboom.

I added positive karma to bohdi.

Comment 5 Remi Collet 2016-03-30 11:14:29 UTC

Thanks for the feedback.

Comment 6 Fedora Update System 2016-03-30 22:22:16 UTC

php-horde-Horde-Autoloader-2.1.2-1.fc22, php-horde-Horde-Dav-1.1.2-3.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-14decc4b98

Comment 7 Fedora Update System 2016-03-30 22:55:16 UTC

php-horde-Horde-Autoloader-2.1.2-1.fc23, php-horde-Horde-Dav-1.1.2-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-47211b863d

Comment 8 Fedora Update System 2016-04-07 15:48:27 UTC

php-horde-Horde-Autoloader-2.1.2-1.fc22, php-horde-Horde-Dav-1.1.2-3.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2016-04-07 15:52:04 UTC

php-horde-Horde-Autoloader-2.1.2-1.fc23, php-horde-Horde-Dav-1.1.2-3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.