Bug 1322237

Summary:	glusterd pmap scan wastes time scanning for not relevant ports
Product:	[Community] GlusterFS	Reporter:	Raghavendra Talur <rtalur>
Component:	glusterd	Assignee:	Raghavendra Talur <rtalur>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, smohan
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-06-16 14:02:08 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Raghavendra Talur 2016-03-30 06:09:24 UTC

Description of problem:
We build table of available, non-available ports in glusterd pmap for all the ports from 0 to 65535. However, that is not required, as we would consume ports only from base_port to 65535.

Version-Release number of selected component (if applicable):
master/mainline


How reproducible:
Always

Comment 1 Vijay Bellur 2016-03-30 06:10:10 UTC

REVIEW: http://review.gluster.org/13841 (glusterd: scan for open ports only in required range) posted (#3) for review on master by Raghavendra Talur (rtalur)

Comment 2 Vijay Bellur 2016-03-30 19:44:27 UTC

COMMIT: http://review.gluster.org/13841 committed in master by Jeff Darcy (jdarcy) 
------
commit d5b583be1e677637015fabeaac81994f382f14bc
Author: Raghavendra Talur <rtalur>
Date:   Tue Mar 29 13:46:07 2016 +0530

    glusterd: scan for open ports only in required range
    
    It does not make sense to keep track of free ports from 0 to base_port
    if we are not going to use them.
    
    glusterd start times without this patch
    2.622
    2.478
    2.455
    2.590
    2.400
    
    glusterd start times with this patch
    1.9
    1.9
    1.9
    2.0
    2.0
    1.8
    
    We save around half a second for every glusterd start.
    
    BUG: 1322237
    Change-Id: I0456689d0afad50dd068f2325ebfca9bdeffe01a
    Signed-off-by: Raghavendra Talur <rtalur>
    Reviewed-on: http://review.gluster.org/13841
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: Jeff Darcy <jdarcy>

Comment 3 Niels de Vos 2016-06-16 14:02:08 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user