Bug 1322262

Summary:	Glusterd crashes when a message is passed through rpc which is not available
Product:	[Community] GlusterFS	Reporter:	hari gowtham <hgowtham>
Component:	glusterd	Assignee:	Mohammed Rafi KC <rkavunga>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, prasanna.kalever, rkavunga
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-06-16 14:02:08 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1395245

Description hari gowtham 2016-03-30 07:26:13 UTC

Description of problem:
if a service is not connected to glusterd because of some reason and by then if there is some message that has to be transferred through RPC, then the whole glusterd crashes as it rpc fails. 

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1.
2.
3.

Actual results:
Connection failed. Please check if gluster daemon is operational.

Expected results:
glusterd should throw error without crashing.

Additional info:

Comment 1 Vijay Bellur 2016-03-30 12:17:02 UTC

REVIEW: http://review.gluster.org/13854 (glusterd/suncop: double free of frame stack) posted (#1) for review on master by mohammed rafi  kc (rkavunga)

Comment 2 Vijay Bellur 2016-03-31 07:26:34 UTC

REVIEW: http://review.gluster.org/13854 (glusterd/syncop: double free of frame stack) posted (#2) for review on master by mohammed rafi  kc (rkavunga)

Comment 3 Vijay Bellur 2016-03-31 17:16:58 UTC

COMMIT: http://review.gluster.org/13854 committed in master by Jeff Darcy (jdarcy) 
------
commit 8dfbb6751b2f421fb179ecf6abf803fbe983350e
Author: Mohammed Rafi KC <rkavunga>
Date:   Wed Mar 30 17:42:44 2016 +0530

    glusterd/syncop: double free of frame stack
    
    If rpc message from glusterd during brick op phase
    fails without sending, then frame was freed from
    the caller function and call back function.
    
    Change-Id: I63cb3be30074e9a074f6895faa25b3d091f5b6a5
    BUG: 1322262
    Signed-off-by: Mohammed Rafi KC <rkavunga>
    Reviewed-on: http://review.gluster.org/13854
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Jeff Darcy <jdarcy>

Comment 4 Niels de Vos 2016-06-16 14:02:08 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user