Bug 1322281

Summary: Incorrect standalone-osgi.xml properties after installation
Product: [Retired] JBoss BPMS Platform 6 Reporter: Dominik Hanak <dhanak>
Component: InstallerAssignee: Miroslav Sochurek <msochure>
Status: CLOSED EOL QA Contact: Dominik Hanak <dhanak>
Severity: medium Docs Contact:
Priority: high    
Version: 6.3.0CC: lpetrovi, rrajasek, rzhang
Target Milestone: CR2   
Target Release: 6.3.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-03-27 20:01:47 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Dominik Hanak 2016-03-30 08:06:29 UTC
Description of problem:
There are incorrect system properties in standalone-osgi.xml after
installing while using "Disable OptaPlannerExecution Server" option.

Version-Release number of selected component (if applicable):
6.3.0.ER2

How reproducible:
always

Steps to Reproduce:
1. Run Installer
2. Tick "Disable OptaPlannerExecution Server" in Advanced config tab
3. Finish

Actual results:
System properties elemnt in osgi xml file looks like this:
<system-properties>
        <property name="org.kie.example" value="true"/>
        <property name="org.jbpm.designer.perspective" value="full"/>
        <property name="designerdataobjects" value="false"/>
</system-properties>
 
As you can see there are 2 properties missing. One is specific to 
"Disable OptaPlannerExecution Server" option, while the other is regarding
"org.kie.server.repo" and I am not quite sure if this should be here too.


Expected results:
Standalone-osgi.xml system properties element should contain same items that other configuration files do.

<system-properties>
        <property name="org.kie.server.repo" value="${jboss.server.data.dir}"/>
        <property name="org.optaplanner.server.ext.disabled" value="true"/>
        <property name="org.kie.example" value="true"/>
        <property name="org.jbpm.designer.perspective" value="full"/>
        <property name="designerdataobjects" value="false"/>
</system-properties>


Additional info:

Comment 2 Thomas Hauser 2016-04-04 18:28:20 UTC
Hi Dominik, 

I've adjusted the installer to modify standalone-osgi.xml to be modified in an identical way to the other standalone-*.xmls.

Comment 3 Dominik Hanak 2016-04-14 10:42:53 UTC
Hi Tom,

thanks for the fix. Tests now fails on domain configuration.

What about domain.xml and host.xml?
I have noticed that they 
include <system-properties> too and 
this option should therefore be there aswell.

Could you please confirm?
If that is true, this needs more fixing, since domain.xml and host.xml
servers should also have the option (disabled=true).

Let me know as soon as possible.

Thanks!

Dominik

Comment 4 Dominik Hanak 2016-04-18 08:58:51 UTC
Looks like this need to be fixed in domain.xml too.

Not sure about host.xml, but I think they use properties sepcified in 
domain.xml so i think it should be untouched.


Moving back to ASSIGNED so the property is included in "domain.xml" too.

Comment 5 Dominik Hanak 2016-04-20 08:24:01 UTC
I have noticed that fix for BPMS is already in rebuilt ER3.

Occurs only in BRMS now.

Comment 6 Thomas Hauser 2016-04-28 15:12:13 UTC
BRMS has had the fix applied as well.

Comment 7 Dominik Hanak 2016-05-03 08:51:46 UTC
Verified in 6.3.0.CR2.