Bug 1322406
Summary: | TestOnly: Backport recent pedit action fixes from upstream | ||
---|---|---|---|
Product: | Red Hat Enterprise Linux 7 | Reporter: | Phil Sutter <psutter> |
Component: | iproute | Assignee: | Andrea Claudi <aclaudi> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | BaseOS QE Security Team <qe-baseos-security> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 7.3 | CC: | aclaudi, atragler, jaster, mleitner, omoris, sukulkar, tredaelli |
Target Milestone: | rc | Keywords: | TestOnly |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | iproute-4.11.0-4.el7 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2020-03-02 17:14:53 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1435647 | ||
Bug Blocks: |
Description
Phil Sutter
2016-03-30 12:41:57 UTC
Re-adding devel_ack+ since I still think it should be fixed. Backported all the requested commits: commit ec0ceeec4954b1a5439ec3684460e8385454de90 commit f440e9d8c2f6f0eb2e9fccd8f4d7c42c11ba4979 commit 338b003bcc22a62c98b84dbe5e491cae84dbb03c commit 77bed404d03f39adf2842ee4aefb53ba8a68f087 commit a33786b582a29a940cfe1eff826ff5a0548a6d81 Plus one dependent commit: commit 0bbca0422f9779cc4eeaf70aa01dcad10d6ab076 Author: Maciej Żenczykowski <maze> Date: Thu Jun 25 02:03:02 2015 -0700 iproute2: tc/m_pedit.c - remove dead code The initializers are simply not needed. These if-blocks are outright dead code, because '0 > unsigned' is always false, so only else clause triggers and regardless of which clause triggers it only updates 'ind' which is later unconditionally written to before being used anyway. Otherwise we get errors from clang: m_pedit.c:166:8: error: comparison of 0 > unsigned expression is always false [-Werror,-Wtautological-compare] if (0 > tkey->off) { ~ ^ ~~~~~~~~~ m_pedit.c:209:8: error: comparison of 0 > unsigned expression is always false [-Werror,-Wtautological-compare] if (0 > tkey->off) { ~ ^ ~~~~~~~~~ 2 errors generated. Change-Id: I3c9e9092915088fc56f992e5df736851541a4458 Hi Dalibor, this ticket is a TestOnly one, which means no action required from devel side (apart from providing devel_ack+) but testing by QA is still missing. So whenever they get capacity for it, they should provide qa_ack+ and it will make it into the next errata and is tested for. Therefore we want to keep this ticket, otherwise the feature is there but we can't (officially) be sure it's working as intended. I'll anyway move this to rhel-7.8. |