Bug 1322470

Summary: For Register Nodes: can't edit and resubmit CSV file
Product: Red Hat Quickstart Cloud Installer Reporter: Thom Carlin <tcarlin>
Component: Installation - RHELOSPAssignee: cchase
Status: CLOSED ERRATA QA Contact: Thom Carlin <tcarlin>
Severity: medium Docs Contact: Dan Macpherson <dmacpher>
Priority: unspecified    
Version: 1.0CC: bthurber, jmatthew
Target Milestone: gaKeywords: Triaged
Target Release: 1.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-09-13 16:27:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Thom Carlin 2016-03-30 14:29:37 UTC
Description of problem:

For Register Nodes, editing CSV file after error does not allow resubmit of file.

Version-Release number of selected component (if applicable):

TP3 RC2

How reproducible:

100%

Steps to Reproduce:
1. Install QCI and QCIOOO-7 ISOs
2. Log in to run launch-fusor*-installer
3. Deploy RHELOSP
4. In Register Nodes, select CSV
5. Choose a CSV with errors.  In this case, the CSV file had comments (RFE elsewhere for that)
6. After error appears, edit CSV file externally
7. Try uploading CSV file again

Actual results:

Error messages still visible, can't proceed

Expected results:

Either allow re-upload OR force Cancel (disable "Choose File" and add message about Cancelling)

Additional info:

Workaround:
1) Select Cancel button
2) Register Node button (again)
3) Upload CSV (again)
4) Choose File (again)

This is more of a UX bz.

Comment 1 Thom Carlin 2016-06-28 18:05:43 UTC
Verified in QCI 1.2:

File with comments causes: "There were errors encountered while trying to parse the CSV file.

Row 1 Invalid row
Row 3 Invalid row
Row 5 Invalid row
Row 6, Column 5 "<<mac address>>" is not an available MAC address
Row 7 Invalid row
Row 9 Invalid row

Resubmitting the same CSV twice: "There were errors encountered while trying to parse the CSV file.

Row 1, Column 5 "<<mac_address>>" is not an available MAC address
Row 2, Column 5 "<<mac_address>>" is not an available MAC address

This resolution also is nice!

Comment 7 errata-xmlrpc 2016-09-13 16:27:34 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2016:1862