Bug 1322471
| Summary: | git-review: Provide a Python 3 subpackage | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tomas Orsava <torsava> | ||||||||
| Component: | git-review | Assignee: | Pete Zaitcev <zaitcev> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | unspecified | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | 25 | CC: | dkrejci, lbalhar, mordred, pronix.service, zaitcev | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | git-review-1.25.0-4.fc26 git-review-1.25.0-4.fc25 | Doc Type: | Bug Fix | ||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2016-10-09 02:52:55 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | |||||||||||
| Bug Blocks: | 1285816, 1312032 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Tomas Orsava
2016-03-30 14:30:28 UTC
I tried to support py3 when F24 branched. It kinda works, but is full of bugs. Mostly things like b'' around everything printed. I'll have another look later. Thank you for taking the time, hopefully upstream had time to iron it out a little bit. And if you find bugs don't hesitate to report them upstream. Created attachment 1180227 [details] move-to-python3.patch hello if i correct understand https://communityblog.fedoraproject.org/port-python-package/ patch should be good thanks for any feedback. Created attachment 1180247 [details]
i changed patch for support build python2 on nonfedora OS.
i changed patch for support build python2 on nonfedora OS.
This bug appears to have been reported against 'rawhide' during the Fedora 25 development cycle. Changing version to '25'. Hello.
This patch looks good but needs to be rebased. I have just few suggestions:
- Is better to be more specific in BuildRequires/Requires - for example python2-devel instead python-devel (where applicable)
- Same for macros - %{__python2} instead %{__python}, %{python2_sitelib} instead %{python_sitelib}
Also, please consider if is possible to package both versions (for python2 and python3) in the same time as subpackages.
Hello. I am still not sure if we should package this software as 'application with module' in one package - in this case for both python versions; or only as application and only for Python 3. I think that git-review is useless as Python module so I vote for package it as application only and only for Python 3. I sent a question about this to the biggest contributor of upstream of this project. If maintainer has enough knowledge to make a decision, it would be very appreciated. Thanks for your help. I do not believe git-review is useful as a module, so treating it as python3-only seems like a fine choice. Created attachment 1198105 [details]
Modernized specfile and Python 3 support for Fedora
Hello.
Based on the last comment from the upstream developer I am providing the new patch for specfile.
This patch moves git-review to Python 3 in Fedora.
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15513621 Hi Lumír, the patch looks good to me. If maintainer has nothing against, we can push this after a week. Thanks for the help, and I'm sorry not to look into this. Unfortunatley, I am going out of town for a week. Be back on 9/14 and fist thing do this unless a proven packager does. OTL Built git-review-1.25.0-4.fc26 with Lumir's patch. Hello, Pete. Could you please also make an update for F25? Thank you very much. Lumir Lumir, please see https://bodhi.fedoraproject.org/updates/git-review-1.25.0-4.fc25 git-review-1.25.0-4.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-4fb06d2fa8 git-review-1.25.0-4.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. |