Bug 1322788
Summary: | The IMAGE_VERSION wasn't added to atomic-openshift-master-api and atomic-openshift-master-controllers | ||||||
---|---|---|---|---|---|---|---|
Product: | OpenShift Container Platform | Reporter: | Anping Li <anli> | ||||
Component: | Cluster Version Operator | Assignee: | Brenton Leanhardt <bleanhar> | ||||
Status: | CLOSED ERRATA | QA Contact: | Anping Li <anli> | ||||
Severity: | high | Docs Contact: | |||||
Priority: | high | ||||||
Version: | 3.2.0 | CC: | anli, aos-bugs, bleanhar, jokerman, mmccomas, tdawson | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Whiteboard: | |||||||
Fixed In Version: | openshift-ansible-3.0.79-1.git.0.9c75f11.el7 | Doc Type: | Bug Fix | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2016-05-12 16:35:16 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Anping Li
2016-03-31 10:45:17 UTC
Brenton, Blocked by bug https://bugzilla.redhat.com/show_bug.cgi?id=1323057#c1 After add OSE3.2 repos, I can continue to upgrade. and I get this error 'https://bugzilla.redhat.com/show_bug.cgi?id=1322788'. since there are still no IMAGE_VERSION for /etc/sysconfig/atomic-openshift-master*. Maybe it is the root cause for bug 1322788. Hi Anping, I'll retest this one today. Seriously, you are catching some really good bugs. The pull request has not merged. Marking this back on assigned. Upgrade still failed, the IMAGE_VERSION=v ls /etc/sysconfig/atomic-openshift-* openvswitch |xargs grep IMAGE_VERSION /etc/sysconfig/atomic-openshift-master:IMAGE_VERSION=v /etc/sysconfig/atomic-openshift-master-api:IMAGE_VERSION=v /etc/sysconfig/atomic-openshift-master-controllers:IMAGE_VERSION=v /etc/sysconfig/atomic-openshift-node:IMAGE_VERSION=v openvswitch:IMAGE_VERSION=v Created attachment 1144531 [details]
The IMAGE_VERSION=v logs
Note that: In comment 9, the root cases of the failure wasn't IMAGE_VERSION. But I observed that the playbook can't to find the current image version. the version was set to v at that point. Could you provide the inventory file you used? Looking in the logs I can see that docker-1.8.2-8 is being downgraded to docker-1.8.2-7. This should never happen. I suspect it's due to the missing ".stdout". I'm working on a PR to fix this: https://github.com/brenton/openshift-ansible/blob/docker1/roles/docker/tasks/main.yml#L13 Previously the downgrade was happening in many cases where it shouldn't. I think that's what broke you upgrade. If something goes wrong with docker I could easily see the IMAGE_VERSION being set wrong since we rely on docker for that to work. One thing I'm noticing in docker 1.8.2 is that you cannot use --add-registry for a registry in which you are not logged in. This was breaking my dev environment because I tend to have the QE registry always enabled. I simply would logout before running the 3.1 install to ensure I pulled GA images. I think with docker 1.8.2 we have to make sure all the registries passed to --add-registry have the images we're intending to use. If the atomic-openshift container wasn't running, openshift_container_versions.sh will set correct curr_version to "". In this case, after docker downgrade, the docker service was restarted,and those atomic-openshift* were restarted too. Due to there are latest images, it need time to download images and start atomic-openshift* containers, or the container may failed to restarted. which cause the openshift_container_versions.sh failed to get the correct curr_version. After downgrade docker to 1.8.2-7.el7 (Docker was downgraded to the lowest version, so no downgrade occur). ansible can got the correct curr_version. Could we run openshift_container_versions.sh immediately after "Ensure Node/MASTER is running"? The new scripts works well, so move to verified. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2016:1064 |