Bug 1322933
| Summary: | VDSM doesn't disconnect multiple iSCSI sessions | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [oVirt] vdsm | Reporter: | Pavel Gashev <pax> | ||||
| Component: | Core | Assignee: | Vojtech Juranek <vjuranek> | ||||
| Status: | CLOSED DEFERRED | QA Contact: | Avihai <aefrat> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 4.17.23 | CC: | bugs, frolland, mlehrer, nsoffer, tnisan | ||||
| Target Milestone: | --- | Flags: | frolland:
needinfo-
rule-engine: ovirt-4.3+ sbonazzo: ovirt-4.5? rule-engine: exception+ rule-engine: planning_ack+ tnisan: devel_ack+ acanan: testing_ack+ |
||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2020-04-01 14:46:56 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | Storage | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Moving from 4.0 alpha to 4.0 beta since 4.0 alpha has been already released and bug is not ON_QA. Nir - is this going to make it to 4.0? (In reply to Yaniv Kaul from comment #2) > Nir - is this going to make it to 4.0? I'm waiting to networking folks to approve this. oVirt 4.0 beta has been released, moving to RC milestone. oVirt 4.0 beta has been released, moving to RC milestone. This bug has not been marked as blocker for oVirt 4.3.0. Since we are releasing it tomorrow, January 29th, this bug has been re-targeted to 4.3.1. I think we need to test how node.session.nr_sessions affects performance. If this give significant improvement, we need to support this configuration in engine or in vdsm configuration. If the system is configured to use multiple sessions, vdsm should disconnect multiple sessions. We also have to test how this plays with managed volumes. We don't want vdsm to disconnect sessions created by ManagedVolume.attach_volume(). Mordechay, can we test the affect of multiple sessions on performance? Patch is abandoned, moving back to new until we decide on the course of action here We didn't get to this bug for more than 2 years, and it's not being considered for the upcoming 4.4. It's unlikely that it will ever be addressed so I'm suggesting to close it. If you feel this needs to be addressed and want to work on it please remove cond nack and target accordingly. Closing old bug. Please reopen if still relevant/you want to work on it. |
Created attachment 1142313 [details] the fix If I increase node.session.nr_sessions in /etc/iscsi/iscsid.conf VDSM can establish multiple iSCSI sessions per iSCSI target over the same iface. Unfortunately VDSM doesn't disconnect all established sessions. Maintenance mode disconnects the first connected session only. Other sessions remain connected. Please find attached a patch to fix the bug.