Bug 1323220

Summary:	[migration 3.6 EL6 - 3.6 EL7] Failed to execute stage 'Closing up': Failed to start service 'httpd'
Product:	[oVirt] ovirt-engine	Reporter:	Jiri Belka <jbelka>
Component:	Setup.Engine	Assignee:	Sandro Bonazzola <sbonazzo>
Status:	CLOSED DUPLICATE	QA Contact:	Pavel Stehlik <pstehlik>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	3.6.5	CC:	bugs, didi
Target Milestone:	---	Flags:	rule-engine: planning_ack? rule-engine: devel_ack? rule-engine: testing_ack?
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-04-07 05:45:36 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Integration	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jiri Belka 2016-04-01 14:57:51 UTC

Description of problem:

after migration from 3.6 el6 -> 3.6 el7 which contained backup, installation of clean EL7, restore of data, engine-setup finishes with error as it could not start httpd.

-- Unit httpd.service has begun starting up.
Apr 01 14:14:17 10-34-60-167.rhev.lab.eng.brq.redhat.com httpd[24847]: [Fri Apr 01 14:14:17.653911 2016] [so:warn] [pid 24847] AH01574: module ssl_module is already loaded, skipping
Apr 01 14:14:17 10-34-60-167.rhev.lab.eng.brq.redhat.com httpd[24847]: AH00526: Syntax error on line 42 of /etc/httpd/conf.d/ssl.conf:
Apr 01 14:14:17 10-34-60-167.rhev.lab.eng.brq.redhat.com httpd[24847]: Invalid command 'SSLMutex', perhaps misspelled or defined by a module not included in the server configuration
Apr 01 14:14:17 10-34-60-167.rhev.lab.eng.brq.redhat.com systemd[1]: httpd.service: main process exited, code=exited, status=1/FAILURE
Apr 01 14:14:17 10-34-60-167.rhev.lab.eng.brq.redhat.com kill[24861]: kill: cannot find process ""
Apr 01 14:14:17 10-34-60-167.rhev.lab.eng.brq.redhat.com systemd[1]: httpd.service: control process exited, code=exited status=1
Apr 01 14:14:17 10-34-60-167.rhev.lab.eng.brq.redhat.com systemd[1]: Failed to start The Apache HTTP Server.
-- Subject: Unit httpd.service has failed

The problem is that 'SSLMutex' appears in /etc/httpd/conf.d/ssl.conf which got restored from backup and engine-setup did not handle obsoleteness of this value while being executed on EL7.

# tar -xOzvf backup.tar.gz ./files | tar -tJvf - | grep /ssl.conf
./files
-rw-r--r-- root/root                       9651 2016-03-23 12:32 etc/httpd/conf.d/ssl.conf

IMO engine-setup should known it is being run as part of migration and/or should care if his config files (ie. ssl.conf) is valid. Complex but maybe worth of thinking about it.

Version-Release number of selected component (if applicable):
ovirt-engine-setup-base-3.6.4.1-1.el7.centos.noarch

backup done on ovirt-engine-3.6.3.4-1.el6.noarch

How reproducible:
100%

Steps to Reproduce:
1. engine 3.6 on EL6, make backup
2. clean EL7 with engine 3.6 rpms
3. restore
4. engine-setup

Actual results:
Failed to execute stage 'Closing up': Failed to start service 'httpd'

because of deprecated option in ssl.conf which was restored

Expected results:
engine-setup should handle that

Additional info:

Comment 2 Jiri Belka 2016-04-01 15:02:38 UTC

commenting out SSLMutex line in ssl.conf makes httpd start

hm, engine-backup in restore mode just blindly replace this ssl.conf...

Comment 3 Yedidyah Bar David 2016-04-07 05:45:36 UTC

Thanks for the report.

Closing as duplicate of bug 1318580. The currently pending patch for it also addresses this one.

*** This bug has been marked as a duplicate of bug 1318580 ***