Bug 1323227

Summary:	Review Request: parmetis - Parallel Graph Partitioning and Sparse Matrix Ordering library
Product:	[Fedora] Fedora	Reporter:	Antonio T. (sagitter) <anto.trande>
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED UPSTREAM	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	manisandro, package-review, zbyszek
Target Milestone:	---	Flags:	zbyszek: fedora-review-
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-04-01 16:40:02 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Antonio T. (sagitter) 2016-04-01 15:22:17 UTC

Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/sagitter/Ipopt-EPEL/parmetis.git/plain/parmetis.spec

SRPM URL: https://copr-be.cloud.fedoraproject.org/results/sagitter/Ipopt-EPEL/fedora-rawhide-x86_64/00172454-parmetis/parmetis-4.0.3-1.fc25.src.rpm

Description: 
PARMETIS is an MPI-based parallel library that implements a variety of algorithms for partitioning and repartitioning
unstructured graphs and for computing fill-reducing orderings of sparse matrices. PARMETIS is particularly suited for
parallel numerical simulations involving large unstructured meshes. In this type of computation, PARMETIS dramati-
cally reduces the time spent in communication by computing mesh decompositions such that the numbers of interface
elements are minimized.
The algorithms in PARMETIS are based on the multilevel partitioning and fill-reducing ordering algorithms that are
implemented in the widely-used serial package METIS. However, PARMETIS extends the functionality provided by
METIS and includes routines that are especially suited for parallel computations and large-scale numerical simulations.
In particular, PARMETIS provides the following functionality:

 • Partition unstructured graphs and meshes.
 • Repartition graphs that correspond to adaptively refined meshes.
 • Partition graphs for multi-phase and multi-physics simulations.
 • Improve the quality of existing partitionings.
 • Compute fill-reducing orderings for sparse direct factorization.
 • Construct the dual graphs of meshes


Fedora Account System Username: sagitter

Notes.
- This package is for EPEL6/7 and Fedora.

- Althought ParMetis provides Metis source, it has been patched to use the 'metis' library already packaged on Fedora.

- In this package I tried to compile ParMetis with 64-bit integers (against Metis64), however I can't complete all related tests which look exhaust all memory. Needs investigation.

Comment 1 Zbigniew Jędrzejewski-Szmek 2016-04-01 16:09:50 UTC

%description should be wrapped to 80 columns.

Suggestion:
%global _description \
PARMETIS is ... \
...

%description %_description

%description openmpi %_description

(This form gets the spacing right.)

Likewise for the cmake flags, please define a macro for the common stuff. This will make it easier to see what flags are different between the four compilations.

Group can be dropped (not required for EPEL6+ or Fedora).

Looks good. I'm building it now, and will continue the review when that's done.

Comment 2 Sandro Mani 2016-04-01 16:14:56 UTC

Parmetis is non-free:

Copyright & License Notice
--------------------------

The ParMETIS package is copyrighted by the Regents of the 
University of Minnesota. It can be freely used for educational and 
research purposes by non-profit institutions and US government 
agencies only. Other organizations are allowed to use ParMETIS 
only for evaluation purposes, and any further uses will require prior 
approval. The software may not be sold or redistributed without prior 
approval. One may make copies of the software for their use provided 
that the copies, are not sold or distributed, are used under the same 
terms and conditions.

As unestablished research software, this code is provided on an 
``as is'' basis without warranty of any kind, either expressed or
implied. The downloading, or executing any part of this software
constitutes an implicit agreement to these terms. These terms and
conditions are subject to change at any time without prior notice.



(Note though that a compatibility header is provided in ptscotch-mpich-devel-parmetis, ptscotch-openmpi-devel-parmetis)

Comment 3 Antonio T. (sagitter) 2016-04-01 16:29:42 UTC

(In reply to Sandro Mani from comment #2)
> Parmetis is non-free:
> 
> Copyright & License Notice
> --------------------------
> 
> The ParMETIS package is copyrighted by the Regents of the 
> University of Minnesota. It can be freely used for educational and 
> research purposes by non-profit institutions and US government 
> agencies only. Other organizations are allowed to use ParMETIS 
> only for evaluation purposes, and any further uses will require prior 
> approval. The software may not be sold or redistributed without prior 
> approval. One may make copies of the software for their use provided 
> that the copies, are not sold or distributed, are used under the same 
> terms and conditions.
> 
> As unestablished research software, this code is provided on an 
> ``as is'' basis without warranty of any kind, either expressed or
> implied. The downloading, or executing any part of this software
> constitutes an implicit agreement to these terms. These terms and
> conditions are subject to change at any time without prior notice.
> 
> 
> 
> (Note though that a compatibility header is provided in
> ptscotch-mpich-devel-parmetis, ptscotch-openmpi-devel-parmetis)

I considered valid like that of Metis. My bad.
Maybe we can talk about with upstream.

Comment 4 Zbigniew Jędrzejewski-Szmek 2016-04-01 16:40:02 UTC

Yep. Please talk with upstream.