Bug 1323346

Summary:	rhel-osp-director: "openstack overcloud upgrade prepare doesn't update the OC nodes with repos.
Product:	Red Hat OpenStack	Reporter:	Alexander Chuzhoy <sasha>
Component:	python-tripleoclient	Assignee:	Brad P. Crochet <brad>
Status:	CLOSED WONTFIX	QA Contact:	Arik Chernetsky <achernet>
Severity:	unspecified	Docs Contact:
Priority:	urgent
Version:	8.0 (Liberty)	CC:	dbecker, hbrock, jcoufal, jslagle, mburns, morazi, rhel-osp-director-maint
Target Milestone:	---
Target Release:	10.0 (Newton)
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-10-14 21:14:02 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Alexander Chuzhoy 2016-04-02 00:33:32 UTC

rhel-osp-director: "openstack overcloud upgrade  prepare" completes too fast. Doesn't update the OC nodes with repos.

Environment:
openstack-puppet-modules-7.0.17-1.el7ost.noarch                           openstack-tripleo-heat-templates-0.8.14-5.el7ost.noarch
openstack-tripleo-heat-templates-kilo-0.8.14-5.el7ost.noarch 
instack-undercloud-2.2.7-2.el7ost.noarch 



Steps to reproduce:
1. deploy overcloud 7.3
2. upgrade the undercloud to 8.0
3. Run: 
openstack overcloud upgrade  prepare --stack overcloud --templates -e    /usr/share/openstack-tripleo-heat-templates/overcloud-resource-registry-puppet.yaml   -e   /usr/share/openstack-tripleo-heat-templates/environments/puppet-pacemaker.yaml   -e /usr/share/openstack-tripleo-heat-templates/environments/network-isolation.yaml   -e   /usr/share/openstack-tripleo-heat-templates/environments/net-single-nic-with-vlans.yaml -e /usr/share/openstack-tripleo-heat-templates/environments/storage-environment.yaml  -e /home/stack/network-environment.yaml -e rhos-release-8.yaml -e new-passwords.yaml


Result:
The command exists shortly after that with prompt:
stack overcloud status: COMPLETE
Running after some time "heat stack-list" also shows "Update Complete".
Checking the OC nodes - the yum repo list is empty.


Expected result:
The "openstack overcloud upgrade  prepare" command should complete all its tasks before prompting "Complete".

Comment 3 Mike Burns 2016-04-03 11:01:48 UTC

Changing title slightly.  The issue where it completes too fast is captured in bug 1323329 (upgrade command not polling for results).  The testing here did seem to indicate that the test waited for the stack update to complete before checking for the new repos, so this is likely a real issue separate from the missing polling.

Comment 4 Jaromir Coufal 2016-04-04 10:54:07 UTC

Dropping the upgrade CLI command from OSP8, fallback to "deploy" command, unblocking

Comment 5 Mike Burns 2016-04-07 21:36:02 UTC

This bug did not make the OSP 8.0 release.  It is being deferred to OSP 10.

Comment 6 Brad P. Crochet 2016-10-14 21:14:02 UTC

The upgrade commands were removed entirely. The deploy command is to continue to be used for that workflow.