Bug 1323442

Summary: Review Request: xtreemfs - distributed file system
Product: [Fedora] Fedora Reporter: Yaozhong Ge <neilgechn>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: package-review, puntogil
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-05-10 08:16:16 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 177841, 1010003    

Description Yaozhong Ge 2016-04-03 04:28:39 UTC
Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/nrechn/XtreemFS/xtreemfs.git/plain/xtreemfs.spec?h=f23
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/nrechn/XtreemFS/fedora-23-x86_64/00172948-xtreemfs/xtreemfs-1.5.1-1.src.rpm
Koji build URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=13545383
Description: XtreemFS is a distributed and replicated file system for the internet. For more details, visit www.xtreemfs.org.
Fedora Account System Username: nrechn
This is my first package and I am seeking a sponsor.
I saw this package information in the package maintainers wishlist. The spec file is based on upstream rpm source package for fedora. I modified it in order to let it works with build system fedora uses.

Comment 2 gil cattaneo 2016-04-04 03:18:10 UTC
Hi
there are more prebuilt libraries, and they must be removed
using:
find . -name "*.class" -delete
find . -name "*.jar" -delete
must be removed also:
BuildRoot:      %{_tmppath}/%{name}-%{version}-build
field Group
%defattr(-,root,root,-)
You must use make %{?_smp_mflags} instead of make %{?jobs:-j%jobs}
You must use %license macro for LICENSE file
You must use rpm macros instead of hardcoding the directories e.g. %{_javadir}/XtreemFS.jar
You must use:
Requires:       java-headless instead of Requires:       jre >= 1.6.0
or add a/some comment/s, in the spec file, why is necessary jre
You must use: License:        BSD instead of License:        BSD-3-Clause

Comment 3 gil cattaneo 2016-04-04 03:28:10 UTC
Other problem:
You must use:
Source0:        http://www.xtreemfs.org/downloads/XtreemFS-%{version}.tar.gz
or
Source0:        https://github.com/xtreemfs/xtreemfs/archive/%{version}.tar.gz

instead of Source0:        XtreemFS-%{version}.tar.gz

Comment 4 Yaozhong Ge 2016-04-04 14:11:22 UTC
(In reply to gil cattaneo from comment #2)
> Hi
> there are more prebuilt libraries, and they must be removed
> using:
> find . -name "*.class" -delete
> find . -name "*.jar" -delete
> must be removed also:
> BuildRoot:      %{_tmppath}/%{name}-%{version}-build
> field Group
> %defattr(-,root,root,-)
> You must use make %{?_smp_mflags} instead of make %{?jobs:-j%jobs}
> You must use %license macro for LICENSE file
> You must use rpm macros instead of hardcoding the directories e.g.
> %{_javadir}/XtreemFS.jar
> You must use:
> Requires:       java-headless instead of Requires:       jre >= 1.6.0
> or add a/some comment/s, in the spec file, why is necessary jre
> You must use: License:        BSD instead of License:        BSD-3-Clause

Thanks your comments.

I tried to fix these problems in the spec file. Everything works except removing "*.jar" prebuilt libraries. There are 11 prebuilt libraries in the source package. Most of them can be found in the packages which are currently available in Fedora. Two of them have source available in Github which is fine as they can be contained as "Source1". 

However, there are still two prebuilt libraries ("jdmkrt.jar" and "jdmktk.jar") necessary during package builing but cannot be compiled from source."jdmkrt.jar" and "jdmktk.jar" comes from OpenDMK. They are necessary to provide SNMP support for status monitor in XtreemFS. And they can't be build from sources without sourceless "binary plug" which is non-free and unmaintained since 2007. (issue is still open on Github: https://github.com/xtreemfs/xtreemfs/issues/309)

I am afraid if I make "jdmkrt.jar" and "jdmktk.jar" be compiled during building package, it may against the Fedora Packaging Guidelines. I spent 11 hours trying to separate SNMP support from XtreemFS in order to let this package following Fedora Packaging Guidelines. Unfortunately, I am not familiar with java and I can't make it be possible.

Comment 5 Yaozhong Ge 2016-04-04 14:18:09 UTC
What should I do now? I am new to packager, and I really have no idea how to break this situation or solve this problem.

Comment 6 gil cattaneo 2016-04-04 14:38:39 UTC
(In reply to Yaozhong Ge from comment #5)
> What should I do now? I am new to packager, and I really have no idea how to
> break this situation or solve this problem.

If for you is not possible remove SNMP/OpenDMK support, and this make not usable this package, then close this bug. Otherwise, you can contact the "folks" in the #fedora-java or in the #fedora-bigdata IRC channel/s, to look for some volunteer to give you help.

Comment 7 gil cattaneo 2016-04-05 08:32:40 UTC
You can not review your own package