Bug 1323564

REVIEW: http://review.gluster.org/13896 (glusterd: Allocate fresh port on brick (re)start) posted (#1) for review on release-3.7 by Atin Mukherjee (amukherj)

REVIEW: http://review.gluster.org/14117 (glusterd: try to connect on GF_PMAP_PORT_FOREIGN aswell) posted (#1) for review on release-3.7 by Prasanna Kumar Kalever (pkalever)

REVIEW: http://review.gluster.org/14117 (glusterd: try to connect on GF_PMAP_PORT_FOREIGN aswell) posted (#2) for review on release-3.7 by Prasanna Kumar Kalever (pkalever)

COMMIT: http://review.gluster.org/14117 committed in release-3.7 by Atin Mukherjee (amukherj) 
------
commit dc6178714cd84d3de894d0972c20950b59d30017
Author: Prasanna Kumar Kalever <prasanna.kalever>
Date:   Sun May 1 13:53:47 2016 +0530

    glusterd: try to connect on GF_PMAP_PORT_FOREIGN aswell
    
    This patch fix couple of things mentioned below:
    
    1. previously we use to try to connect on only GF_PMAP_PORT_FREE
    in the pmap_registry_alloc(), it could happen that some foreign process
    would have freed the port by this time ?, hence it is worth giving a try on
    GF_PMAP_PORT_FOREIGN ports as well instead of wasting them all.
    
    2. fix pmap_registry_remove() to mark the port asGF_PMAP_PORT_FREE
    
    3. added useful comments on gf_pmap_port_type enum members
    
    Backport of:
    > Change-Id: Id2aa7ad55e76ae3fdece21bed15792525ae33fe1
    > BUG: 1322805
    > Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever>
    > Reviewed-on: http://review.gluster.org/14080
    > Tested-by: Prasanna Kumar Kalever <pkalever>
    > Smoke: Gluster Build System <jenkins.com>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.com>
    > Reviewed-by: Atin Mukherjee <amukherj>
    
    Change-Id: Ib7852aa1c55611e81c78341aace4d374d516f439
    BUG: 1323564
    Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever>
    Reviewed-on: http://review.gluster.org/14117
    Tested-by: Prasanna Kumar Kalever <pkalever>
    Smoke: Gluster Build System <jenkins.com>
    CentOS-regression: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Atin Mukherjee <amukherj>

REVIEW: http://review.gluster.org/14205 (rpc: define client port range) posted (#1) for review on release-3.7 by Prasanna Kumar Kalever (pkalever)

REVIEW: http://review.gluster.org/14208 (glusterd: add defence mechanism to avoid brick port clashes) posted (#1) for review on release-3.7 by Prasanna Kumar Kalever (pkalever)

COMMIT: http://review.gluster.org/14208 committed in release-3.7 by Raghavendra G (rgowdapp) 
------
commit f9c59e29ccd770ae212da76b5e6f6ce3d8d09e61
Author: Prasanna Kumar Kalever <prasanna.kalever>
Date:   Wed Apr 27 19:12:19 2016 +0530

    glusterd: add defence mechanism to avoid brick port clashes
    
    Intro:
    Currently glusterd maintain the portmap registry which contains ports that
    are free to use between 49152 - 65535, this registry is initialized
    once, and updated accordingly as an then when glusterd sees they are been
    used.
    
    Glusterd first checks for a port within the portmap registry and gets a FREE
    port marked in it, then checks if that port is currently free using a connect()
    function then passes it to brick process which have to bind on it.
    
    Problem:
    We see that there is a time gap between glusterd checking the port with
    connect() and brick process actually binding on it. In this time gap it could
    be so possible that any process would have occupied this port because of which
    brick will fail to bind and exit.
    
    Case 1:
    To avoid the gluster client process occupying the port supplied by glusterd :
    
    we have separated the client port map range with brick port map range more @
    http://review.gluster.org/#/c/13998/
    
    Case 2: (Handled by this patch)
    To avoid the other foreign process occupying the port supplied by glusterd :
    
    To handle above situation this patch implements a mechanism to return EADDRINUSE
    error code to glusterd, upon which a new port is allocated and try to restart
    the brick process with the newly allocated port.
    
    Note: Incase of glusterd restarts i.e. runner_run_nowait() there is no way to
    handle Case 2, becuase runner_run_nowait() will not wait to get the return/exit
    code of the executed command (brick process). Hence as of now in such case,
    we cannot know with what error the brick has failed to connect.
    
    This patch also fix the runner_end() to perform some cleanup w.r.t
    return values.
    
    Backport of:
    > Change-Id: Iec52e7f5d87ce938d173f8ef16aa77fd573f2c5e
    > BUG: 1322805
    > Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever>
    > Reviewed-on: http://review.gluster.org/14043
    > Tested-by: Prasanna Kumar Kalever <pkalever>
    > Reviewed-by: Atin Mukherjee <amukherj>
    > Smoke: Gluster Build System <jenkins.com>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.com>
    > Reviewed-by: Raghavendra G <rgowdapp>
    > Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever>
    
    Change-Id: Ief247b4d4538c1ca03e73aa31beb5fa99853afd6
    BUG: 1323564
    Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever>
    Reviewed-on: http://review.gluster.org/14208
    Tested-by: Prasanna Kumar Kalever <pkalever>
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra G <rgowdapp>

COMMIT: http://review.gluster.org/14205 committed in release-3.7 by Raghavendra G (rgowdapp) 
------
commit 0b7631b44b829f44c2ebb3a2f2d01d97987e1fd7
Author: Prasanna Kumar Kalever <prasanna.kalever>
Date:   Wed May 4 13:25:06 2016 +0530

    rpc: define client port range
    
    Problem:
    when bind-insecure is 'off', all the clients bind to secure ports,
    if incase all the secure ports exhaust the client will no more bind
    to secure ports and tries gets a random port which is obviously insecure.
    
    we have seen the client obtaining a port number in the range 49152-65535
    which are actually reserved as part of glusterd's pmap_registry for bricks,
    hence this will lead to port clashes between client and brick processes.
    
    Solution:
    If we can define different port ranges for clients incase where secure ports
    exhaust, we can avoid the maximum port clashes with in gluster processes.
    
    Still we are prone to have clashes with other non-gluster processes, but
    the chances being very low, but that's a different story on its own, which
    will be handled in upcoming patches.
    
    > Change-Id: Ib5ce05991aa1290ccb17f6f04ffd65caf411feaf
    > BUG: 1322805
    > Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever>
    > Reviewed-on: http://review.gluster.org/13998
    > Smoke: Gluster Build System <jenkins.com>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.com>
    > Reviewed-by: Atin Mukherjee <amukherj>
    > Reviewed-by: Raghavendra G <rgowdapp>
    > Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever>
    
    Change-Id: I712676d3e79145d78a17f2c361525e6ef82a4732
    BUG: 1323564
    Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever>
    Reviewed-on: http://review.gluster.org/14205
    Tested-by: Prasanna Kumar Kalever <pkalever>
    Smoke: Gluster Build System <jenkins.com>
    CentOS-regression: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Raghavendra G <rgowdapp>

List of patches which address this bug:

http://review.gluster.org/14205
http://review.gluster.org/14208
http://review.gluster.org/14117

these patches were already modified in the code repository.

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.12, please open a new bug report.

glusterfs-3.7.12 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-devel/2016-June/049918.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user