Bug 1323692

Summary:	rpmspectool does not respect umask
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	rpmspectool	Assignee:	Nils Philippsen <nphilipp>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	nphilipp
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	rpmspectool-1.99.5-1.fc24 rpmspectool-1.99.5-1.fc23 rpmspectool-1.99.5-1.fc22	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-04-20 15:26:00 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Petr Pisar 2016-04-04 12:51:06 UTC

I have rpmspectool-1.99.4-1.fc23.noarch and downloading source files creates files are not world-readable:

$ umask
0022

$ rpmspectool get perl-Clownfish.spec 
Downloading 'http://www.cpan.org/authors/id/N/NW/NWELLNHOF/Clownfish-0.5.0.tar.gz' to '/home/petr/fedora/perl-Clownfish/Clownfish-0.5.0.tar.gz'

$ ls -l Clownfish-0.5.0.tar.gz 
-rw-------. 1 petr petr 217904  4. dub 11.39 Clownfish-0.5.0.tar.gz

I think it should respect umask. I don't think the publicly available archives are secret enough to require special permissions.

Comment 1 Nils Philippsen 2016-04-08 09:05:03 UTC

fixed upstream:

https://github.com/nphilipp/rpmspectool/commit/10da7c0be9713102571e2d8b27619d36a41b4863
https://github.com/nphilipp/rpmspectool/commit/ce0fb0f84f26ff20a2e1ff52437457b80d7077e4

Comment 2 Fedora Update System 2016-04-08 10:03:22 UTC

rpmspectool-1.99.5-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d5b50bc93a

Comment 3 Fedora Update System 2016-04-08 10:03:29 UTC

rpmspectool-1.99.5-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-0abfa80249

Comment 4 Fedora Update System 2016-04-08 10:03:33 UTC

rpmspectool-1.99.5-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-559f1f9371

Comment 5 Fedora Update System 2016-04-08 16:51:14 UTC

rpmspectool-1.99.5-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-0abfa80249

Comment 6 Fedora Update System 2016-04-08 20:50:00 UTC

rpmspectool-1.99.5-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d5b50bc93a

Comment 7 Fedora Update System 2016-04-08 20:53:55 UTC

rpmspectool-1.99.5-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-559f1f9371

Comment 8 Fedora Update System 2016-04-20 15:25:57 UTC

rpmspectool-1.99.5-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2016-04-20 19:22:20 UTC

rpmspectool-1.99.5-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2016-04-22 01:50:32 UTC

rpmspectool-1.99.5-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.