| Summary: | [RFE] update bootstrap, gwtbootstrap3, and patternfly to latest versions | ||
|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | Greg Sheremeta <gshereme> |
| Component: | Frontend.Core | Assignee: | Greg Sheremeta <gshereme> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Pavel Novotny <pnovotny> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 4.0.0 | CC: | bugs, gshereme, lsvaty, oourfali |
| Target Milestone: | ovirt-4.2.0 | Keywords: | CodeChange, FutureFeature |
| Target Release: | 4.2.0 | Flags: | oourfali:
ovirt-4.2?
gklein: testing_plan_complete- rule-engine: planning_ack? gshereme: devel_ack+ lsvaty: testing_ack+ |
| Hardware: | All | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-12-20 10:43:20 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | UX | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 1370125 | ||
|
Description
Greg Sheremeta
2016-04-04 13:04:26 UTC
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone. 3.3.7 is supposed to have a fix for https://github.com/twbs/bootstrap/issues/17973 : Tooltip causing memory leak PR - https://github.com/twbs/bootstrap/pull/19659 Moving from 4.0 alpha to 4.0 beta since 4.0 alpha has been already released and bug is not ON_QA. oVirt 4.0 beta has been released, moving to RC milestone. iirc we said we will do that for 4.1, right? Is there a bootstrap version with the leak fix? > iirc we said we will do that for 4.1, right? Yes. > Is there a bootstrap version with the leak fix? Not yet. 3.3.7 and 4.0.0 will have it -- neither has been released. Does this also mean we'll get rid of the ancient jQuery 1.x? Given that we already have oVirt JavaScript dependencies packaged via RPM (ovirt-engine-nodejs-modules), I'd prefer to make Engine depend on this RPM and symlink to them from within branding directory, if possible. > Does this also mean we'll get rid of the ancient jQuery 1.x?
Yes. We'll just depend on ovirt-engine-nodejs-modules now.
(In reply to Greg Sheremeta from comment #8) > > Does this also mean we'll get rid of the ancient jQuery 1.x? > > Yes. We'll just depend on ovirt-engine-nodejs-modules now. Correction -- we depend on ovirt-js-dependencies. Verified in ovirt-engine-webadmin-portal-4.2.0-0.0.master.20170903205106.gitb17261a.el7.centos.noarch Web UI sanity tests haven't found any regression. This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017. Since the problem described in this bug report should be resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report. |