Bug 1323918

Summary: Should add "openshift_image_tag" option in atomic-openshift-installer
Product: OpenShift Container Platform Reporter: Gaoyun Pei <gpei>
Component: InstallerAssignee: Samuel Munilla <smunilla>
Status: CLOSED ERRATA QA Contact: Ma xiaoqiang <xiama>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.2.0CC: aos-bugs, bleanhar, jokerman, mmccomas, smunilla, tdawson, xtian
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openshift-ansible-3.0.79-1.git.0.9c75f11.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1328732 (view as bug list) Environment:
Last Closed: 2016-05-12 16:40:00 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1328732    

Description Gaoyun Pei 2016-04-05 05:17:34 UTC
Description of problem:
Now we support both 3.1 and 3.2 containerized installation in latest 3.2 a-o-i, but without openshift_image_tag option, we couldn't make a 3.1 containerized installation after the 3.2 images pushed to registry.access.redhat.com, since the installer will pull the latest ose image by default, which would be 3.2 version.

Version-Release number of selected component (if applicable):
atomic-openshift-utils-3.0.71-1.git.0.63af28f.el7.noarch

How reproducible:
Always

Steps to Reproduce:
1.Run 'atomic-openshift-installer install'. Choose "OpenShift Enterprise 3.1", container install for master and node.
2.Check ansible inventory: ~/.config/openshift/.ansible/hosts


Actual results:
No openshift_image_tag=v3.1.x.x  in [OSEv3:vars] block.

Expected results:
Should set openshift_image_tag=v3.1.x when choosing 3.1 containerized installation.

Additional info:

Comment 1 Brenton Leanhardt 2016-04-05 12:21:52 UTC
I think what we should do is add a v3.1 tag to all the v3.1.1.6 images.  Then the installer would have a consistent openshift_image_tag it could point to.  We'd probably have to make sure the playbooks are explicitly pulling the images when openshift_image_tag is set otherwise if a v3.1.1.7 image was released and also tagged as v3.1 the host wouldn't receive the update.

We'll need to test what happens with the 3.1 playbooks once 3.2 is released.  My hope is that it will not automatically download the 3.2 images.  We should be able to test this in the OSBS registry or Stage.  RCM can probably add the tags for us.

Comment 2 Brenton Leanhardt 2016-04-08 19:36:29 UTC
https://github.com/openshift/openshift-ansible/pull/1735

Comment 3 Gaoyun Pei 2016-04-12 05:05:57 UTC
Test with atomic-openshift-utils-3.0.76-1.git.0.d6d9cba.el7.noarch.

When choosing containerized installation of ose-3.1 or aep-3.1, openshift_image_tag=v3.1.1.6 would be written in the ansible inventory, this works well.

But for rpm installation of ose-3.1 or aep-3.1, openshift_image_tag=v3.1.1.6 still would be configured, and ansible will fail as below: 

TASK: [openshift_master | Install Master package] ***************************** 
failed: [10.x.x.158] => {"changed": false, "failed": true, "rc": 0, "results": []}
msg: No Package matching 'atomic-openshift-masterv3.1.1.6' found available, installed or updated

BZ#1320026 has been filed for this issue, so we better to configure openshift_image_tag=v3.1.1.6 to the host which would be a containerized one.

Comment 4 Brenton Leanhardt 2016-04-12 12:12:48 UTC
Sam, test this with https://github.com/openshift/openshift-ansible/pull/1718.  I have a lot of fixes on that branch.

Comment 5 Samuel Munilla 2016-04-12 18:27:22 UTC
Brenton, same error remained on that PR. Further testing showed we weren't converting image_tags to rpm versions on masters.
https://github.com/openshift/openshift-ansible/pull/1744 opened to address that.

Comment 7 Gaoyun Pei 2016-04-13 03:09:30 UTC
Test this with openshift-ansible-3.0.79-1.git.0.9c75f11.el7.noarch.

For rpm installation of ose-3.1 or aep-3.1, the same error when installing node package:
TASK: [openshift_node | Install Node package] ********************************* 
failed: [10.x.136] => {"changed": false, "failed": true, "rc": 0, "results": []}
msg: No Package matching 'atomic-openshift-nodev3.1.1.6' found available, installed or updated
failed: [10.x.158] => {"changed": false, "failed": true, "rc": 0, "results": []}
msg: No Package matching 'atomic-openshift-nodev3.1.1.6' found available, installed or updated

Comment 8 Samuel Munilla 2016-04-19 17:32:08 UTC
Updated to handle node-only installations and other sundry image_tag things

Comment 9 Gaoyun Pei 2016-04-20 05:05:14 UTC
verify this bug with atomic-openshift-utils-3.0.80-1.git.0.2f46898.el7.noarch

For ose/aep-3.1 product, both containerized and rpm installation could be finished via a-o-i.

Comment 11 errata-xmlrpc 2016-05-12 16:40:00 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1065